[PR PATCH] gping: build against system libgit2

[PR PATCH] gping: build against system libgit2

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gping
https://github.com/void-linux/void-packages/pull/49676

gping: build against system libgit2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Although it doesn't actually link against libgit2.so

A patch file from https://github.com/void-linux/void-packages/pull/49676.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gping-49676.patch --]
[-- Type: text/x-diff, Size: 759 bytes --]

From 52b68f0208f31208aa7196443efd80f545ad3fa7 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 2 Apr 2024 19:01:18 +0530
Subject: [PATCH] gping: build against system libgit2

---
 srcpkgs/gping/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gping/template b/srcpkgs/gping/template
index 8a2eb4e6eca184..efb61575afa2a6 100644
--- a/srcpkgs/gping/template
+++ b/srcpkgs/gping/template
@@ -1,9 +1,11 @@
 # Template file for 'gping'
 pkgname=gping
 version=1.16.1
-revision=1
+revision=2
 build_style=cargo
 make_install_args="--path gping"
+hostmakedepends="pkg-config"
+makedepends="libgit2-devel"
 checkdepends="iputils"
 short_desc="Ping, but with a graph"
 maintainer="icp <pangolin@vivaldi.net>"

Re: [PR PATCH] [Updated] gping: build against system libgit2

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gping
https://github.com/void-linux/void-packages/pull/49676

gping: build against system libgit2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Although it doesn't actually link against libgit2.so

A patch file from https://github.com/void-linux/void-packages/pull/49676.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gping-49676.patch --]
[-- Type: text/x-diff, Size: 773 bytes --]

From 9e3374c2957433a978ffbab0be96010b9a5cee24 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 2 Apr 2024 19:01:18 +0530
Subject: [PATCH] gping: build against system libgit2

---
 srcpkgs/gping/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gping/template b/srcpkgs/gping/template
index 8a2eb4e6eca184..0e88538a4ecd55 100644
--- a/srcpkgs/gping/template
+++ b/srcpkgs/gping/template
@@ -1,9 +1,11 @@
 # Template file for 'gping'
 pkgname=gping
 version=1.16.1
-revision=1
+revision=2
 build_style=cargo
 make_install_args="--path gping"
+hostmakedepends="pkg-config libgit2-devel"
+makedepends="libgit2-devel"
 checkdepends="iputils"
 short_desc="Ping, but with a graph"
 maintainer="icp <pangolin@vivaldi.net>"

Re: gping: build against system libgit2

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/49676#issuecomment-2032967826

Comment:
We could alternatively patch Cargo.toml to disable git2 from the shadow-rs crate, especially since there's no git repo to inspect after all.

Re: [PR PATCH] [Updated] gping: build against system libgit2

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gping
https://github.com/void-linux/void-packages/pull/49676

gping: build against system libgit2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Although it doesn't actually link against libgit2.so

A patch file from https://github.com/void-linux/void-packages/pull/49676.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gping-49676.patch --]
[-- Type: text/x-diff, Size: 743 bytes --]

From 4355870e31915ddf1b60cd69891fd9086ae74cdb Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 2 Apr 2024 19:01:18 +0530
Subject: [PATCH] gping: build against system libgit2

---
 srcpkgs/gping/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gping/template b/srcpkgs/gping/template
index 8a2eb4e6eca184..3de139275dc695 100644
--- a/srcpkgs/gping/template
+++ b/srcpkgs/gping/template
@@ -1,9 +1,10 @@
 # Template file for 'gping'
 pkgname=gping
 version=1.16.1
-revision=1
+revision=2
 build_style=cargo
 make_install_args="--path gping"
+hostmakedepends="pkg-config libgit2-devel"
 checkdepends="iputils"
 short_desc="Ping, but with a graph"
 maintainer="icp <pangolin@vivaldi.net>"

Re: [PR PATCH] [Updated] gping: build against system libgit2

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gping
https://github.com/void-linux/void-packages/pull/49676

gping: build against system libgit2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Although it doesn't actually link against libgit2.so

A patch file from https://github.com/void-linux/void-packages/pull/49676.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gping-49676.patch --]
[-- Type: text/x-diff, Size: 773 bytes --]

From c371ba280df168f7859961ce8cc195554dd3daac Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 2 Apr 2024 19:01:18 +0530
Subject: [PATCH] gping: build against system libgit2

---
 srcpkgs/gping/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gping/template b/srcpkgs/gping/template
index 8a2eb4e6eca184..0e88538a4ecd55 100644
--- a/srcpkgs/gping/template
+++ b/srcpkgs/gping/template
@@ -1,9 +1,11 @@
 # Template file for 'gping'
 pkgname=gping
 version=1.16.1
-revision=1
+revision=2
 build_style=cargo
 make_install_args="--path gping"
+hostmakedepends="pkg-config libgit2-devel"
+makedepends="libgit2-devel"
 checkdepends="iputils"
 short_desc="Ping, but with a graph"
 maintainer="icp <pangolin@vivaldi.net>"

Re: gping: build against system libgit2

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49676#issuecomment-2033729337

Comment:
Those patches get annoying to carry over versions. I sent a patch upstream for now.

Re: [PR REVIEW] gping: build against system libgit2

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New review comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/49676#discussion_r1549561606

Comment:
if it's just the build script then we need only hostmakedepends

Re: [PR REVIEW] gping: build against system libgit2

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49676#discussion_r1549755548

Comment:
Tried that, [didn't work](https://github.com/void-linux/void-packages/actions/runs/8534367101/job/23378632021) for cross. It's not only for build, also in [main]( https://github.com/orf/gping/blob/gping-v1.6.1/gping/src/main.rs#L36).

Re: gping: build against system libgit2

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49676#issuecomment-2034643225

Comment:
Drafting for now since patch release is coming upstream in a couple days with removed dep on libgit2.