[PR PATCH] New package: Webcord-4.8.0

[PR PATCH] New package: Webcord-4.8.0

[end3r-man]

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

There is a new pull request by end3r-man against master on the void-packages repository

https://github.com/end3r-man/void-packages master
https://github.com/void-linux/void-packages/pull/49731

New package: Webcord-4.8.0
#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/49731.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-49731.patch --]
[-- Type: text/x-diff, Size: 1618 bytes --]

From 2b98d3bd8ae272a6a6cff7363e3c9a2ce8fcda02 Mon Sep 17 00:00:00 2001
From: end3r-man <enderman468@duck.com>
Date: Sat, 6 Apr 2024 22:34:11 +0530
Subject: [PATCH] New package: Webcord-4.8.0

---
 srcpkgs/webcord/template | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 srcpkgs/webcord/template

diff --git a/srcpkgs/webcord/template b/srcpkgs/webcord/template
new file mode 100644
index 00000000000000..8f6e033d94c10e
--- /dev/null
+++ b/srcpkgs/webcord/template
@@ -0,0 +1,33 @@
+# Template file for 'webcord'
+pkgname=webcord
+short_desc="A web-based Discord client"
+version=4.8.0
+revision=1
+archs="x86_64"
+create_wrksrc=yes
+maintainer="end3rman <enderman468@duck.com>"
+license="MIT"
+homepage="https://github.com/SpacingBat3/WebCord"
+distfiles="https://github.com/SpacingBat3/WebCord/releases/download/v${version}/webcord_${version}_amd64.deb"
+checksum=10fedeedd5ce6c0bbfbf611f34f658fea35984ecbd302b5921217ad1f9cafc54
+
+
+do_install() {
+	vmkdir usr/lib/webcord
+    vcopy ${wrksrc}/usr/lib/webcord/* usr/lib/webcord
+
+	vmkdir usr/bin
+    vcopy ${wrksrc}/usr/bin/webcord usr/bin
+
+	vmkdir usr/share/applications/
+    vinstall ${wrksrc}/usr/share/applications/webcord.desktop 644 usr/share/applications/
+
+	vmkdir usr/share/doc/webcord/
+    vcopy ${wrksrc}/usr/share/doc/webcord/* usr/share/doc/webcord/
+
+	vmkdir usr/share/lintian/overrides/
+    vcopy ${wrksrc}/usr/share/lintian/overrides/* usr/share/lintian/overrides/
+
+	vmkdir usr/share/lintian/overrides/
+    vinstall ${wrksrc}/usr/share/pixmaps/webcord.png 644 usr/share/pixmaps webcord.png
+}

Re: New package: Webcord-4.8.0

[end3r-man]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by end3r-man on void-packages repository

https://github.com/void-linux/void-packages/pull/49731#issuecomment-2041168268

Comment:
any update on my PR??

Re: New package: Webcord-4.8.0

[meator]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/49731#issuecomment-2041177797

Comment:
Shell globs must be properly quoted.

Every use of `${wrksrc}` in your template is unnecessary.

Taking the program directly from a `.deb` file should be avoided. Such packages do not meet the Compiled package requirement. Properly building the thing should be preferred.

Re: New package: Webcord-4.8.0

[end3r-man]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

New comment by end3r-man on void-packages repository

https://github.com/void-linux/void-packages/pull/49731#issuecomment-2041194028

Comment:
> Shell globs must be properly quoted.
> 
> Every use of `${wrksrc}` in your template is unnecessary.
> 
> Taking the program directly from a `.deb` file should be avoided. Such packages do not meet the Compiled package requirement. Properly building the thing should be preferred.

then getting binary from .deb should be avoided. then only way is getting binary is directly or build from source right??

Re: New package: Webcord-4.8.0

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/49731#issuecomment-2041217876

Comment:
> then getting binary from .deb should be avoided. then only way is getting binary is directly or build from source right??
>
The only way to get this package merged by any chance is to build it from source, yes. Binaries won't be accepted, given the fact that it's an electron app chances it'll be accepted are low anyways.

Re: [PR PATCH] [Closed]: New package: Webcord-4.8.0

[end3r-man]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

There's a closed pull request on the void-packages repository

New package: Webcord-4.8.0
https://github.com/void-linux/void-packages/pull/49731

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)