Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] GIMP 3
@ 2024-04-18  7:24 classabbyamp
  2024-04-18  7:26 ` [PR REVIEW] " classabbyamp
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: classabbyamp @ 2024-04-18  7:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages gimp3
https://github.com/void-linux/void-packages/pull/49890

GIMP 3
WIP until at minimum the full GIMP 3 release, expected in about a month

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**


A patch file from https://github.com/void-linux/void-packages/pull/49890.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gimp3-49890.patch --]
[-- Type: text/x-diff, Size: 24574 bytes --]

From d330997c6868cb21468ebbb847f9e7438781e3a8 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:08 -0400
Subject: [PATCH 1/8] libjxl: disable gimp plugin

gimp 3 supports jxl now, and this would cause a dependency loop
---
 srcpkgs/libjxl/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/libjxl/template b/srcpkgs/libjxl/template
index 88403273d483bf..2e70998346238c 100644
--- a/srcpkgs/libjxl/template
+++ b/srcpkgs/libjxl/template
@@ -1,7 +1,7 @@
 # Template file for 'libjxl'
 pkgname=libjxl
 version=0.10.2
-revision=1
+revision=2
 _testdata_hash=ff8d743aaba05b3014f17e5475e576242fa979fc
 build_style=cmake
 configure_args="-DJPEGXL_ENABLE_BENCHMARK=OFF -DJPEGXL_ENABLE_EXAMPLES=OFF
@@ -9,7 +9,7 @@ configure_args="-DJPEGXL_ENABLE_BENCHMARK=OFF -DJPEGXL_ENABLE_EXAMPLES=OFF
  -DJPEGXL_ENABLE_SKCMS=OFF"
 hostmakedepends="tar pkg-config asciidoc"
 makedepends="brotli-devel highway libpng-devel giflib-devel libjpeg-turbo-devel
- libopenexr-devel libwebp-devel gdk-pixbuf-devel gimp-devel lcms2-devel"
+ libopenexr-devel libwebp-devel gdk-pixbuf-devel lcms2-devel"
 checkdepends="gtest-devel xdg-utils"
 short_desc="JPEG XL image format reference implementation"
 maintainer="Joshua Krämer <joshua@kraemer.link>"
@@ -64,7 +64,6 @@ libjxl-plugins_package() {
 	depends="desktop-file-utils"
 	pkg_install() {
 		vmove usr/lib/gdk-pixbuf-2.0
-		vmove usr/lib/gimp
 		vmove usr/share/mime
 		vmove usr/share/thumbnailers
 	}

From 15df0645d9ad118a332e220ca50694a3ea25b943 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:35 -0400
Subject: [PATCH 2/8] gegl: update to 0.4.48.

---
 srcpkgs/gegl/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gegl/template b/srcpkgs/gegl/template
index 5d4b070cd703ee..f395fe359f2dd1 100644
--- a/srcpkgs/gegl/template
+++ b/srcpkgs/gegl/template
@@ -1,7 +1,7 @@
 # Template file for 'gegl'
 pkgname=gegl
-version=0.4.46
-revision=2
+version=0.4.48
+revision=1
 build_style=meson
 build_helper="gir"
 configure_args="-Ddocs=false -Dintrospection=true -Dvapigen=enabled
@@ -18,7 +18,7 @@ license="GPL-3.0-only, LGPL-3.0-only"
 homepage="https://gegl.org/"
 changelog="https://gitlab.gnome.org/GNOME/gegl/-/raw/master/docs/NEWS.adoc"
 distfiles="https://download.gimp.org/pub/gegl/${version%.*}/gegl-${version}.tar.xz"
-checksum=d0b3b2481bc8774c5f3d0a487611910166d18eef823a859fb91e781ab7b1e892
+checksum=418c26d94be8805d7d98f6de0c6825ca26bd74fcacb6c188da47533d9ee28247
 
 case "$XBPS_TARGET_MACHINE" in
 	arm*) configure_args+=" -Db_lto=false"

From 6cbb4964a25907519e26ce10ec4378ad14b29275 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:29 -0400
Subject: [PATCH 3/8] gimp: update to 2.99.18.

---
 common/shlibs                                 |  18 +-
 srcpkgs/gimp-python                           |   1 -
 srcpkgs/gimp/INSTALL                          |   2 +-
 srcpkgs/gimp/patches/fix-cross.patch          |  18 --
 srcpkgs/gimp/patches/fix-segfault.patch       | 169 ------------------
 srcpkgs/gimp/patches/gcc14.patch              |  63 -------
 .../gimp/patches/install-gimpchoice-h.patch   |  25 +++
 srcpkgs/gimp/template                         |  59 +++---
 8 files changed, 69 insertions(+), 286 deletions(-)
 delete mode 120000 srcpkgs/gimp-python
 delete mode 100644 srcpkgs/gimp/patches/fix-cross.patch
 delete mode 100644 srcpkgs/gimp/patches/fix-segfault.patch
 delete mode 100644 srcpkgs/gimp/patches/gcc14.patch
 create mode 100644 srcpkgs/gimp/patches/install-gimpchoice-h.patch

diff --git a/common/shlibs b/common/shlibs
index 4b88c10b0d390f..7e8a0dd2ec8563 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -549,15 +549,15 @@ libwebkit2gtk-4.1.so.0 libwebkit2gtk41-2.38.0_1
 libjavascriptcoregtk-4.1.so.0 libwebkit2gtk41-2.38.0_1
 libwebkitgtk-6.0.so.4 libwebkitgtk60-2.40.0_1
 libjavascriptcoregtk-6.0.so.1 libwebkitgtk60-2.40.0_1
-libgimp-2.0.so.0 libgimp-2.10.0_1
-libgimpwidgets-2.0.so.0 libgimp-2.10.0_1
-libgimpui-2.0.so.0 libgimp-2.10.0_1
-libgimpbase-2.0.so.0 libgimp-2.10.0_1
-libgimpthumb-2.0.so.0 libgimp-2.10.0_1
-libgimpconfig-2.0.so.0 libgimp-2.10.0_1
-libgimpmath-2.0.so.0 libgimp-2.10.0_1
-libgimpcolor-2.0.so.0 libgimp-2.10.0_1
-libgimpmodule-2.0.so.0 libgimp-2.10.0_1
+libgimp-3.0.so.0 libgimp-2.99.18_1
+libgimpwidgets-3.0.so.0 libgimp-2.99.18_1
+libgimpui-3.0.so.0 libgimp-2.99.18_1
+libgimpbase-3.0.so.0 libgimp-2.99.18_1
+libgimpthumb-3.0.so.0 libgimp-2.99.18_1
+libgimpconfig-3.0.so.0 libgimp-2.99.18_1
+libgimpmath-3.0.so.0 libgimp-2.99.18_1
+libgimpcolor-3.0.so.0 libgimp-2.99.18_1
+libgimpmodule-3.0.so.0 libgimp-2.99.18_1
 libgmic.so.3 gmic-3.1.6_1
 libcgmic.so.3 gmic-3.1.6_1
 libexiv2.so.28 exiv2-0.28.1_1
diff --git a/srcpkgs/gimp-python b/srcpkgs/gimp-python
deleted file mode 120000
index 92344a4bb4a963..00000000000000
--- a/srcpkgs/gimp-python
+++ /dev/null
@@ -1 +0,0 @@
-gimp
\ No newline at end of file
diff --git a/srcpkgs/gimp/INSTALL b/srcpkgs/gimp/INSTALL
index 87064d64438f00..daeff6b33cec0f 100644
--- a/srcpkgs/gimp/INSTALL
+++ b/srcpkgs/gimp/INSTALL
@@ -2,7 +2,7 @@
 case "${ACTION}" in
 pre)
 	if [ "$UPDATE" = "yes" ]; then
-		xbps-query -f gimp | grep "usr/lib/gimp/2.0/plug-ins" | sed -e 's|/||' | xargs rm
+		xbps-query -f gimp | grep "usr/lib/gimp/2.0/plug-ins" | sed -e 's|/||' | xargs rm -f
 	fi
 	;;
 esac
diff --git a/srcpkgs/gimp/patches/fix-cross.patch b/srcpkgs/gimp/patches/fix-cross.patch
deleted file mode 100644
index 0ffcf9b650b987..00000000000000
--- a/srcpkgs/gimp/patches/fix-cross.patch
+++ /dev/null
@@ -1,18 +0,0 @@
---- a/plug-ins/script-fu/Makefile.am	2018-05-18 00:03:53.095184079 +0200
-+++ b/plug-ins/script-fu/Makefile.am	2018-05-18 00:04:50.184762769 +0200
-@@ -14,6 +14,7 @@ else
- libm = -lm
- endif
- 
-+libgimpmodule = $(top_builddir)/libgimpmodule/libgimpmodule-$(GIMP_API_VERSION).la
- libgimpui = $(top_builddir)/libgimp/libgimpui-$(GIMP_API_VERSION).la
- libgimpwidgets = $(top_builddir)/libgimpwidgets/libgimpwidgets-$(GIMP_API_VERSION).la
- libgimp = $(top_builddir)/libgimp/libgimp-$(GIMP_API_VERSION).la
-@@ -85,6 +86,7 @@ script_fu_SOURCES = \
- 	scheme-wrapper.h
- 
- LDADD = \
-+	$(libgimpmodule) \
- 	$(libgimpui)		\
- 	$(libgimpwidgets)	\
- 	$(libgimpconfig)	\
diff --git a/srcpkgs/gimp/patches/fix-segfault.patch b/srcpkgs/gimp/patches/fix-segfault.patch
deleted file mode 100644
index 5f1a6a6d3fe977..00000000000000
--- a/srcpkgs/gimp/patches/fix-segfault.patch
+++ /dev/null
@@ -1,169 +0,0 @@
-diff --git app/dialogs/dialogs.c app/dialogs/dialogs.c
-index 064f2c4..b17d82f 100644
---- a/app/dialogs/dialogs.c
-+++ b/app/dialogs/dialogs.c
-@@ -534,11 +534,15 @@ dialogs_init (Gimp            *gimp,
-                                      menu_factory);
-   gimp_dialog_factory_set_singleton (factory);
- 
--  for (i = 0; i < G_N_ELEMENTS (entries); i++)
-+  for (i = 0; i < G_N_ELEMENTS (entries); i++) {
-+    char *name, *blurb;
-+    name = entries[i].name ? gettext(entries[i].name) : NULL;
-+    blurb = entries[i].blurb ? gettext(entries[i].blurb) : NULL;
-+
-     gimp_dialog_factory_register_entry (factory,
-                                         entries[i].identifier,
--                                        gettext (entries[i].name),
--                                        gettext (entries[i].blurb),
-+                                        name,
-+                                        blurb,
-                                         entries[i].icon_name,
-                                         entries[i].help_id,
-                                         entries[i].new_func,
-@@ -551,6 +555,7 @@ dialogs_init (Gimp            *gimp,
-                                         entries[i].hideable,
-                                         entries[i].image_window,
-                                         entries[i].dockable);
-+  }
- 
-   global_recent_docks = gimp_list_new (GIMP_TYPE_SESSION_INFO, FALSE);
- }
-diff --git app/widgets/gimpactiongroup.c app/widgets/gimpactiongroup.c
-index 04bd1b6..12eff51 100644
---- a/app/widgets/gimpactiongroup.c
-+++ b/app/widgets/gimpactiongroup.c
-@@ -393,7 +393,7 @@ gimp_action_group_add_actions (GimpActionGroup       *group,
-   for (i = 0; i < n_entries; i++)
-     {
-       GimpAction  *action;
--      const gchar *label;
-+      const gchar *label   = NULL;
-       const gchar *tooltip = NULL;
- 
-       if (! gimp_action_group_check_unique_action (group, entries[i].name))
-@@ -401,15 +401,18 @@ gimp_action_group_add_actions (GimpActionGroup       *group,
- 
-       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_action_impl_new (entries[i].name, label, tooltip,
-@@ -450,15 +453,18 @@ gimp_action_group_add_toggle_actions (GimpActionGroup             *group,
- 
-       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_toggle_action_new (entries[i].name, label, tooltip,
-@@ -504,17 +510,20 @@ gimp_action_group_add_radio_actions (GimpActionGroup            *group,
-       if (! gimp_action_group_check_unique_action (group, entries[i].name))
-         continue;
- 
--      if (msg_context)
-+       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_radio_action_new (entries[i].name, label, tooltip,
-@@ -560,7 +569,7 @@ gimp_action_group_add_enum_actions (GimpActionGroup           *group,
-   for (i = 0; i < n_entries; i++)
-     {
-       GimpEnumAction *action;
--      const gchar    *label;
-+      const gchar    *label   = NULL;
-       const gchar    *tooltip = NULL;
- 
-       if (! gimp_action_group_check_unique_action (group, entries[i].name))
-@@ -568,15 +577,18 @@ gimp_action_group_add_enum_actions (GimpActionGroup           *group,
- 
-       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_enum_action_new (entries[i].name, label, tooltip,
-@@ -618,17 +630,20 @@ gimp_action_group_add_string_actions (GimpActionGroup             *group,
-       if (! gimp_action_group_check_unique_action (group, entries[i].name))
-         continue;
- 
--      if (msg_context)
-+       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_string_action_new (entries[i].name, label, tooltip,
diff --git a/srcpkgs/gimp/patches/gcc14.patch b/srcpkgs/gimp/patches/gcc14.patch
deleted file mode 100644
index ceae92fa154c82..00000000000000
--- a/srcpkgs/gimp/patches/gcc14.patch
+++ /dev/null
@@ -1,63 +0,0 @@
-From 99531e73e95bf6de4aed9bf64ac3f306e6dfb490 Mon Sep 17 00:00:00 2001
-From: Florian Weimer <fweimer@redhat.com>
-Date: Fri, 13 Jan 2023 13:29:07 +0100
-Subject: [PATCH] configure.ac: Improve C99 compatibility of IPC_RMID check
-
-Do not call the undeclared exit function.  Implicit function
-declarations are likely not going to be supported by future compilers
-by default, changing the outcome of this configure probe with
-such compilers.
----
- configure.ac | 6 +++---
- 1 file changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/configure.ac b/configure.ac
-index 03047899841..b8718955471 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -1254,17 +1254,17 @@ elif test "x$shmtype" = "xsysv"; then
- 	  char *shmaddr;
- 	id = shmget (IPC_PRIVATE, 4, IPC_CREAT | 0600);
- 	if (id == -1)
--	  exit (2);
-+	  return 2;
- 	  shmaddr = shmat (id, 0, 0);
- 	  shmctl (id, IPC_RMID, 0);
- 	  if ((char*) shmat (id, 0, 0) == (char*) -1)
- 	  {
- 	    shmdt (shmaddr);
--	    exit (1);
-+	    return 1;
- 	  }
- 	  shmdt (shmaddr);
- 	  shmdt (shmaddr);
--	  exit (0);
-+	  return 0;
- 	}
-       ]])],
-       [AC_DEFINE([IPC_RMID_DEFERRED_RELEASE],[1],
-diff --git a/configure b/configure
-index 6e62da8e3c164f82..f1c447baf7ff68f7 100755
---- a/configure
-+++ b/configure
-@@ -28898,17 +28898,17 @@ else $as_nop
- 	  char *shmaddr;
- 	id = shmget (IPC_PRIVATE, 4, IPC_CREAT | 0600);
- 	if (id == -1)
--	  exit (2);
-+	  return 2;
- 	  shmaddr = shmat (id, 0, 0);
- 	  shmctl (id, IPC_RMID, 0);
- 	  if ((char*) shmat (id, 0, 0) == (char*) -1)
- 	  {
- 	    shmdt (shmaddr);
--	    exit (1);
-+	    return 1;
- 	  }
- 	  shmdt (shmaddr);
- 	  shmdt (shmaddr);
--	  exit (0);
-+	  return 0;
- 	}
- 
- _ACEOF
diff --git a/srcpkgs/gimp/patches/install-gimpchoice-h.patch b/srcpkgs/gimp/patches/install-gimpchoice-h.patch
new file mode 100644
index 00000000000000..533b14d397f814
--- /dev/null
+++ b/srcpkgs/gimp/patches/install-gimpchoice-h.patch
@@ -0,0 +1,25 @@
+From 11892f1d83ffc465346dab7e2e8c6e790f555a64 Mon Sep 17 00:00:00 2001
+From: Jehan <jehan@girinstud.io>
+Date: Wed, 21 Feb 2024 11:08:23 +0100
+Subject: [PATCH] Issue #10900: install missing gimpchoice.h.
+
+Argh how this could pass without anyone noticing?!
+---
+ libgimpbase/meson.build | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libgimpbase/meson.build b/libgimpbase/meson.build
+index a77d125f39d..a2c27016b10 100644
+--- a/libgimpbase/meson.build
++++ b/libgimpbase/meson.build
+@@ -84,6 +84,7 @@ libgimpbase_headers_introspectable = files(
+   'gimpbaseenums.h',
+   'gimpbasetypes.h',
+   'gimpchecks.h',
++  'gimpchoice.h',
+   'gimpcpuaccel.h',
+   'gimpenv.h',
+   'gimplimits.h',
+-- 
+GitLab
+
diff --git a/srcpkgs/gimp/template b/srcpkgs/gimp/template
index 39532a8d8c99df..45b0e47cdad3be 100644
--- a/srcpkgs/gimp/template
+++ b/srcpkgs/gimp/template
@@ -1,34 +1,40 @@
 # Template file for 'gimp'
 pkgname=gimp
-version=2.10.36
+version=2.99.18
 revision=1
-build_style=gnu-configure
-configure_args="--disable-check-update --datadir=/usr/share --disable-python"
-hostmakedepends="automake gegl gettext-devel glib-devel gtk+-devel intltool
- libtool pkg-config perl-XML-Parser gtk-doc iso-codes"
-makedepends="aalib-devel alsa-lib-devel babl-devel dbus-glib-devel gegl-devel
- ghostscript-devel jasper-devel lcms2-devel libXcursor-devel libXpm-devel
- libgexiv2-devel libgudev-devel libmng-devel libmypaint-devel
- libopenexr-devel librsvg-devel libwmf-devel mypaint-brushes1
- poppler-glib-devel glib-networking libwebp-devel
- libheif-devel libopenjpeg2-devel x265-devel gtk+-devel"
-depends="desktop-file-utils hicolor-icon-theme iso-codes mypaint-brushes1"
+build_style=meson
+build_helper="gir"
+configure_args="-Dcheck-update=no -Drevision=$revision -Denable-default-bin=enabled
+ $(vopt_bool gir g-ir-doc) $(vopt_bool gir can-crosscompile-gir)
+ -Dbug-report-url=https://github.com/void-linux/void-packages/issues/new/choose"
+hostmakedepends="pkg-config xdg-utils perl libxslt gjs LuaJIT desktop-file-utils
+ AppStream gi-docgen gettext gobject-introspection yelp-tools"
+makedepends="babl-devel gtk+3-devel gegl-devel libgexiv2-devel libgirepository-devel
+ libmypaint-devel mypaint-brushes1 librsvg-devel glib-networking appstream-glib-devel
+ libXmu-devel ghostscript-devel libmng-devel aalib-devel libXpm-devel libopenexr-devel
+ libwebp-devel libheif-devel poppler-glib-devel libwmf-devel libopenjpeg2-devel
+ libjxl-devel alsa-lib-devel cfitsio-devel python3-gobject-devel libgomp-devel
+ libunwind-devel lua51-lgi"
+depends="desktop-file-utils hicolor-icon-theme iso-codes mypaint-brushes1 python3-gobject"
+checkdepends="xvfb-run dbus"
 short_desc="GNU image manipulation program"
-conf_files="/etc/gimp/${version%%.*}.0/*"
+#conf_files="/etc/gimp/${version%%.*}.0/*"
+conf_files="/etc/gimp/${version%.*}/*"
 maintainer="fosslinux <fosslinux@aussies.space>"
 license="GPL-3.0-only"
 homepage="https://www.gimp.org"
-changelog="https://gitlab.gnome.org/GNOME/gimp/-/raw/gimp-2-10/NEWS"
-distfiles="https://download.gimp.org/pub/gimp/v${version%.*}/gimp-${version}.tar.bz2"
-checksum=3d3bc3c69a4bdb3aea9ba2d5385ed98ea03953f3857aafd1d6976011ed7cdbb2
+distfiles="https://download.gimp.org/gimp/v${version%.*}/gimp-${version}.tar.xz"
+checksum=8c1bb7a94ac0d4d0cde4d701d8b356387c2ecd87abbd35bbf7d222d40f6ddb6e
 lib32disabled=yes
-no_generic_pkgconfig_link=yes
 
-pre_configure() {
-	NOCONFIGURE=1 autoreconf -fi
-	# don't allow configure to set DATADIRNAME=lib
-	vsed -i 's/DATADIRNAME=lib/DATADIRNAME=share/' configure
-}
+build_options="gir"
+build_options_default="gir"
+
+if [ -n "$XBPS_CHECK_PKGS" ]; then
+	configure_args+=" -Dheadless-tests=enabled"
+else
+	configure_args+=" -Dheadless-tests=disabled"
+fi
 
 libgimp_package() {
 	short_desc+=" - runtime libraries"
@@ -38,13 +44,16 @@ libgimp_package() {
 }
 
 gimp-devel_package() {
-	depends="gegl-devel gtk+-devel lcms2-devel libgimp>=${version}_${revision}"
+	depends="libgimp>=${version}_${revision} gegl-devel gtk+3-devel libgexiv2-devel"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include
 		vmove usr/lib/pkgconfig
-		vmove usr/share/gtk-doc
-		vmove usr/share/aclocal
+		vmove usr/share/doc
 		vmove "usr/lib/*.so"
+		if [ "$build_option_gir" ]; then
+			vmove usr/share/gir-1.0
+			vmove usr/share/vala
+		fi
 	}
 }

From 4e3ea0896cbd54ece1740153d125159240041aae Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:09 -0400
Subject: [PATCH 4/8] gmic: rebuild for gimp 3

---
 srcpkgs/gmic/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gmic/template b/srcpkgs/gmic/template
index fa37651bb6deea..24d10147e3abad 100644
--- a/srcpkgs/gmic/template
+++ b/srcpkgs/gmic/template
@@ -1,7 +1,7 @@
 # Template file for 'gmic'
 pkgname=gmic
 version=3.1.6
-revision=5
+revision=6
 _zart_hash=34ebf6cce0bafb98abe57cec83c4a02cd1abeca0
 create_wrksrc=yes
 build_wrksrc="src"

From aca92a2abae05416f3e836bfc12f731ed6fa0891 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:10 -0400
Subject: [PATCH 5/8] nufraw: rebuild for gimp 3

---
 srcpkgs/nufraw/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/nufraw/template b/srcpkgs/nufraw/template
index 551f263df96d38..86a4d73adb797f 100644
--- a/srcpkgs/nufraw/template
+++ b/srcpkgs/nufraw/template
@@ -1,7 +1,7 @@
 # Template file for 'nufraw'
 pkgname=nufraw
 version=0.43.3
-revision=1
+revision=2
 _ver="${version%.*}-${version##*.}"
 build_style=gnu-configure
 configure_args="--enable-contrast --enable-mime --enable-openmp --with-gimp

From aa93a4ff75b2aec7e77b8b84f7acc52cb6ad5092 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:11 -0400
Subject: [PATCH 6/8] xsane: rebuild for gimp 3

---
 srcpkgs/xsane/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xsane/template b/srcpkgs/xsane/template
index 7dde32af2b674c..0f69c0f65fe6b8 100644
--- a/srcpkgs/xsane/template
+++ b/srcpkgs/xsane/template
@@ -1,7 +1,7 @@
 # Template file for 'xsane'
 pkgname=xsane
 version=0.999
-revision=5
+revision=6
 hostmakedepends="pkg-config sane-devel gettext"
 makedepends="gtk+-devel lcms-devel sane-devel gimp-devel"
 depends="sane"

From ff4fdb33fbc88c6fcb29b7f3e8f75ea34a28a7ac Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:11 -0400
Subject: [PATCH 7/8] gimp-lqr-plugin: rebuild for gimp 3

---
 srcpkgs/gimp-lqr-plugin/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gimp-lqr-plugin/template b/srcpkgs/gimp-lqr-plugin/template
index 7878f6cb795d24..9a516b3798b0e0 100644
--- a/srcpkgs/gimp-lqr-plugin/template
+++ b/srcpkgs/gimp-lqr-plugin/template
@@ -1,7 +1,7 @@
 # Template file for 'gimp-lqr-plugin'
 pkgname=gimp-lqr-plugin
 version=0.7.2
-revision=2
+revision=3
 build_style=gnu-configure
 hostmakedepends="automake intltool pkg-config"
 makedepends="gimp-devel glib-devel gettext-devel liblqr-devel"

From 400d9da2a4bb4411c81b0e3961d1b7dcc0c7bea3 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 03:22:14 -0400
Subject: [PATCH 8/8] resynthesizer: update to 2.0.3+2.

WIP gimp 3 port
---
 srcpkgs/resynthesizer/template | 26 +++++++-------------------
 1 file changed, 7 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/resynthesizer/template b/srcpkgs/resynthesizer/template
index a58b0eec995854..68be9e18dd0ffe 100644
--- a/srcpkgs/resynthesizer/template
+++ b/srcpkgs/resynthesizer/template
@@ -1,26 +1,14 @@
 # Template file for 'resynthesizer'
 pkgname=resynthesizer
-version=2.0.3+1
+version=2.0.3+2
 revision=1
-_commit=701e890d1d456e215e05daa7b4a88f5d9c6c03b3
-build_style=gnu-configure
-hostmakedepends="automake intltool pkg-config"
+_commit=dee67110c51cbc69c28435ac7485766c3eb30a94
+build_style=meson
+hostmakedepends="pkg-config"
 makedepends="gimp-devel glib-devel gettext-devel"
 short_desc="Suite of gimp plugins for texture healing and synthesis"
 maintainer="CoolOhm <micvlas@gmail.com>"
 license="GPL-2.0-or-later"
-# FIXME: when gimp 3 is available, switch back to bootchk upstream
-#homepage="https://github.com/bootchk/resynthesizer"
-#distfiles="https://github.com/bootchk/resynthesizer/archive/refs/tags/v${version}.tar.gz"
-homepage="https://github.com/itr-tert/gimp-resynthesizer-scm"
-distfiles="https://github.com/itr-tert/gimp-resynthesizer-scm/archive/${_commit}.tar.gz"
-checksum=298286386466fbd6d2da06f8a920c6e6e313db7ca0a094a36a355978a64cefc0
-
-if [ "$CROSS_BUILD" ];then
-	hostmakedepends+=" glib-devel gettext-devel"
-	AUTOGEN_CONFIGURE_ARGS+=" --host=${XBPS_MACHINE%-musl} --build=${XBPS_CROSS_TRIPLET}"
-fi
-
-pre_configure() {
-	./autogen.sh ${AUTOGEN_CONFIGURE_ARGS}
-}
+homepage="https://github.com/bootchk/resynthesizer"
+distfiles="https://github.com/bootchk/resynthesizer/archive/${_commit}.tar.gz"
+checksum=a9ae689f5c10e284b0b8cab03baa05caab029fae2250bcdcc7e1d3ec6f8c367d

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] GIMP 3
  2024-04-18  7:24 [PR PATCH] GIMP 3 classabbyamp
  2024-04-18  7:26 ` [PR REVIEW] " classabbyamp
@ 2024-04-18  7:26 ` classabbyamp
  2024-04-21 20:02 ` [PR PATCH] [Updated] " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2024-04-18  7:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49890#discussion_r1570150739

Comment:
TODO

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] GIMP 3
  2024-04-18  7:24 [PR PATCH] GIMP 3 classabbyamp
@ 2024-04-18  7:26 ` classabbyamp
  2024-04-18  7:26 ` classabbyamp
  2024-04-21 20:02 ` [PR PATCH] [Updated] " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2024-04-18  7:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49890#discussion_r1570149887

Comment:
TODO: update minver for main release

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] GIMP 3
  2024-04-18  7:24 [PR PATCH] GIMP 3 classabbyamp
  2024-04-18  7:26 ` [PR REVIEW] " classabbyamp
  2024-04-18  7:26 ` classabbyamp
@ 2024-04-21 20:02 ` classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2024-04-21 20:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages gimp3
https://github.com/void-linux/void-packages/pull/49890

GIMP 3
WIP until at minimum the full GIMP 3 release, expected in about a month: https://gitlab.gnome.org/GNOME/gimp/-/issues/10373

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

#### Plugins
- [ ] nufraw - not (yet) compatible
- [ ] resynthesizer - compatible on in-dev branch
- [ ] gmic - not (yet) compatible
- [ ] xsane
- [ ] gimp-lqr-plugin - not (yet) compatible)
- [x] libjxl - disable because gimp supports it directly now

A patch file from https://github.com/void-linux/void-packages/pull/49890.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gimp3-49890.patch --]
[-- Type: text/x-diff, Size: 24587 bytes --]

From e9cd8a2130b2d32b04a44c85a64327b31f169357 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:08 -0400
Subject: [PATCH 1/8] libjxl: disable gimp plugin

gimp 3 supports jxl now, and this would cause a dependency loop
---
 srcpkgs/libjxl/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/libjxl/template b/srcpkgs/libjxl/template
index 88403273d483bf..2e70998346238c 100644
--- a/srcpkgs/libjxl/template
+++ b/srcpkgs/libjxl/template
@@ -1,7 +1,7 @@
 # Template file for 'libjxl'
 pkgname=libjxl
 version=0.10.2
-revision=1
+revision=2
 _testdata_hash=ff8d743aaba05b3014f17e5475e576242fa979fc
 build_style=cmake
 configure_args="-DJPEGXL_ENABLE_BENCHMARK=OFF -DJPEGXL_ENABLE_EXAMPLES=OFF
@@ -9,7 +9,7 @@ configure_args="-DJPEGXL_ENABLE_BENCHMARK=OFF -DJPEGXL_ENABLE_EXAMPLES=OFF
  -DJPEGXL_ENABLE_SKCMS=OFF"
 hostmakedepends="tar pkg-config asciidoc"
 makedepends="brotli-devel highway libpng-devel giflib-devel libjpeg-turbo-devel
- libopenexr-devel libwebp-devel gdk-pixbuf-devel gimp-devel lcms2-devel"
+ libopenexr-devel libwebp-devel gdk-pixbuf-devel lcms2-devel"
 checkdepends="gtest-devel xdg-utils"
 short_desc="JPEG XL image format reference implementation"
 maintainer="Joshua Krämer <joshua@kraemer.link>"
@@ -64,7 +64,6 @@ libjxl-plugins_package() {
 	depends="desktop-file-utils"
 	pkg_install() {
 		vmove usr/lib/gdk-pixbuf-2.0
-		vmove usr/lib/gimp
 		vmove usr/share/mime
 		vmove usr/share/thumbnailers
 	}

From 0197641a0f153b66af34c713c966612a8f200991 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:35 -0400
Subject: [PATCH 2/8] gegl: update to 0.4.48.

---
 srcpkgs/gegl/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gegl/template b/srcpkgs/gegl/template
index 5d4b070cd703ee..f395fe359f2dd1 100644
--- a/srcpkgs/gegl/template
+++ b/srcpkgs/gegl/template
@@ -1,7 +1,7 @@
 # Template file for 'gegl'
 pkgname=gegl
-version=0.4.46
-revision=2
+version=0.4.48
+revision=1
 build_style=meson
 build_helper="gir"
 configure_args="-Ddocs=false -Dintrospection=true -Dvapigen=enabled
@@ -18,7 +18,7 @@ license="GPL-3.0-only, LGPL-3.0-only"
 homepage="https://gegl.org/"
 changelog="https://gitlab.gnome.org/GNOME/gegl/-/raw/master/docs/NEWS.adoc"
 distfiles="https://download.gimp.org/pub/gegl/${version%.*}/gegl-${version}.tar.xz"
-checksum=d0b3b2481bc8774c5f3d0a487611910166d18eef823a859fb91e781ab7b1e892
+checksum=418c26d94be8805d7d98f6de0c6825ca26bd74fcacb6c188da47533d9ee28247
 
 case "$XBPS_TARGET_MACHINE" in
 	arm*) configure_args+=" -Db_lto=false"

From 24dd3eafb29db334fd95f40a888e47efc464f7fe Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:29 -0400
Subject: [PATCH 3/8] gimp: update to 2.99.18.

---
 common/shlibs                                 |  18 +-
 srcpkgs/gimp-python                           |   1 -
 srcpkgs/gimp/INSTALL                          |   2 +-
 srcpkgs/gimp/patches/fix-cross.patch          |  18 --
 srcpkgs/gimp/patches/fix-segfault.patch       | 169 ------------------
 srcpkgs/gimp/patches/gcc14.patch              |  63 -------
 .../gimp/patches/install-gimpchoice-h.patch   |  25 +++
 srcpkgs/gimp/template                         |  61 ++++---
 8 files changed, 70 insertions(+), 287 deletions(-)
 delete mode 120000 srcpkgs/gimp-python
 delete mode 100644 srcpkgs/gimp/patches/fix-cross.patch
 delete mode 100644 srcpkgs/gimp/patches/fix-segfault.patch
 delete mode 100644 srcpkgs/gimp/patches/gcc14.patch
 create mode 100644 srcpkgs/gimp/patches/install-gimpchoice-h.patch

diff --git a/common/shlibs b/common/shlibs
index c4a876216d6397..7ce16b68e02d42 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -549,15 +549,15 @@ libwebkit2gtk-4.1.so.0 libwebkit2gtk41-2.38.0_1
 libjavascriptcoregtk-4.1.so.0 libwebkit2gtk41-2.38.0_1
 libwebkitgtk-6.0.so.4 libwebkitgtk60-2.40.0_1
 libjavascriptcoregtk-6.0.so.1 libwebkitgtk60-2.40.0_1
-libgimp-2.0.so.0 libgimp-2.10.0_1
-libgimpwidgets-2.0.so.0 libgimp-2.10.0_1
-libgimpui-2.0.so.0 libgimp-2.10.0_1
-libgimpbase-2.0.so.0 libgimp-2.10.0_1
-libgimpthumb-2.0.so.0 libgimp-2.10.0_1
-libgimpconfig-2.0.so.0 libgimp-2.10.0_1
-libgimpmath-2.0.so.0 libgimp-2.10.0_1
-libgimpcolor-2.0.so.0 libgimp-2.10.0_1
-libgimpmodule-2.0.so.0 libgimp-2.10.0_1
+libgimp-3.0.so.0 libgimp-2.99.18_1
+libgimpwidgets-3.0.so.0 libgimp-2.99.18_1
+libgimpui-3.0.so.0 libgimp-2.99.18_1
+libgimpbase-3.0.so.0 libgimp-2.99.18_1
+libgimpthumb-3.0.so.0 libgimp-2.99.18_1
+libgimpconfig-3.0.so.0 libgimp-2.99.18_1
+libgimpmath-3.0.so.0 libgimp-2.99.18_1
+libgimpcolor-3.0.so.0 libgimp-2.99.18_1
+libgimpmodule-3.0.so.0 libgimp-2.99.18_1
 libgmic.so.3 gmic-3.1.6_1
 libcgmic.so.3 gmic-3.1.6_1
 libexiv2.so.28 exiv2-0.28.1_1
diff --git a/srcpkgs/gimp-python b/srcpkgs/gimp-python
deleted file mode 120000
index 92344a4bb4a963..00000000000000
--- a/srcpkgs/gimp-python
+++ /dev/null
@@ -1 +0,0 @@
-gimp
\ No newline at end of file
diff --git a/srcpkgs/gimp/INSTALL b/srcpkgs/gimp/INSTALL
index 87064d64438f00..daeff6b33cec0f 100644
--- a/srcpkgs/gimp/INSTALL
+++ b/srcpkgs/gimp/INSTALL
@@ -2,7 +2,7 @@
 case "${ACTION}" in
 pre)
 	if [ "$UPDATE" = "yes" ]; then
-		xbps-query -f gimp | grep "usr/lib/gimp/2.0/plug-ins" | sed -e 's|/||' | xargs rm
+		xbps-query -f gimp | grep "usr/lib/gimp/2.0/plug-ins" | sed -e 's|/||' | xargs rm -f
 	fi
 	;;
 esac
diff --git a/srcpkgs/gimp/patches/fix-cross.patch b/srcpkgs/gimp/patches/fix-cross.patch
deleted file mode 100644
index 0ffcf9b650b987..00000000000000
--- a/srcpkgs/gimp/patches/fix-cross.patch
+++ /dev/null
@@ -1,18 +0,0 @@
---- a/plug-ins/script-fu/Makefile.am	2018-05-18 00:03:53.095184079 +0200
-+++ b/plug-ins/script-fu/Makefile.am	2018-05-18 00:04:50.184762769 +0200
-@@ -14,6 +14,7 @@ else
- libm = -lm
- endif
- 
-+libgimpmodule = $(top_builddir)/libgimpmodule/libgimpmodule-$(GIMP_API_VERSION).la
- libgimpui = $(top_builddir)/libgimp/libgimpui-$(GIMP_API_VERSION).la
- libgimpwidgets = $(top_builddir)/libgimpwidgets/libgimpwidgets-$(GIMP_API_VERSION).la
- libgimp = $(top_builddir)/libgimp/libgimp-$(GIMP_API_VERSION).la
-@@ -85,6 +86,7 @@ script_fu_SOURCES = \
- 	scheme-wrapper.h
- 
- LDADD = \
-+	$(libgimpmodule) \
- 	$(libgimpui)		\
- 	$(libgimpwidgets)	\
- 	$(libgimpconfig)	\
diff --git a/srcpkgs/gimp/patches/fix-segfault.patch b/srcpkgs/gimp/patches/fix-segfault.patch
deleted file mode 100644
index 5f1a6a6d3fe977..00000000000000
--- a/srcpkgs/gimp/patches/fix-segfault.patch
+++ /dev/null
@@ -1,169 +0,0 @@
-diff --git app/dialogs/dialogs.c app/dialogs/dialogs.c
-index 064f2c4..b17d82f 100644
---- a/app/dialogs/dialogs.c
-+++ b/app/dialogs/dialogs.c
-@@ -534,11 +534,15 @@ dialogs_init (Gimp            *gimp,
-                                      menu_factory);
-   gimp_dialog_factory_set_singleton (factory);
- 
--  for (i = 0; i < G_N_ELEMENTS (entries); i++)
-+  for (i = 0; i < G_N_ELEMENTS (entries); i++) {
-+    char *name, *blurb;
-+    name = entries[i].name ? gettext(entries[i].name) : NULL;
-+    blurb = entries[i].blurb ? gettext(entries[i].blurb) : NULL;
-+
-     gimp_dialog_factory_register_entry (factory,
-                                         entries[i].identifier,
--                                        gettext (entries[i].name),
--                                        gettext (entries[i].blurb),
-+                                        name,
-+                                        blurb,
-                                         entries[i].icon_name,
-                                         entries[i].help_id,
-                                         entries[i].new_func,
-@@ -551,6 +555,7 @@ dialogs_init (Gimp            *gimp,
-                                         entries[i].hideable,
-                                         entries[i].image_window,
-                                         entries[i].dockable);
-+  }
- 
-   global_recent_docks = gimp_list_new (GIMP_TYPE_SESSION_INFO, FALSE);
- }
-diff --git app/widgets/gimpactiongroup.c app/widgets/gimpactiongroup.c
-index 04bd1b6..12eff51 100644
---- a/app/widgets/gimpactiongroup.c
-+++ b/app/widgets/gimpactiongroup.c
-@@ -393,7 +393,7 @@ gimp_action_group_add_actions (GimpActionGroup       *group,
-   for (i = 0; i < n_entries; i++)
-     {
-       GimpAction  *action;
--      const gchar *label;
-+      const gchar *label   = NULL;
-       const gchar *tooltip = NULL;
- 
-       if (! gimp_action_group_check_unique_action (group, entries[i].name))
-@@ -401,15 +401,18 @@ gimp_action_group_add_actions (GimpActionGroup       *group,
- 
-       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_action_impl_new (entries[i].name, label, tooltip,
-@@ -450,15 +453,18 @@ gimp_action_group_add_toggle_actions (GimpActionGroup             *group,
- 
-       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_toggle_action_new (entries[i].name, label, tooltip,
-@@ -504,17 +510,20 @@ gimp_action_group_add_radio_actions (GimpActionGroup            *group,
-       if (! gimp_action_group_check_unique_action (group, entries[i].name))
-         continue;
- 
--      if (msg_context)
-+       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_radio_action_new (entries[i].name, label, tooltip,
-@@ -560,7 +569,7 @@ gimp_action_group_add_enum_actions (GimpActionGroup           *group,
-   for (i = 0; i < n_entries; i++)
-     {
-       GimpEnumAction *action;
--      const gchar    *label;
-+      const gchar    *label   = NULL;
-       const gchar    *tooltip = NULL;
- 
-       if (! gimp_action_group_check_unique_action (group, entries[i].name))
-@@ -568,15 +577,18 @@ gimp_action_group_add_enum_actions (GimpActionGroup           *group,
- 
-       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_enum_action_new (entries[i].name, label, tooltip,
-@@ -618,17 +630,20 @@ gimp_action_group_add_string_actions (GimpActionGroup             *group,
-       if (! gimp_action_group_check_unique_action (group, entries[i].name))
-         continue;
- 
--      if (msg_context)
-+       if (msg_context)
-         {
--          label = g_dpgettext2 (NULL, msg_context, entries[i].label);
-+          if (entries[i].label)
-+            label = g_dpgettext2 (NULL, msg_context, entries[i].label);
- 
-           if (entries[i].tooltip)
-             tooltip = g_dpgettext2 (NULL, msg_context, entries[i].tooltip);
-         }
-       else
-         {
--          label   = gettext (entries[i].label);
--          tooltip = gettext (entries[i].tooltip);
-+          if (entries[i].label)
-+            label   = gettext (entries[i].label);
-+          if (entries[i].tooltip)
-+            tooltip = gettext (entries[i].tooltip);
-         }
- 
-       action = gimp_string_action_new (entries[i].name, label, tooltip,
diff --git a/srcpkgs/gimp/patches/gcc14.patch b/srcpkgs/gimp/patches/gcc14.patch
deleted file mode 100644
index ceae92fa154c82..00000000000000
--- a/srcpkgs/gimp/patches/gcc14.patch
+++ /dev/null
@@ -1,63 +0,0 @@
-From 99531e73e95bf6de4aed9bf64ac3f306e6dfb490 Mon Sep 17 00:00:00 2001
-From: Florian Weimer <fweimer@redhat.com>
-Date: Fri, 13 Jan 2023 13:29:07 +0100
-Subject: [PATCH] configure.ac: Improve C99 compatibility of IPC_RMID check
-
-Do not call the undeclared exit function.  Implicit function
-declarations are likely not going to be supported by future compilers
-by default, changing the outcome of this configure probe with
-such compilers.
----
- configure.ac | 6 +++---
- 1 file changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/configure.ac b/configure.ac
-index 03047899841..b8718955471 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -1254,17 +1254,17 @@ elif test "x$shmtype" = "xsysv"; then
- 	  char *shmaddr;
- 	id = shmget (IPC_PRIVATE, 4, IPC_CREAT | 0600);
- 	if (id == -1)
--	  exit (2);
-+	  return 2;
- 	  shmaddr = shmat (id, 0, 0);
- 	  shmctl (id, IPC_RMID, 0);
- 	  if ((char*) shmat (id, 0, 0) == (char*) -1)
- 	  {
- 	    shmdt (shmaddr);
--	    exit (1);
-+	    return 1;
- 	  }
- 	  shmdt (shmaddr);
- 	  shmdt (shmaddr);
--	  exit (0);
-+	  return 0;
- 	}
-       ]])],
-       [AC_DEFINE([IPC_RMID_DEFERRED_RELEASE],[1],
-diff --git a/configure b/configure
-index 6e62da8e3c164f82..f1c447baf7ff68f7 100755
---- a/configure
-+++ b/configure
-@@ -28898,17 +28898,17 @@ else $as_nop
- 	  char *shmaddr;
- 	id = shmget (IPC_PRIVATE, 4, IPC_CREAT | 0600);
- 	if (id == -1)
--	  exit (2);
-+	  return 2;
- 	  shmaddr = shmat (id, 0, 0);
- 	  shmctl (id, IPC_RMID, 0);
- 	  if ((char*) shmat (id, 0, 0) == (char*) -1)
- 	  {
- 	    shmdt (shmaddr);
--	    exit (1);
-+	    return 1;
- 	  }
- 	  shmdt (shmaddr);
- 	  shmdt (shmaddr);
--	  exit (0);
-+	  return 0;
- 	}
- 
- _ACEOF
diff --git a/srcpkgs/gimp/patches/install-gimpchoice-h.patch b/srcpkgs/gimp/patches/install-gimpchoice-h.patch
new file mode 100644
index 00000000000000..533b14d397f814
--- /dev/null
+++ b/srcpkgs/gimp/patches/install-gimpchoice-h.patch
@@ -0,0 +1,25 @@
+From 11892f1d83ffc465346dab7e2e8c6e790f555a64 Mon Sep 17 00:00:00 2001
+From: Jehan <jehan@girinstud.io>
+Date: Wed, 21 Feb 2024 11:08:23 +0100
+Subject: [PATCH] Issue #10900: install missing gimpchoice.h.
+
+Argh how this could pass without anyone noticing?!
+---
+ libgimpbase/meson.build | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libgimpbase/meson.build b/libgimpbase/meson.build
+index a77d125f39d..a2c27016b10 100644
+--- a/libgimpbase/meson.build
++++ b/libgimpbase/meson.build
+@@ -84,6 +84,7 @@ libgimpbase_headers_introspectable = files(
+   'gimpbaseenums.h',
+   'gimpbasetypes.h',
+   'gimpchecks.h',
++  'gimpchoice.h',
+   'gimpcpuaccel.h',
+   'gimpenv.h',
+   'gimplimits.h',
+-- 
+GitLab
+
diff --git a/srcpkgs/gimp/template b/srcpkgs/gimp/template
index 265f1c8e76a3ec..45b0e47cdad3be 100644
--- a/srcpkgs/gimp/template
+++ b/srcpkgs/gimp/template
@@ -1,34 +1,40 @@
 # Template file for 'gimp'
 pkgname=gimp
-version=2.10.36
-revision=2
-build_style=gnu-configure
-configure_args="--disable-check-update --datadir=/usr/share --disable-python"
-hostmakedepends="automake gegl gettext-devel glib-devel gtk+-devel intltool
- libtool pkg-config perl-XML-Parser gtk-doc iso-codes"
-makedepends="aalib-devel alsa-lib-devel babl-devel dbus-glib-devel gegl-devel
- ghostscript-devel jasper-devel lcms2-devel libXcursor-devel libXpm-devel
- libgexiv2-devel libgudev-devel libmng-devel libmypaint-devel
- libopenexr-devel librsvg-devel libwmf-devel mypaint-brushes1
- poppler-glib-devel glib-networking libwebp-devel
- libheif-devel libopenjpeg2-devel x265-devel gtk+-devel"
-depends="desktop-file-utils hicolor-icon-theme iso-codes mypaint-brushes1"
+version=2.99.18
+revision=1
+build_style=meson
+build_helper="gir"
+configure_args="-Dcheck-update=no -Drevision=$revision -Denable-default-bin=enabled
+ $(vopt_bool gir g-ir-doc) $(vopt_bool gir can-crosscompile-gir)
+ -Dbug-report-url=https://github.com/void-linux/void-packages/issues/new/choose"
+hostmakedepends="pkg-config xdg-utils perl libxslt gjs LuaJIT desktop-file-utils
+ AppStream gi-docgen gettext gobject-introspection yelp-tools"
+makedepends="babl-devel gtk+3-devel gegl-devel libgexiv2-devel libgirepository-devel
+ libmypaint-devel mypaint-brushes1 librsvg-devel glib-networking appstream-glib-devel
+ libXmu-devel ghostscript-devel libmng-devel aalib-devel libXpm-devel libopenexr-devel
+ libwebp-devel libheif-devel poppler-glib-devel libwmf-devel libopenjpeg2-devel
+ libjxl-devel alsa-lib-devel cfitsio-devel python3-gobject-devel libgomp-devel
+ libunwind-devel lua51-lgi"
+depends="desktop-file-utils hicolor-icon-theme iso-codes mypaint-brushes1 python3-gobject"
+checkdepends="xvfb-run dbus"
 short_desc="GNU image manipulation program"
-conf_files="/etc/gimp/${version%%.*}.0/*"
+#conf_files="/etc/gimp/${version%%.*}.0/*"
+conf_files="/etc/gimp/${version%.*}/*"
 maintainer="fosslinux <fosslinux@aussies.space>"
 license="GPL-3.0-only"
 homepage="https://www.gimp.org"
-changelog="https://gitlab.gnome.org/GNOME/gimp/-/raw/gimp-2-10/NEWS"
-distfiles="https://download.gimp.org/pub/gimp/v${version%.*}/gimp-${version}.tar.bz2"
-checksum=3d3bc3c69a4bdb3aea9ba2d5385ed98ea03953f3857aafd1d6976011ed7cdbb2
+distfiles="https://download.gimp.org/gimp/v${version%.*}/gimp-${version}.tar.xz"
+checksum=8c1bb7a94ac0d4d0cde4d701d8b356387c2ecd87abbd35bbf7d222d40f6ddb6e
 lib32disabled=yes
-no_generic_pkgconfig_link=yes
 
-pre_configure() {
-	NOCONFIGURE=1 autoreconf -fi
-	# don't allow configure to set DATADIRNAME=lib
-	vsed -i 's/DATADIRNAME=lib/DATADIRNAME=share/' configure
-}
+build_options="gir"
+build_options_default="gir"
+
+if [ -n "$XBPS_CHECK_PKGS" ]; then
+	configure_args+=" -Dheadless-tests=enabled"
+else
+	configure_args+=" -Dheadless-tests=disabled"
+fi
 
 libgimp_package() {
 	short_desc+=" - runtime libraries"
@@ -38,13 +44,16 @@ libgimp_package() {
 }
 
 gimp-devel_package() {
-	depends="gegl-devel gtk+-devel lcms2-devel libgimp>=${version}_${revision}"
+	depends="libgimp>=${version}_${revision} gegl-devel gtk+3-devel libgexiv2-devel"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include
 		vmove usr/lib/pkgconfig
-		vmove usr/share/gtk-doc
-		vmove usr/share/aclocal
+		vmove usr/share/doc
 		vmove "usr/lib/*.so"
+		if [ "$build_option_gir" ]; then
+			vmove usr/share/gir-1.0
+			vmove usr/share/vala
+		fi
 	}
 }

From b9dc2c9bd54954376b4d0906753bb11a3c6a0a32 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:09 -0400
Subject: [PATCH 4/8] gmic: rebuild for gimp 3

---
 srcpkgs/gmic/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gmic/template b/srcpkgs/gmic/template
index fa37651bb6deea..24d10147e3abad 100644
--- a/srcpkgs/gmic/template
+++ b/srcpkgs/gmic/template
@@ -1,7 +1,7 @@
 # Template file for 'gmic'
 pkgname=gmic
 version=3.1.6
-revision=5
+revision=6
 _zart_hash=34ebf6cce0bafb98abe57cec83c4a02cd1abeca0
 create_wrksrc=yes
 build_wrksrc="src"

From cd08e805ad039870203e61d5531b6b0a4d0d281e Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:10 -0400
Subject: [PATCH 5/8] nufraw: rebuild for gimp 3

---
 srcpkgs/nufraw/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/nufraw/template b/srcpkgs/nufraw/template
index 551f263df96d38..86a4d73adb797f 100644
--- a/srcpkgs/nufraw/template
+++ b/srcpkgs/nufraw/template
@@ -1,7 +1,7 @@
 # Template file for 'nufraw'
 pkgname=nufraw
 version=0.43.3
-revision=1
+revision=2
 _ver="${version%.*}-${version##*.}"
 build_style=gnu-configure
 configure_args="--enable-contrast --enable-mime --enable-openmp --with-gimp

From 11727e39fa51d8ac2d6127c22f1275dfe9f85c31 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:11 -0400
Subject: [PATCH 6/8] xsane: rebuild for gimp 3

---
 srcpkgs/xsane/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xsane/template b/srcpkgs/xsane/template
index 7dde32af2b674c..0f69c0f65fe6b8 100644
--- a/srcpkgs/xsane/template
+++ b/srcpkgs/xsane/template
@@ -1,7 +1,7 @@
 # Template file for 'xsane'
 pkgname=xsane
 version=0.999
-revision=5
+revision=6
 hostmakedepends="pkg-config sane-devel gettext"
 makedepends="gtk+-devel lcms-devel sane-devel gimp-devel"
 depends="sane"

From 804edfc40e86a6539bef08e8b94c37091e2c4f99 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 02:44:11 -0400
Subject: [PATCH 7/8] gimp-lqr-plugin: rebuild for gimp 3

---
 srcpkgs/gimp-lqr-plugin/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gimp-lqr-plugin/template b/srcpkgs/gimp-lqr-plugin/template
index 7878f6cb795d24..9a516b3798b0e0 100644
--- a/srcpkgs/gimp-lqr-plugin/template
+++ b/srcpkgs/gimp-lqr-plugin/template
@@ -1,7 +1,7 @@
 # Template file for 'gimp-lqr-plugin'
 pkgname=gimp-lqr-plugin
 version=0.7.2
-revision=2
+revision=3
 build_style=gnu-configure
 hostmakedepends="automake intltool pkg-config"
 makedepends="gimp-devel glib-devel gettext-devel liblqr-devel"

From 1fda55ba20635d3bbb641c7dcdba6b3cae7a05fb Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 18 Apr 2024 03:22:14 -0400
Subject: [PATCH 8/8] resynthesizer: update to 2.0.3+2.

WIP gimp 3 port
---
 srcpkgs/resynthesizer/template | 26 +++++++-------------------
 1 file changed, 7 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/resynthesizer/template b/srcpkgs/resynthesizer/template
index a58b0eec995854..68be9e18dd0ffe 100644
--- a/srcpkgs/resynthesizer/template
+++ b/srcpkgs/resynthesizer/template
@@ -1,26 +1,14 @@
 # Template file for 'resynthesizer'
 pkgname=resynthesizer
-version=2.0.3+1
+version=2.0.3+2
 revision=1
-_commit=701e890d1d456e215e05daa7b4a88f5d9c6c03b3
-build_style=gnu-configure
-hostmakedepends="automake intltool pkg-config"
+_commit=dee67110c51cbc69c28435ac7485766c3eb30a94
+build_style=meson
+hostmakedepends="pkg-config"
 makedepends="gimp-devel glib-devel gettext-devel"
 short_desc="Suite of gimp plugins for texture healing and synthesis"
 maintainer="CoolOhm <micvlas@gmail.com>"
 license="GPL-2.0-or-later"
-# FIXME: when gimp 3 is available, switch back to bootchk upstream
-#homepage="https://github.com/bootchk/resynthesizer"
-#distfiles="https://github.com/bootchk/resynthesizer/archive/refs/tags/v${version}.tar.gz"
-homepage="https://github.com/itr-tert/gimp-resynthesizer-scm"
-distfiles="https://github.com/itr-tert/gimp-resynthesizer-scm/archive/${_commit}.tar.gz"
-checksum=298286386466fbd6d2da06f8a920c6e6e313db7ca0a094a36a355978a64cefc0
-
-if [ "$CROSS_BUILD" ];then
-	hostmakedepends+=" glib-devel gettext-devel"
-	AUTOGEN_CONFIGURE_ARGS+=" --host=${XBPS_MACHINE%-musl} --build=${XBPS_CROSS_TRIPLET}"
-fi
-
-pre_configure() {
-	./autogen.sh ${AUTOGEN_CONFIGURE_ARGS}
-}
+homepage="https://github.com/bootchk/resynthesizer"
+distfiles="https://github.com/bootchk/resynthesizer/archive/${_commit}.tar.gz"
+checksum=a9ae689f5c10e284b0b8cab03baa05caab029fae2250bcdcc7e1d3ec6f8c367d

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-21 20:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-18  7:24 [PR PATCH] GIMP 3 classabbyamp
2024-04-18  7:26 ` [PR REVIEW] " classabbyamp
2024-04-18  7:26 ` classabbyamp
2024-04-21 20:02 ` [PR PATCH] [Updated] " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).