Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/build-helper/meson.sh: Fix deprecation warn
@ 2024-05-07 13:37 meator
  2024-05-07 19:18 ` [PR PATCH] [Merged]: " ahesford
  0 siblings, 1 reply; 2+ messages in thread
From: meator @ 2024-05-07 13:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages fix-meson-warning
https://github.com/void-linux/void-packages/pull/50229

common/build-helper/meson.sh: Fix deprecation warn
When you try to build anything using the `meson` build style, this will appear as the first line of output in the `do_configure` step:

```
DEPRECATION: "pkgconfig" entry is deprecated and should be replaced by "pkg-config"
```

This PR follows the warning's advice and replaces `pkgconfig` with `pkg-config`. I have tested building a meson package using both `meson-1.3.2_1` and using `meson-1.4.0_1` from #49288

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50229.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-meson-warning-50229.patch --]
[-- Type: text/x-diff, Size: 1042 bytes --]

From fa7cc7e3471509460f5cdf968b99deeef2b60665 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Tue, 7 May 2024 15:26:40 +0200
Subject: [PATCH] common/build-helper/meson.sh: Fix deprecation warn

This commit removes the following deprecation notice:
DEPRECATION: "pkgconfig" entry is deprecated and should be replaced by
"pkg-config"
---
 common/build-helper/meson.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/build-helper/meson.sh b/common/build-helper/meson.sh
index 6232f9260c2e94..e414afbfba4bb3 100644
--- a/common/build-helper/meson.sh
+++ b/common/build-helper/meson.sh
@@ -64,7 +64,7 @@ cat > "${XBPS_WRAPPERDIR}/meson/xbps_meson.cross" <<-EOF
 	strip = '${STRIP}'
 	readelf = '${READELF}'
 	objcopy = '${OBJCOPY}'
-	pkgconfig = '${PKG_CONFIG}'
+	pkg-config = '${PKG_CONFIG}'
 	rust = ['rustc', '--target', '${RUST_TARGET}' ,'--sysroot', '${XBPS_CROSS_BASE}/usr']
 	g-ir-scanner = '${XBPS_CROSS_BASE}/usr/bin/g-ir-scanner'
 	g-ir-compiler = '${XBPS_CROSS_BASE}/usr/bin/g-ir-compiler'

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: common/build-helper/meson.sh: Fix deprecation warn
  2024-05-07 13:37 [PR PATCH] common/build-helper/meson.sh: Fix deprecation warn meator
@ 2024-05-07 19:18 ` ahesford
  0 siblings, 0 replies; 2+ messages in thread
From: ahesford @ 2024-05-07 19:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]

There's a merged pull request on the void-packages repository

common/build-helper/meson.sh: Fix deprecation warn
https://github.com/void-linux/void-packages/pull/50229

Description:
When you try to build anything using the `meson` build style, this will appear as the first line of output in the `do_configure` step:

```
DEPRECATION: "pkgconfig" entry is deprecated and should be replaced by "pkg-config"
```

This PR follows the warning's advice and replaces `pkgconfig` with `pkg-config`. I have tested building a meson package using both `meson-1.3.2_1` and using `meson-1.4.0_1` from #49288

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-07 19:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-07 13:37 [PR PATCH] common/build-helper/meson.sh: Fix deprecation warn meator
2024-05-07 19:18 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).