* pianobar fails to build without a build function
@ 2015-02-02 9:45 Justin moore
2015-02-02 12:47 ` Stefan Mühlinghaus
0 siblings, 1 reply; 5+ messages in thread
From: Justin moore @ 2015-02-02 9:45 UTC (permalink / raw)
To: voidlinux
[-- Attachment #1.1: Type: text/plain, Size: 446 bytes --]
I type 'make' and pianobar builds fine, however using a template and using
the build style gnu-makefile, the build fails. I looked at
/common/build_style/gnu-makefile.sh and everything looks fine. With the
arguments the style has, pianobar should be building fine (unless I am
missing something). If anyone would be willing to help me out and read over
my template file, that would be awesome
http://pastebin.com/4E3kkfi1
Thanks
[-- Attachment #1.2: Type: text/html, Size: 467 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pianobar fails to build without a build function
2015-02-02 9:45 pianobar fails to build without a build function Justin moore
@ 2015-02-02 12:47 ` Stefan Mühlinghaus
2015-02-02 23:50 ` Justin moore
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Mühlinghaus @ 2015-02-02 12:47 UTC (permalink / raw)
To: voidlinux
[-- Attachment #1.1: Type: text/plain, Size: 514 bytes --]
Several points I noticed:
1. The wrksrc-line is unneccessary, that is the default
2. The makedepends-line is not terminated correctly and it is missing
the "ffmpeg-devel" package
3. Build in the do_build() function, not in pre_build()
4. Usually, calling make yourself like this is unneccessary. It is done
automatically by setting the build_style to gnu-make. However, it won't
compile like this without a little help:
do_build() {
CFLAGS="-O2 -std=c99" make
}
[-- Attachment #1.2: Type: text/html, Size: 1351 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pianobar fails to build without a build function
2015-02-02 12:47 ` Stefan Mühlinghaus
@ 2015-02-02 23:50 ` Justin moore
2015-02-03 10:20 ` Juan RP
0 siblings, 1 reply; 5+ messages in thread
From: Justin moore @ 2015-02-02 23:50 UTC (permalink / raw)
To: voidlinux
[-- Attachment #1.1: Type: text/plain, Size: 917 bytes --]
I must have copied the wrong template. The correct one has ffmpeg-devel and
terminates makedepends properly. I've added a do_build function with the
cflags your specified, and removed the wrksrc directory. Everything is fine
now, thanks.
new template <http://pastebin.com/uvAi8uwT>
On Monday, February 2, 2015 at 6:47:21 AM UTC-6, Stefan Mühlinghaus wrote:
>
> Several points I noticed:
>
> 1. The wrksrc-line is unneccessary, that is the default
> 2. The makedepends-line is not terminated correctly and it is missing
> the "ffmpeg-devel" package
> 3. Build in the do_build() function, not in pre_build()
> 4. Usually, calling make yourself like this is unneccessary. It is
> done automatically by setting the build_style to gnu-make. However, it
> won't compile like this without a little help:
>
>
> do_build() {
> CFLAGS="-O2 -std=c99" make
> }
>
[-- Attachment #1.2: Type: text/html, Size: 1550 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pianobar fails to build without a build function
2015-02-02 23:50 ` Justin moore
@ 2015-02-03 10:20 ` Juan RP
2015-02-04 7:45 ` Justin moore
0 siblings, 1 reply; 5+ messages in thread
From: Juan RP @ 2015-02-03 10:20 UTC (permalink / raw)
To: voidlinux
[-- Attachment #1.1: Type: text/plain, Size: 127 bytes --]
I've pushed your package with the required changes to build it properly.
See the commit to see what you were missing :-)
[-- Attachment #1.2: Type: text/html, Size: 156 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pianobar fails to build without a build function
2015-02-03 10:20 ` Juan RP
@ 2015-02-04 7:45 ` Justin moore
0 siblings, 0 replies; 5+ messages in thread
From: Justin moore @ 2015-02-04 7:45 UTC (permalink / raw)
To: voidlinux
[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]
I really appreciate that you took care of that for me. I was banging my
head against the wall for days over it (figuratively speaking of course).
My question is, are the vars on line 15 typical when there is no build
style, or are all of those tailored to pianobar? I'd like to learn more
about specifics for future templates. being a package maintainer is very
new to me and I'd like to get good enough to submit templates and get the
right the first time.
Thanks again, cheers!
On Tuesday, February 3, 2015 at 4:20:22 AM UTC-6, Juan RP wrote:
>
>
> I've pushed your package with the required changes to build it properly.
>
> See the commit to see what you were missing :-)
>
[-- Attachment #1.2: Type: text/html, Size: 864 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-04 7:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-02 9:45 pianobar fails to build without a build function Justin moore
2015-02-02 12:47 ` Stefan Mühlinghaus
2015-02-02 23:50 ` Justin moore
2015-02-03 10:20 ` Juan RP
2015-02-04 7:45 ` Justin moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).