From: Andrej Kacian <andrej@kacian.sk>
To: wireguard@lists.zx2c4.com
Subject: Re: making wireguard work on RHEL7/etc.
Date: Tue, 27 Jun 2017 07:35:21 +0200 [thread overview]
Message-ID: <20170627073521.22a725fc@penny> (raw)
In-Reply-To: <CAHmME9oHG6a1==KzrrfuvmkKoVJHhTtToP00qYtcKXEGDCnm8Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Mon, 26 Jun 2017 11:57:56 +0200
"Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
> Excellent!
>
> Indeed let's roll with that. Perhaps something quite specific, though, like:
>
> #if RHEL_RELEASE_CODE <= RHEL_RELEASE_VERSION(7,3)
>
> If you want to reroll your patches around this, in a really clean way,
> and submit them using git-send-email to the list, I can do a proper
> review and we can get this merged.
I wonder - is it a good idea to depend on
nonstandard, distribution-specific defines like this? This kind of
modification IMHO belongs in a local patch applied during a rpmbuild
for a RHEL/Centos package.
I know it might sound like crying wolf now, but this is exactly how
embrace-extend-extinguish happens.
Regards,
--
Andrej
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-27 5:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 15:18 wireguard
2017-06-26 8:07 ` Aaron Muir Hamilton
2017-06-26 8:19 ` wireguard
2017-06-26 9:04 ` Jason A. Donenfeld
2017-06-26 9:25 ` wireguard
2017-06-26 9:57 ` Jason A. Donenfeld
2017-06-26 10:47 ` Jason A. Donenfeld
2017-06-26 19:55 ` wireguard
2017-06-27 11:02 ` Jason A. Donenfeld
2017-06-26 20:45 ` wireguard
2017-06-27 11:05 ` Jason A. Donenfeld
2017-06-27 11:38 ` wireguard
2017-06-27 19:23 ` Jason A. Donenfeld
2017-06-27 19:43 ` wireguard
2017-06-27 19:59 ` Jason A. Donenfeld
2017-06-27 20:22 ` Jason A. Donenfeld
2017-06-27 20:52 ` Jason A. Donenfeld
2017-06-27 21:30 ` wireguard
2017-06-27 22:09 ` Jason A. Donenfeld
2017-06-27 5:35 ` Andrej Kacian [this message]
2017-06-27 7:25 ` wireguard
2017-06-27 9:39 ` Andrej Kacian
2017-06-27 11:08 ` Jason A. Donenfeld
2018-04-05 15:08 ` Daniel Kahn Gillmor
2018-04-05 16:15 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627073521.22a725fc@penny \
--to=andrej@kacian.sk \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).