Development discussion of WireGuard
 help / color / mirror / Atom feed
* [PATCH v4 65/66] selftests/wireguard: Drop define _GNU_SOURCE
       [not found] <20240510000842.410729-1-edliaw@google.com>
@ 2024-05-10  0:07 ` Edward Liaw
  2024-05-17 14:48   ` Jason A. Donenfeld
  0 siblings, 1 reply; 2+ messages in thread
From: Edward Liaw @ 2024-05-10  0:07 UTC (permalink / raw)
  To: shuah, Mickaël Salaün, Günther Noack,
	Christian Brauner, Richard Cochran, Paul Walmsley,
	Palmer Dabbelt, Albert Ou, Alexei Starovoitov, Daniel Borkmann,
	David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer,
	John Fastabend, Jason A. Donenfeld
  Cc: linux-kernel, linux-kselftest, kernel-team, Edward Liaw,
	linux-security-module, netdev, linux-riscv, bpf, wireguard

_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.

Signed-off-by: Edward Liaw <edliaw@google.com>
---
 tools/testing/selftests/wireguard/qemu/init.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/wireguard/qemu/init.c b/tools/testing/selftests/wireguard/qemu/init.c
index 3e49924dd77e..08113f3c6189 100644
--- a/tools/testing/selftests/wireguard/qemu/init.c
+++ b/tools/testing/selftests/wireguard/qemu/init.c
@@ -2,8 +2,6 @@
 /*
  * Copyright (C) 2015-2019 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
  */
-
-#define _GNU_SOURCE
 #include <unistd.h>
 #include <errno.h>
 #include <string.h>
-- 
2.45.0.118.g7fe29c98d7-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v4 65/66] selftests/wireguard: Drop define _GNU_SOURCE
  2024-05-10  0:07 ` [PATCH v4 65/66] selftests/wireguard: Drop define _GNU_SOURCE Edward Liaw
@ 2024-05-17 14:48   ` Jason A. Donenfeld
  0 siblings, 0 replies; 2+ messages in thread
From: Jason A. Donenfeld @ 2024-05-17 14:48 UTC (permalink / raw)
  To: Edward Liaw
  Cc: shuah, Mickaël Salaün, Günther Noack,
	Christian Brauner, Richard Cochran, Paul Walmsley,
	Palmer Dabbelt, Albert Ou, Alexei Starovoitov, Daniel Borkmann,
	David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer,
	John Fastabend, linux-kernel, linux-kselftest, kernel-team,
	linux-security-module, netdev, linux-riscv, bpf, wireguard

On Fri, May 10, 2024 at 12:07:22AM +0000, Edward Liaw wrote:
> _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> redefinition warnings.
> 
> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
>  tools/testing/selftests/wireguard/qemu/init.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/wireguard/qemu/init.c b/tools/testing/selftests/wireguard/qemu/init.c
> index 3e49924dd77e..08113f3c6189 100644
> --- a/tools/testing/selftests/wireguard/qemu/init.c
> +++ b/tools/testing/selftests/wireguard/qemu/init.c
> @@ -2,8 +2,6 @@
>  /*
>   * Copyright (C) 2015-2019 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
>   */
> -
> -#define _GNU_SOURCE
>  #include <unistd.h>
>  #include <errno.h>
>  #include <string.h>
> -- 

But this file doesn't use lib.mk.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-17 14:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20240510000842.410729-1-edliaw@google.com>
2024-05-10  0:07 ` [PATCH v4 65/66] selftests/wireguard: Drop define _GNU_SOURCE Edward Liaw
2024-05-17 14:48   ` Jason A. Donenfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).