Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <>
To: "Jason A. Donenfeld" <>
Cc: Netdev <>,
	Daniel Borkmann <>,
	Martynas Pumputis <>,
	WireGuard mailing list <>,
	Jakub Kicinski <>,
	David Miller <>
Subject: Re: [PATCH net 2/2] wireguard: selftests: add metadata_dst xmit selftest
Date: Thu, 14 Apr 2022 15:12:39 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 14/04/2022 15:06, Jason A. Donenfeld wrote:
> Hi Nikolay,
> These tests need to run in the minimal fast-to-compile test harness
> inside of tools/testing/selftests/wireguard/qemu, which you can try
> out with:
> $ make -C tools/testing/selftests/wireguard/qemu -j$(nproc)
> Currently iproute2 is built, but only ip(8) is used in the image, so
> you'll need to add tc(8) to there. Clang, however, seems a bit
> heavyweight. I suspect it'd make more sense to just base64 up that
> object file and include it as a string in the file? Or, alternatively,
> we could just not move ahead with this rather niche test, and revisit
> the issue if we wind up wanting to test for lots of bpf things.
> Thoughts on that?
> Jason

Hi Jason,
My bad, I completely missed the qemu part. I'll look into including the
ready object file. If it works out, looks compact and well
I'll post v2.


  reply	other threads:[~2022-04-22  0:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 10:44 [PATCH net 0/2] wireguard: device: fix metadata_dst xmit null pointer dereference Nikolay Aleksandrov
2022-04-14 10:44 ` [PATCH net 1/2] " Nikolay Aleksandrov
2022-04-14 11:28   ` Daniel Borkmann
2022-04-14 11:58   ` Jason A. Donenfeld
2022-04-14 10:44 ` [PATCH net 2/2] wireguard: selftests: add metadata_dst xmit selftest Nikolay Aleksandrov
2022-04-14 12:06   ` Jason A. Donenfeld
2022-04-14 12:12     ` Nikolay Aleksandrov [this message]
2022-04-14 12:24       ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).