Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Simon Rozman <simon@rozman.si>
To: Eiji Tanioka <tanioka404@gmail.com>,
	"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH wireguard-windows] l18n: change EnumerationSeparator for Japanese.
Date: Thu, 27 Feb 2020 11:47:20 +0000	[thread overview]
Message-ID: <3494258D-7F14-4890-B3A4-8CED4EA24D05@rozman.si> (raw)
In-Reply-To: <20200227094326.9597-1-tanioka404@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1811 bytes --]

Arigato!

Rebuilt the zgotext.go file, amended to your commit, and applied to sr/l18n patch.

Regards, Simon

-----Original Message-----
From: WireGuard <wireguard-bounces@lists.zx2c4.com> on behalf of Eiji Tanioka <tanioka404@gmail.com>
Date: Thursday, 27 February 2020 at 10:43
To: "wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: [PATCH wireguard-windows] l18n: change EnumerationSeparator for Japanese.

    I grepped source tree and found that 'EnumerationSeparator' is used
    for multiple IP addresses separation. In these situation, comma is
    better than "、" in Japanese.
    ("、" is used for Japanese sentence separator, but separation by comma
    is more preferable to enumerate ASCII values.)
    
    Signed-off-by: Eiji Tanioka <tanioka404@gmail.com>
    ---
     locales/ja/messages.gotext.json | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)
    
    diff --git a/locales/ja/messages.gotext.json b/locales/ja/messages.gotext.json
    index 3501458..723cb6c 100644
    --- a/locales/ja/messages.gotext.json
    +++ b/locales/ja/messages.gotext.json
    @@ -455,7 +455,7 @@
             {
                 "id": "[EnumerationSeparator]",
                 "message": "[EnumerationSeparator]",
    -            "translation": "、",
    +            "translation": ", ",
                 "comment": "Inserted between items when listing (e.g. ‘, ’ or ‘、’)"
             },
             {
    @@ -1494,4 +1494,4 @@
                 ]
             }
         ]
    -}
    \ No newline at end of file
    +}
    -- 
    2.25.0
    
    _______________________________________________
    WireGuard mailing list
    WireGuard@lists.zx2c4.com
    https://lists.zx2c4.com/mailman/listinfo/wireguard
    

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2965 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

      reply	other threads:[~2020-02-27 11:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27  9:43 Eiji Tanioka
2020-02-27 11:47 ` Simon Rozman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3494258D-7F14-4890-B3A4-8CED4EA24D05@rozman.si \
    --to=simon@rozman.si \
    --cc=tanioka404@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).