Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "PaX Team" <pageexec@freemail.hu>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: imer_setup() is not compatible with PaX's RAP
Date: Tue, 28 Nov 2017 13:32:01 +0100	[thread overview]
Message-ID: <5A1D5741.21951.47BB55BB@pageexec.freemail.hu> (raw)
In-Reply-To: <CAHmME9oL=p3snOEWevyqHYSy3yjdpDrtyQYViT__9BxJYU=1cw@mail.gmail.com>

On 28 Nov 2017 at 13:20, Jason A. Donenfeld wrote:

> Hey Pipacs,
> 
> A user on IRC found another issue. This time it looks like it might be
> a RAP bug, though. Below is the error output. So far as I can see, the
> function pointer type and the function declaration match fine.
> However, the function itself is implemented in assembly, which means
> it can't itself be instrumented by RAP. What to do?

targets of indirect calls must be marked by the RAP hash which the plugin
will do for code it sees but for asm you'll have to do it yourself, look at
the use of RAP_ENTRY to see how that works.

  reply	other threads:[~2017-11-28 12:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-11  8:09 Tom Li
2017-11-11  8:16 ` Tom Li
2017-11-12  2:50 ` Jason A. Donenfeld
2017-11-12  3:13   ` Jason A. Donenfeld
2017-11-13  1:39   ` PaX Team
2017-11-13 19:34     ` Jason A. Donenfeld
2017-11-14  0:15       ` PaX Team
2017-11-14  9:29         ` Jason A. Donenfeld
2017-11-14 10:29           ` Jason A. Donenfeld
2017-11-14 11:12           ` PaX Team
2017-11-28 12:20             ` Jason A. Donenfeld
2017-11-28 12:32               ` PaX Team [this message]
2017-11-28 12:36                 ` Jason A. Donenfeld
2017-11-28 12:50                   ` PaX Team

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A1D5741.21951.47BB55BB@pageexec.freemail.hu \
    --to=pageexec@freemail.hu \
    --cc=Jason@zx2c4.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).