Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Yuanchao Sun <yuanchaosun@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Yuanchao Sun <yuanchaosun@gmail.com>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH 1/1] tools: remove '\n' in fscanf format-string
Date: Tue, 28 Nov 2017 22:53:54 +0800	[thread overview]
Message-ID: <739926D8-0CAD-48C9-9BCF-6CA91986E715@gmail.com> (raw)
In-Reply-To: <CAHmME9pUk6pdp5VtGKaebAB70mcz+D_nW8E1vCRhm-jQzm6Bjw@mail.gmail.com>

Hi Jason,

> Thanks for the patch. In the future, please include your Signed-off-by
> line and include the explanation in the body of the commit where it
> will be recorded in the future.

Sure. This is my first time using git send-email ... I just followed the =
steps
from a quick guide. I will figure out how to add the Signed-off-by line
the next time.

>=20
> I'm not sure this patch is correct. The /xplatform spec mandates an
> empty line. This patch enforces that. What is the purpose of removing
> that requirement?
>=20
> Also, I'm curious to learn what you're doing with this API at this =
early stage.

I'm trying to implement a userspace client using rust (does not work =
properly
for now ;/ ).

But I found fscanf does not return after reading a complete response =
(b"errno=3D0\n\n").
After searching, it seems '\n' in format string does not mean newline =
but any whitespaces.
fscanf hangs until a extra non-whitespace character.
So I fix this problem by removing the trailing '\n's in format string.

Yuanchao

      reply	other threads:[~2017-11-28 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28  7:49 [PATCH 0/1] " Yuanchao Sun
2017-11-28  7:49 ` [PATCH 1/1] tools: " Yuanchao Sun
2017-11-28 11:03   ` Jason A. Donenfeld
2017-11-28 14:53     ` Yuanchao Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=739926D8-0CAD-48C9-9BCF-6CA91986E715@gmail.com \
    --to=yuanchaosun@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).