Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Yuanchao Sun <yuanchaosun@gmail.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH 1/1] tools: remove '\n' in fscanf format-string
Date: Tue, 28 Nov 2017 12:03:49 +0100	[thread overview]
Message-ID: <CAHmME9pUk6pdp5VtGKaebAB70mcz+D_nW8E1vCRhm-jQzm6Bjw@mail.gmail.com> (raw)
In-Reply-To: <20171128074947.2212-2-yuanchao.sun@gmail.com>

Hello,

Thanks for the patch. In the future, please include your Signed-off-by
line and include the explanation in the body of the commit where it
will be recorded in the future.

I'm not sure this patch is correct. The /xplatform spec mandates an
empty line. This patch enforces that. What is the purpose of removing
that requirement?

Also, I'm curious to learn what you're doing with this API at this early stage.

Regards,
Jason

  reply	other threads:[~2017-11-28 10:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28  7:49 [PATCH 0/1] " Yuanchao Sun
2017-11-28  7:49 ` [PATCH 1/1] tools: " Yuanchao Sun
2017-11-28 11:03   ` Jason A. Donenfeld [this message]
2017-11-28 14:53     ` Yuanchao Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9pUk6pdp5VtGKaebAB70mcz+D_nW8E1vCRhm-jQzm6Bjw@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=wireguard@lists.zx2c4.com \
    --cc=yuanchaosun@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).