macOS update logic needs improving

macOS update logic needs improving

[Laura Smith]

Thank you for the recent efforts to bring macOS/iOS up to date.

However there is a little bit of a problem with the logic for your macOS App Store updates.

The update downloads fine, and *appears* to install, but the App Store app continues to show the update as available and installed.

Further investigation shows that if Wireguard is running and/or open, the app will not actually be updated (App Store will roll back to the existing version).

If Wireguard is quit, then the update will install OK.

So you probably need to add some logic somewhere to detect and deal with open/running Wireguard (e.g. prompt user to exit).

Re: macOS update logic needs improving

[Jason A. Donenfeld]

Hi Laura,

Thanks for letting me know. I was under the impression that we were
handling this case
https://git.zx2c4.com/wireguard-apple/tree/Sources/WireGuardApp/UI/macOS/MacAppStoreUpdateDetector.swift
but maybe things broke in Big Sur.

Were you able to eventually unlodge it and update, or did it remain stuck?

Jason

Re: macOS update logic needs improving

[Alexander Burke]

This is also the case on iOS for the same reason: because an app cannot be updated while it’s running, and while at least one tunnel is up the OS will not terminate the app.


> On 17 Dec 2020, at 05:25, Laura Smith <n5d9xq3ti233xiyif2vp@protonmail.ch> wrote:
> 
> Thank you for the recent efforts to bring macOS/iOS up to date.
> 
> However there is a little bit of a problem with the logic for your macOS App Store updates.
> 
> The update downloads fine, and *appears* to install, but the App Store app continues to show the update as available and installed.
> 
> Further investigation shows that if Wireguard is running and/or open, the app will not actually be updated (App Store will roll back to the existing version).
> 
> If Wireguard is quit, then the update will install OK.
> 
> So you probably need to add some logic somewhere to detect and deal with open/running Wireguard (e.g. prompt user to exit).

Re: macOS update logic needs improving

[Alexander Burke]

Awfully gauche to reply to myself, but here we are.

This is the case on iOS at least in the event of an active Connect-on-Demand tunnel; the update sits and spins in the App Store until a few seconds after Connect-on-Demand is disabled, at which time the update proceeds and Connect-on-Demand can be re-enabled.


> On 17 Dec 2020, at 5:34, Alexander Burke <alex@alexburke.ca> wrote:
> 
> This is also the case on iOS for the same reason: because an app cannot be updated while it’s running, and while at least one tunnel is up the OS will not terminate the app.
> 
> 
>> On 17 Dec 2020, at 05:25, Laura Smith <n5d9xq3ti233xiyif2vp@protonmail.ch> wrote:
>> 
>> Thank you for the recent efforts to bring macOS/iOS up to date.
>> 
>> However there is a little bit of a problem with the logic for your macOS App Store updates.
>> 
>> The update downloads fine, and *appears* to install, but the App Store app continues to show the update as available and installed.
>> 
>> Further investigation shows that if Wireguard is running and/or open, the app will not actually be updated (App Store will roll back to the existing version).
>> 
>> If Wireguard is quit, then the update will install OK.
>> 
>> So you probably need to add some logic somewhere to detect and deal with open/running Wireguard (e.g. prompt user to exit).
> 

Re: macOS update logic needs improving

[Laura Smith]

Yes all good.  Killed the tunnel and quit Wireguard and I'm now writing you this from the shiny new version. ;-)


‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, 17 December 2020 10:33, Jason A. Donenfeld <Jason@zx2c4.com> wrote:

> Hi Laura,
>
> Thanks for letting me know. I was under the impression that we were
> handling this case
> https://git.zx2c4.com/wireguard-apple/tree/Sources/WireGuardApp/UI/macOS/MacAppStoreUpdateDetector.swift
> but maybe things broke in Big Sur.
>
> Were you able to eventually unlodge it and update, or did it remain stuck?
>
> Jason