Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Tore Anderson <tore@fud.no>
Cc: "Tomcsanyi, Domonkos" <domi@tomcsanyi.net>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] Adding support for reloading configuration via systemd
Date: Mon, 27 Jul 2020 17:51:37 +0200	[thread overview]
Message-ID: <CAHmME9p+tVyEm_+ALbsCWhshrt5yR97enjBcuUdVhTAWTf-MwA@mail.gmail.com> (raw)
In-Reply-To: <84986996953761e9d645b7ef583d3ffca689dfc5.camel@fud.no>

Hi Tore,

On Sat, Jul 25, 2020 at 2:16 PM Tore Anderson <tore@fud.no> wrote:
> I have no idea why my solution keeps being ignored (even after two
> gentle reminders), but perhaps third time's the charm?
>
> In any case, to quote myself from
> https://lists.zx2c4.com/pipermail/wireguard/2020-June/005585.html :
>
> «For what it is worth, I posted a patch that does exactly this back in
> March:
>
> https://lists.zx2c4.com/pipermail/wireguard/2020-March/005222.html
>
> Reviews or user tests would be greatly appreciated.
>
> You can also pull from https://github.com/toreanderson/wireguard-tools
> if you prefer. The commit in question is here:
>
> https://github.com/toreanderson/wireguard-tools/commit/8305a267ec4259206c0de7f1d3f9cfb8522a3223

But it doesn't sync Address=, DNS=, or any routing particulars. That
seems like a problem if it's to become a bona fide "reload" subcommand
of wg-quick, since it's not doing what it should be. On the other
hand, adding it to the systemd unit seems far enough away from core
code that we can kind of say, "eh, this sort of works," which might be
good enough. If even _that_ causes problems for users too, we'd have
to talk about removing it from the systemd unit. But hopefully it
stays under the radar and people don't have overly high expectations.

Jason

  reply	other threads:[~2020-07-27 15:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <VI1PR02MB52169D6F055314DCD03746EDE6760@VI1PR02MB5216.eurprd02.prod.outlook.com>
2020-07-23 14:10 ` Tomcsanyi, Domonkos
2020-07-24  9:14   ` Jason A. Donenfeld
2020-07-24  9:25     ` Garrit Franke
2020-07-24  9:27       ` Garrit Franke
2020-07-24  9:29       ` Jason A. Donenfeld
2020-07-24 13:09         ` Tomcsányi, Domonkos
2020-07-24 14:26           ` Jason A. Donenfeld
2020-07-24 14:46             ` Dominique Martinet
2020-07-24 14:49               ` Jason A. Donenfeld
2020-07-24  9:54       ` Matthias Urlichs
2020-07-24 10:52         ` Stefan Tatschner
2020-07-24 11:00           ` Matthias Urlichs
2020-07-25 12:16     ` Tore Anderson
2020-07-27 15:51       ` Jason A. Donenfeld [this message]
2020-07-27 20:04         ` Tore Anderson
2020-07-28  9:03           ` Jason A. Donenfeld
2020-07-28  9:54             ` Tore Anderson
2020-07-28 11:55               ` Jason A. Donenfeld
2020-07-28 12:17                 ` Tore Anderson
2020-07-28 12:17                   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9p+tVyEm_+ALbsCWhshrt5yR97enjBcuUdVhTAWTf-MwA@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=domi@tomcsanyi.net \
    --cc=tore@fud.no \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).