* [PATCH] fix: make wireguard compatible with android TV
@ 2020-01-22 19:41 Revath S Kumar
2020-01-22 19:44 ` Jason A. Donenfeld
0 siblings, 1 reply; 4+ messages in thread
From: Revath S Kumar @ 2020-01-22 19:41 UTC (permalink / raw)
To: Jason, wireguard; +Cc: Revath S Kumar
As of now wireguard is not listed in Android TV play store
due to the lack of CATEGORY_LEANBACK_LAUNCHER [1].
Even the app is not listed when we sideload into TV device[2].
[1]: https://developer.android.com/reference/android/content/Intent.html#CATEGORY_LEANBACK_LAUNCHER
[2]: https://developer.android.com/training/tv/start/start.html#tv-activity
---
app/src/main/AndroidManifest.xml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 21fc6eb..9bd2940 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -16,6 +16,8 @@
android:label="@string/permission_label"
android:protectionLevel="dangerous" />
+ <uses-feature android:name="android.hardware.touchscreen" android:required="false"/>
+
<application
android:name=".Application"
android:allowBackup="false"
@@ -31,6 +33,7 @@
<intent-filter>
<action android:name="android.intent.action.MAIN" />
<category android:name="android.intent.category.LAUNCHER" />
+ <category android:name="android.intent.category.LEANBACK_LAUNCHER" />
</intent-filter>
<intent-filter>
--
2.25.0
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix: make wireguard compatible with android TV
2020-01-22 19:41 [PATCH] fix: make wireguard compatible with android TV Revath S Kumar
@ 2020-01-22 19:44 ` Jason A. Donenfeld
2020-01-22 19:51 ` Derrick Lyndon Pallas
0 siblings, 1 reply; 4+ messages in thread
From: Jason A. Donenfeld @ 2020-01-22 19:44 UTC (permalink / raw)
To: Revath S Kumar; +Cc: WireGuard mailing list
Thanks for this.
On Wed, Jan 22, 2020 at 8:42 PM Revath S Kumar <rsk@revathskumar.com> wrote:
> + <uses-feature android:name="android.hardware.touchscreen" android:required="false"/>
I understand the other flag you've added, thanks to the documentation
link you provided, but what's this line here do?
Jason
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix: make wireguard compatible with android TV
2020-01-22 19:44 ` Jason A. Donenfeld
@ 2020-01-22 19:51 ` Derrick Lyndon Pallas
2020-01-22 19:55 ` Jason A. Donenfeld
0 siblings, 1 reply; 4+ messages in thread
From: Derrick Lyndon Pallas @ 2020-01-22 19:51 UTC (permalink / raw)
To: Jason A. Donenfeld, Revath S Kumar; +Cc: WireGuard mailing list
It allows it to work for hardware devices that emulate or simply do not
provide a real touchscreen, e.g. Android TVs. The feature requirement
for a real touchscreen is default enabled and must be explicitly
disabled. ~D
On 1/22/20 11:44 AM, Jason A. Donenfeld wrote:
> Thanks for this.
>
> On Wed, Jan 22, 2020 at 8:42 PM Revath S Kumar <rsk@revathskumar.com> wrote:
>> + <uses-feature android:name="android.hardware.touchscreen" android:required="false"/>
> I understand the other flag you've added, thanks to the documentation
> link you provided, but what's this line here do?
>
> Jason
> _______________________________________________
> WireGuard mailing list
> WireGuard@lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/wireguard
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix: make wireguard compatible with android TV
2020-01-22 19:51 ` Derrick Lyndon Pallas
@ 2020-01-22 19:55 ` Jason A. Donenfeld
0 siblings, 0 replies; 4+ messages in thread
From: Jason A. Donenfeld @ 2020-01-22 19:55 UTC (permalink / raw)
To: Derrick Lyndon Pallas; +Cc: Revath S Kumar, WireGuard mailing list
Interesting! Thanks for the explanation.
Alright, merging this patch.
Thanks Revath.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-22 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 19:41 [PATCH] fix: make wireguard compatible with android TV Revath S Kumar
2020-01-22 19:44 ` Jason A. Donenfeld
2020-01-22 19:51 ` Derrick Lyndon Pallas
2020-01-22 19:55 ` Jason A. Donenfeld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).