* Re: [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator [not found] <20240308112746.2290505-1-leitao@debian.org> @ 2024-03-11 9:22 ` Simon Horman [not found] ` <20240308112746.2290505-2-leitao@debian.org> 2024-03-14 3:23 ` [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator Jason A. Donenfeld 2 siblings, 0 replies; 5+ messages in thread From: Simon Horman @ 2024-03-11 9:22 UTC (permalink / raw) To: Breno Leitao Cc: Jason A. Donenfeld, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel, dsahern, open list:WIREGUARD SECURE NETWORK TUNNEL On Fri, Mar 08, 2024 at 03:27:44AM -0800, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of in this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the wireguard driver and leverage the network > core allocation instead. > > Signed-off-by: Breno Leitao <leitao@debian.org> Reviewed-by: Simon Horman <horms@kernel.org> ... ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20240308112746.2290505-2-leitao@debian.org>]
* Re: [PATCH net-next v2 2/2] wireguard: Remove generic .ndo_get_stats64 [not found] ` <20240308112746.2290505-2-leitao@debian.org> @ 2024-03-11 9:22 ` Simon Horman 0 siblings, 0 replies; 5+ messages in thread From: Simon Horman @ 2024-03-11 9:22 UTC (permalink / raw) To: Breno Leitao Cc: Jason A. Donenfeld, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel, dsahern, open list:WIREGUARD SECURE NETWORK TUNNEL On Fri, Mar 08, 2024 at 03:27:45AM -0800, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > Signed-off-by: Breno Leitao <leitao@debian.org> Reviewed-by: Simon Horman <horms@kernel.org> ... ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator [not found] <20240308112746.2290505-1-leitao@debian.org> 2024-03-11 9:22 ` [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator Simon Horman [not found] ` <20240308112746.2290505-2-leitao@debian.org> @ 2024-03-14 3:23 ` Jason A. Donenfeld 2024-03-14 3:27 ` Jason A. Donenfeld 2 siblings, 1 reply; 5+ messages in thread From: Jason A. Donenfeld @ 2024-03-14 3:23 UTC (permalink / raw) To: Breno Leitao Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel, horms, dsahern, open list:WIREGUARD SECURE NETWORK TUNNEL I applied this series to the wireguard tree. Thanks for the patches. Jason ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator 2024-03-14 3:23 ` [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator Jason A. Donenfeld @ 2024-03-14 3:27 ` Jason A. Donenfeld 2024-03-14 3:35 ` Jason A. Donenfeld 0 siblings, 1 reply; 5+ messages in thread From: Jason A. Donenfeld @ 2024-03-14 3:27 UTC (permalink / raw) To: Breno Leitao Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel, horms, dsahern, open list:WIREGUARD SECURE NETWORK TUNNEL On Wed, Mar 13, 2024 at 9:24 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > I applied this series to the wireguard tree. Thanks for the patches. Actually, sorry, nevermind. 1/2 is fine, but 2/2 results in `ip -stats link ...` returning all zeros. Jason ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator 2024-03-14 3:27 ` Jason A. Donenfeld @ 2024-03-14 3:35 ` Jason A. Donenfeld 0 siblings, 0 replies; 5+ messages in thread From: Jason A. Donenfeld @ 2024-03-14 3:35 UTC (permalink / raw) To: Breno Leitao Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel, horms, dsahern, open list:WIREGUARD SECURE NETWORK TUNNEL On Wed, Mar 13, 2024 at 9:27 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > On Wed, Mar 13, 2024 at 9:24 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > > > I applied this series to the wireguard tree. Thanks for the patches. > > Actually, sorry, nevermind. 1/2 is fine, but 2/2 results in `ip -stats > link ...` returning all zeros. Ahh, okay, required some more commits from 6.8. Okay, seems to be working. I'll let this cook a bit and then push it up in a while. Jason ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-14 3:40 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20240308112746.2290505-1-leitao@debian.org> 2024-03-11 9:22 ` [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator Simon Horman [not found] ` <20240308112746.2290505-2-leitao@debian.org> 2024-03-11 9:22 ` [PATCH net-next v2 2/2] wireguard: Remove generic .ndo_get_stats64 Simon Horman 2024-03-14 3:23 ` [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator Jason A. Donenfeld 2024-03-14 3:27 ` Jason A. Donenfeld 2024-03-14 3:35 ` Jason A. Donenfeld
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).