* Looks like 4.13 introduces a new incompatibility
@ 2017-07-10 1:48 Bruno Wolff III
2017-07-10 2:01 ` Jason A. Donenfeld
0 siblings, 1 reply; 9+ messages in thread
From: Bruno Wolff III @ 2017-07-10 1:48 UTC (permalink / raw)
To: wireguard
With Fedora's 4.13.0-0.rc0.git3.1.fc27 kernel, master no longer compiles.
It is still a week before rc1 and I can use 4.12 on the relevant machines,
but I thought I'd give a heads up.
[bruno@wolff src]$ make clean all
make -C /lib/modules/4.13.0-0.rc0.git3.1.fc27.i686+PAE/build M=/home/bruno/WireGuard/src clean
make[1]: Entering directory '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
CLEAN /home/bruno/WireGuard/src/.tmp_versions
make[1]: Leaving directory '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
make -C tools clean
make[1]: Entering directory '/home/bruno/WireGuard/src/tools'
rm -f wg *.o *.d
make[1]: Leaving directory '/home/bruno/WireGuard/src/tools'
make -C /lib/modules/4.13.0-0.rc0.git3.1.fc27.i686+PAE/build M=/home/bruno/WireGuard/src modules
make[1]: Entering directory '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
CC [M] /home/bruno/WireGuard/src/main.o
CC [M] /home/bruno/WireGuard/src/noise.o
CC [M] /home/bruno/WireGuard/src/device.o
/home/bruno/WireGuard/src/device.c:372:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.newlink = newlink,
^~~~~~~
/home/bruno/WireGuard/src/device.c:372:14: note: (near initialization for ‘link_ops.newlink’)
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:303: /home/bruno/WireGuard/src/device.o] Error 1
make[1]: *** [Makefile:1512: _module_/home/bruno/WireGuard/src] Error 2
make[1]: Leaving directory '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
make: *** [Makefile:28: module] Error 2
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Looks like 4.13 introduces a new incompatibility
2017-07-10 1:48 Looks like 4.13 introduces a new incompatibility Bruno Wolff III
@ 2017-07-10 2:01 ` Jason A. Donenfeld
2017-07-10 2:56 ` Bruno Wolff III
0 siblings, 1 reply; 9+ messages in thread
From: Jason A. Donenfeld @ 2017-07-10 2:01 UTC (permalink / raw)
To: Bruno Wolff III; +Cc: WireGuard mailing list
Hey Bruno,
Thanks for the heads up. Does this fix it?
https://git.zx2c4.com/WireGuard/commit/?id=dd007ad550b3def8a858e57aa718af9b00047a28
Jason
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Looks like 4.13 introduces a new incompatibility
2017-07-10 2:01 ` Jason A. Donenfeld
@ 2017-07-10 2:56 ` Bruno Wolff III
2017-07-10 3:03 ` Jason A. Donenfeld
0 siblings, 1 reply; 9+ messages in thread
From: Bruno Wolff III @ 2017-07-10 2:56 UTC (permalink / raw)
To: Jason A. Donenfeld; +Cc: WireGuard mailing list
On Mon, Jul 10, 2017 at 04:01:04 +0200,
"Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
>Hey Bruno,
>
>Thanks for the heads up. Does this fix it?
>
>https://git.zx2c4.com/WireGuard/commit/?id=dd007ad550b3def8a858e57aa718af9b00047a28
It looks like it fixed the problem. (At least device.o gets built.) But it
seems there is another problem.
[bruno@wolff src]$ make clean all
make -C /lib/modules/4.13.0-0.rc0.git3.1.fc27.i686+PAE/build M=/home/bruno/WireGuard/src clean
make[1]: Entering directory '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
CLEAN /home/bruno/WireGuard/src/.tmp_versions
make[1]: Leaving directory '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
make -C tools clean
make[1]: Entering directory '/home/bruno/WireGuard/src/tools'
rm -f wg *.o *.d
make[1]: Leaving directory '/home/bruno/WireGuard/src/tools'
make -C /lib/modules/4.13.0-0.rc0.git3.1.fc27.i686+PAE/build M=/home/bruno/WireGuard/src modules
make[1]: Entering directory '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
CC [M] /home/bruno/WireGuard/src/main.o
CC [M] /home/bruno/WireGuard/src/noise.o
CC [M] /home/bruno/WireGuard/src/device.o
CC [M] /home/bruno/WireGuard/src/peer.o
CC [M] /home/bruno/WireGuard/src/timers.o
CC [M] /home/bruno/WireGuard/src/data.o
CC [M] /home/bruno/WireGuard/src/send.o
CC [M] /home/bruno/WireGuard/src/receive.o
CC [M] /home/bruno/WireGuard/src/socket.o
CC [M] /home/bruno/WireGuard/src/config.o
CC [M] /home/bruno/WireGuard/src/hashtables.o
CC [M] /home/bruno/WireGuard/src/routingtable.o
CC [M] /home/bruno/WireGuard/src/ratelimiter.o
CC [M] /home/bruno/WireGuard/src/cookie.o
/home/bruno/WireGuard/src/cookie.c: In function ‘cookie_message_create’:
/home/bruno/WireGuard/src/cookie.c:156:2: error: implicit declaration of function ‘get_random_bytes_wait’; did you mean ‘get_random_bytes_arch’? [-Werror=implicit-function-declaration]
get_random_bytes_wait(dst->nonce, COOKIE_NONCE_LEN);
^~~~~~~~~~~~~~~~~~~~~
get_random_bytes_arch
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:303: /home/bruno/WireGuard/src/cookie.o] Error 1
make[1]: *** [Makefile:1512: _module_/home/bruno/WireGuard/src] Error 2
make[1]: Leaving directory '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
make: *** [Makefile:28: module] Error 2
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Looks like 4.13 introduces a new incompatibility
2017-07-10 2:56 ` Bruno Wolff III
@ 2017-07-10 3:03 ` Jason A. Donenfeld
2017-07-10 3:17 ` Bruno Wolff III
2017-07-15 21:57 ` Bruno Wolff III
0 siblings, 2 replies; 9+ messages in thread
From: Jason A. Donenfeld @ 2017-07-10 3:03 UTC (permalink / raw)
To: Bruno Wolff III; +Cc: WireGuard mailing list
On Mon, Jul 10, 2017 at 4:56 AM, Bruno Wolff III <bruno@wolff.to> wrote:
> On Mon, Jul 10, 2017 at 04:01:04 +0200,
> "Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
>>
>> Hey Bruno,
>>
>> Thanks for the heads up. Does this fix it?
>>
>>
>> https://git.zx2c4.com/WireGuard/commit/?id=3Ddd007ad550b3def8a858e57aa71=
8af9b00047a28
>
>
> It looks like it fixed the problem. (At least device.o gets built.) But i=
t
> seems there is another problem.
>
> [bruno@wolff src]$ make clean all
> make -C /lib/modules/4.13.0-0.rc0.git3.1.fc27.i686+PAE/build
> M=3D/home/bruno/WireGuard/src clean
> make[1]: Entering directory
> '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
> CLEAN /home/bruno/WireGuard/src/.tmp_versions
> make[1]: Leaving directory
> '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
> make -C tools clean
> make[1]: Entering directory '/home/bruno/WireGuard/src/tools'
> rm -f wg *.o *.d
> make[1]: Leaving directory '/home/bruno/WireGuard/src/tools'
> make -C /lib/modules/4.13.0-0.rc0.git3.1.fc27.i686+PAE/build
> M=3D/home/bruno/WireGuard/src modules
> make[1]: Entering directory
> '/usr/src/kernels/4.13.0-0.rc0.git3.1.fc27.i686+PAE'
> CC [M] /home/bruno/WireGuard/src/main.o
> CC [M] /home/bruno/WireGuard/src/noise.o
> CC [M] /home/bruno/WireGuard/src/device.o
> CC [M] /home/bruno/WireGuard/src/peer.o
> CC [M] /home/bruno/WireGuard/src/timers.o
> CC [M] /home/bruno/WireGuard/src/data.o
> CC [M] /home/bruno/WireGuard/src/send.o
> CC [M] /home/bruno/WireGuard/src/receive.o
> CC [M] /home/bruno/WireGuard/src/socket.o
> CC [M] /home/bruno/WireGuard/src/config.o
> CC [M] /home/bruno/WireGuard/src/hashtables.o
> CC [M] /home/bruno/WireGuard/src/routingtable.o
> CC [M] /home/bruno/WireGuard/src/ratelimiter.o
> CC [M] /home/bruno/WireGuard/src/cookie.o
> /home/bruno/WireGuard/src/cookie.c: In function =E2=80=98cookie_message_c=
reate=E2=80=99:
> /home/bruno/WireGuard/src/cookie.c:156:2: error: implicit declaration of
> function =E2=80=98get_random_bytes_wait=E2=80=99; did you mean =E2=80=98g=
et_random_bytes_arch=E2=80=99?
> [-Werror=3Dimplicit-function-declaration]
> get_random_bytes_wait(dst->nonce, COOKIE_NONCE_LEN);
> ^~~~~~~~~~~~~~~~~~~~~
> get_random_bytes_arch
> cc1: some warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:303:
> /home/bruno/WireGuard/src/cookie.o] Error 1
I need to annoy Ted Tso about this. It'll get merged for rc1 or rc2.
Jason
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Looks like 4.13 introduces a new incompatibility
2017-07-10 3:03 ` Jason A. Donenfeld
@ 2017-07-10 3:17 ` Bruno Wolff III
2017-07-10 3:26 ` Jason A. Donenfeld
2017-07-15 21:57 ` Bruno Wolff III
1 sibling, 1 reply; 9+ messages in thread
From: Bruno Wolff III @ 2017-07-10 3:17 UTC (permalink / raw)
To: Jason A. Donenfeld; +Cc: WireGuard mailing list
On Mon, Jul 10, 2017 at 05:03:42 +0200,
"Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
>
>I need to annoy Ted Tso about this. It'll get merged for rc1 or rc2.
OK. I'll confirm when it builds again. I might try it out early if Tso
has it in a public develoment tree before it gets to Linus' tree. This
might show up other issues in things that build after cookie.o and so might
be worthwhile even if building kernels from source is otherwise not usually
worth the effort for me.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Looks like 4.13 introduces a new incompatibility
2017-07-10 3:03 ` Jason A. Donenfeld
2017-07-10 3:17 ` Bruno Wolff III
@ 2017-07-15 21:57 ` Bruno Wolff III
2017-07-15 22:22 ` Jason A. Donenfeld
1 sibling, 1 reply; 9+ messages in thread
From: Bruno Wolff III @ 2017-07-15 21:57 UTC (permalink / raw)
To: Jason A. Donenfeld; +Cc: WireGuard mailing list
On Mon, Jul 10, 2017 at 05:03:42 +0200,
"Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
>
>I need to annoy Ted Tso about this. It'll get merged for rc1 or rc2.
Linus merged it a couple of hours ago, so it will make rc1. I'll be able
to use Fedora kernels again early next week. I'm going to build another
kernel manually in the mean time. I'll let you know if there is a problem,
otherwise we can consider this issued closed.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-07-15 22:04 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 1:48 Looks like 4.13 introduces a new incompatibility Bruno Wolff III
2017-07-10 2:01 ` Jason A. Donenfeld
2017-07-10 2:56 ` Bruno Wolff III
2017-07-10 3:03 ` Jason A. Donenfeld
2017-07-10 3:17 ` Bruno Wolff III
2017-07-10 3:26 ` Jason A. Donenfeld
2017-07-10 5:44 ` Bruno Wolff III
2017-07-15 21:57 ` Bruno Wolff III
2017-07-15 22:22 ` Jason A. Donenfeld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).