From: Masahiro Yamada <masahiroy@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Shuah Khan <shuah@kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
wireguard@lists.zx2c4.com
Subject: Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK
Date: Mon, 21 Dec 2020 15:18:59 +0900 [thread overview]
Message-ID: <CAK7LNARXa1CQSFJjcqN7Y_8dZ1CSGqjoeox3oGAS_3=4QrHs9g@mail.gmail.com> (raw)
In-Reply-To: <CANiq72=UzRTkh6bcNSjE-kSgBJYX12+zQUYphZ1GcY-7kNxaLA@mail.gmail.com>
On Mon, Dec 14, 2020 at 12:27 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Sun, Dec 13, 2020 at 4:16 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > Because if you get a report of something breaking for your change, you
> > need to work to resolve it, not argue about it. Otherwise it needs to
> > be dropped/reverted.
>
> Nobody has argued that. In fact, I explicitly said the opposite: "So I
> think we can fix them as they come.".
>
> I am expecting Masahiro to follow up. It has been less than 24 hours
> since the report, on a weekend.
>
> Cheers,
> Miguel
Sorry for the delay.
Now I sent out the fix for lantiq_etop.c
https://lore.kernel.org/patchwork/patch/1355595/
The reason of the complication was
I was trying to merge the following patch in the same development cycle:
https://patchwork.kernel.org/project/linux-kbuild/patch/20201117104736.24997-1-olaf@aepfle.de/
-Werror=return-type gives a bigger impact
because any instance of __must_check violation
results in build breakage.
So, I just dropped it from my tree (and, I will aim for 5.12).
The removal of CONFIG_ENABLE_MUST_CHECK is less impactive,
because we are still able to build with some warnings.
Tomorrow's linux-next should be OK
and, you can send my patch in this merge window.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2020-12-21 6:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201128193335.219395-1-masahiroy@kernel.org>
2020-11-30 1:04 ` Nathan Chancellor
2020-11-30 18:16 ` Nick Desaulniers
2020-12-02 12:50 ` Miguel Ojeda
[not found] ` <20201212161831.GA28098@roeck-us.net>
2020-12-13 5:04 ` Miguel Ojeda
2020-12-13 12:55 ` Guenter Roeck
2020-12-13 14:58 ` Miguel Ojeda
2020-12-13 15:16 ` Greg KH
2020-12-13 15:27 ` Miguel Ojeda
2020-12-21 6:18 ` Masahiro Yamada [this message]
2020-12-21 10:02 ` Guenter Roeck
2020-12-21 13:51 ` Miguel Ojeda
2020-12-21 13:51 ` Miguel Ojeda
2020-12-13 15:37 ` Matthias Urlichs
2020-12-13 16:32 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARXa1CQSFJjcqN7Y_8dZ1CSGqjoeox3oGAS_3=4QrHs9g@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=Jason@zx2c4.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).