From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Matthias Urlichs <matthias@urlichs.de>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Masahiro Yamada <masahiroy@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Shuah Khan <shuah@kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
wireguard@lists.zx2c4.com
Subject: Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK
Date: Sun, 13 Dec 2020 17:32:38 +0100 [thread overview]
Message-ID: <CANiq72kajFSgKmYW0tXUXNEQpMwBW7BsFSeqbMVDmXqBXDLh_A@mail.gmail.com> (raw)
In-Reply-To: <f5c2d237-1cc7-5a78-c87c-29b7db825f68@urlichs.de>
On Sun, Dec 13, 2020 at 4:38 PM 'Matthias Urlichs' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
>
> If your change to a function breaks its callers, it's your job to fix
No function has changed. This patch enables a warning (that for some
reason is an error in the case of Guenter).
Even if this was a hard error, the same applies: the function hasn't
changed. It just means callers never tested with
`CONFIG_ENABLE_MUST_CHECK` for *years*.
> the callers proactively instead of waiting for "as they come" bug
> reports. (Assuming, of course, that you know about the breakage. Which
> you do when you tell us that the bad pattern can simply be grepped for.)
No, *we don't know about the breakage*. The grep was for the
particular function Guenter reported, and done to validate his
concern.
If you want to manually inspect every caller of every `__must_check`
function, or to write a cocci patch or a clang-tidy check or similar
(that would be obsolete as soon as `__must_check` is enabled), you are
welcome to do so. But a much better usage of our time would be letting
machines do their job.
> If nothing else, that's far more efficient than [number_of_callers]
> separate patches by other people who each need to find the offending
> change, figure out what to change and/or who to report the problem to,
> and so on until the fix lands in the kernel.
This change is not in Linus' tree, it is on -next.
> Moreover, this wouldn't leave the kernel sources in a non-bisect-able
> state during that time.
Again, the change is in -next. That is the point: to do integration
testing and let the bots run against it.
Cheers,
Miguel
prev parent reply other threads:[~2020-12-13 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201128193335.219395-1-masahiroy@kernel.org>
2020-11-30 1:04 ` Nathan Chancellor
2020-11-30 18:16 ` Nick Desaulniers
2020-12-02 12:50 ` Miguel Ojeda
[not found] ` <20201212161831.GA28098@roeck-us.net>
2020-12-13 5:04 ` Miguel Ojeda
2020-12-13 12:55 ` Guenter Roeck
2020-12-13 14:58 ` Miguel Ojeda
2020-12-13 15:16 ` Greg KH
2020-12-13 15:27 ` Miguel Ojeda
2020-12-21 6:18 ` Masahiro Yamada
2020-12-21 10:02 ` Guenter Roeck
2020-12-21 13:51 ` Miguel Ojeda
2020-12-21 13:51 ` Miguel Ojeda
2020-12-13 15:37 ` Matthias Urlichs
2020-12-13 16:32 ` Miguel Ojeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72kajFSgKmYW0tXUXNEQpMwBW7BsFSeqbMVDmXqBXDLh_A@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=Jason@zx2c4.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=masahiroy@kernel.org \
--cc=matthias@urlichs.de \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).