Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Harsh Shandilya <me@msfjarvis.dev>
To: Lao Deng <laodeng99@163.com>
Cc: wireguard@lists.zx2c4.com
Subject: Re: Introduce Navigation component to Wireguard-Android
Date: Thu, 24 Mar 2022 06:06:51 +0000	[thread overview]
Message-ID: <fb849ca5ae862dae8e8f06d818b2e276@purelymail.com> (raw)
In-Reply-To: <7fd66fe3.14e.17f9a1b030e.Coremail.laodeng99@163.com>

Hi,

On 2022-03-17 22:58, Lao Deng wrote:
> I am going to add some un-related functions to Wireguard-Android . The
> final app. should look like the demo of
> com.google.android.material.bottomnavigation.BottomNavigationView ,
>  which  consists of a  bottom navigation component and several 
> independent fragments( or activities ) . 
> 
> 
> I am wondering how to introduce this navigation component to the
> wireguard-android  project with the least modification :) Could you
> please shed some light on it ?
> Thankyou for your attention :)  
> 

I'm a bit confused, is this change something you are proposing for the 
upstream project or are you looking for assistance to implement this in 
a fork?

I don't think we want a Bottom Navigation component in the app itself 
since it adds no value to the app, the only new destination we could add 
with it would be a quicker entry into settings which is not a 
high-priority destination requiring such a prominent navigation action.

If you want to add it to a fork, the only real help I can provide is 
that MainActivity inflates the main_activity.xml layout which in turn 
handles inflating TunnelListFragment, so you'd want to make changes to 
MainActivity and its layout for adding the component.

--
Harsh Shandilya

      reply	other threads:[~2022-03-24  6:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 22:58 Lao Deng
2022-03-24  6:06 ` Harsh Shandilya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb849ca5ae862dae8e8f06d818b2e276@purelymail.com \
    --to=me@msfjarvis.dev \
    --cc=laodeng99@163.com \
    --cc=wireguard@lists.zx2c4.com \
    --subject='Re: Introduce Navigation component to Wireguard-Android' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).