From: "Vadim A. Misbakh-Soloviov" <zsh@mva.name>
To: zsh-users@zsh.org
Subject: [BUG] adb completion skips devices from serial number completion if they don't report 'product' field in "... devices -l"
Date: Mon, 17 Sep 2018 23:23:15 +0700 [thread overview]
Message-ID: <10113172.57ZNmLz3PP@tp> (raw)
Hi there!
I've faced a pretty sad bug: if, for a some reason, device doesn't report
'product' field in `adb devices -l` listing, it will be skipped from `adb -s`
completion.
For example:
$ adb devices -l
List of devices attached
192.168.0.134:5555 device transport_id:681
192.168.0.111:5555 device product:polaris_a70H model:N8000 device:polaris-
a70H transport_id:680
riki:5555 device product:rk30sdk model:ES9701 device:rk30sdk
transport_id:679
pola:5555 device product:polaris_a70H model:N8000 device:polaris-
a70H transport_id:678
crane:5555 device transport_id:676
192.168.0.69:5555 offline transport_id:671
192.168.0.57:5555 device product:rk30sdk model:ES9701 device:rk30sdk
transport_id:670
$ adb -s 192.168.0.111
available devices
192.168.0.111 pola -- 5555:polaris_a70H
192.168.0.57 riki -- 5555:rk30sdk
As you can see, it misses the `crane` (and *.134) device in completion,
although it is definitelly not offline (and I can run adb against it if I
manually specify it to `-s`.
reply other threads:[~2018-09-17 16:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10113172.57ZNmLz3PP@tp \
--to=zsh@mva.name \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).