From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: yegle <cnyegle@gmail.com>, zsh-users@zsh.org
Subject: Re: gen-hg-bookmark-string hook in vcs_info is not very helpful
Date: Sun, 24 Sep 2017 11:34:17 +0000 [thread overview]
Message-ID: <1506252857.3027539.1116380512.53924863@webmail.messagingengine.com> (raw)
In-Reply-To: <CAFL5w3VJSx-7_2h1zQZF0owTjKXSr2n95zsukdERSFrwttFSTA@mail.gmail.com>
yegle wrote on Fri, 22 Sep 2017 11:33 -0700:
> Specifically, the issue with these lines:
> https://github.com/zsh-users/zsh/blob/master/Functions/VCS_Info/Backends/VCS_INFO_get_data_hg#L140-L142
>
(Tangential: <http://www.zsh.org/cgi-bin/mla/redirect?WORKERNUMBER=37966>)
> if VCS_INFO_hook 'gen-hg-bookmark-string' "${hgbmarks[@]}"; then
> # If there is an active bookmark, annotate it and put it first.
> if [[ -n $curbm ]] ; then
> hgbmarks[(i)$curbm]=()
> hgbmarks[1,0]="${curbm}*"
> fi
> hgbmstring=${(j:, :)hgbmarks}
> # Deannotate the array, in case later code expects it to be valid.
> # (The order is not restored.)
> [[ -n $curbm ]] && hgbmarks[1]=${${hgbmarks[1]}[1,-2]}
> else
> hgbmstring=${hook_com[hg-bookmark-string]}
> fi
>
> Because the existing code append $curbm with *, it seems like I can just
> modify curbm in my hook to add color escape string.
You can't, for two reasons:
1. $curbm is private to VCS_INFO_get_data_hg; it is not part of the API.
The API includes only what's in the manual, e.g., $hook_com and $ret.
2. The codepath you're quoting is the codepath for when there is no
hook. You have a hook so you _should_ be taking the 'else' branch. The
reason you don't is that your hook function neglects to set ret=1
before it returns (again, that's documented).
tl;dr: Add "ret=1" in your hook function.
> Can anyone propose a patch to fix this issue and make
> gen-hg-bookmark-string more useful? I would be happy to send a PR if
> the repo is hosted on Github or something more user friendly :-(
For future reference, "save the output of 'git diff' to a *.txt file and
attach it to an email".
prev parent reply other threads:[~2017-09-24 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 18:33 yegle
2017-09-24 11:34 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506252857.3027539.1116380512.53924863@webmail.messagingengine.com \
--to=d.s@daniel.shahaf.name \
--cc=cnyegle@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).