From: yegle <cnyegle@gmail.com>
To: zsh-users@zsh.org
Subject: gen-hg-bookmark-string hook in vcs_info is not very helpful
Date: Fri, 22 Sep 2017 11:33:18 -0700 [thread overview]
Message-ID: <CAFL5w3VJSx-7_2h1zQZF0owTjKXSr2n95zsukdERSFrwttFSTA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]
Hi list,
I'm trying to highlight the current bookmark in a hg repo with some color.
It looks like gen-hg-bookmark-string is the way to go, but I find it
impossible to do what I plan to do.
Specifically, the issue with these lines:
https://github.com/zsh-users/zsh/blob/master/Functions/VCS_Info/Backends/VCS_INFO_get_data_hg#L140-L142
if VCS_INFO_hook 'gen-hg-bookmark-string' "${hgbmarks[@]}"; then
# If there is an active bookmark, annotate it and put it first.
if [[ -n $curbm ]] ; then
hgbmarks[(i)$curbm]=()
hgbmarks[1,0]="${curbm}*"
fi
hgbmstring=${(j:, :)hgbmarks}
# Deannotate the array, in case later code expects it to be valid.
# (The order is not restored.)
[[ -n $curbm ]] && hgbmarks[1]=${${hgbmarks[1]}[1,-2]}
else
hgbmstring=${hook_com[hg-bookmark-string]}
fi
Because the existing code append $curbm with *, it seems like I can just
modify curbm in my hook to add color escape string. But note the line
`hgbmarks[(i)$curbm]=()`: if you modify $curbm in any way, the result
string will have duplicate bookmarks: one that I modified with color escape
string, one that was failed to remove from the array.
Another option, of course, is to make the change and then unset $curbm at
the end, but this is really a hack:
function +vi-hg-highlight-curbm {
if [[ -n $curbm ]] ; then
hgbmarks[(i)$curbm]=()
hgbmarks[1,0]="%{$fg_bold[red]%}${curbm}%{$reset_color%}*"
curbm=""
fi
}
I think a very simple fix for this issue is to modify the line to:
hgbmarks[1,0]="${hook_com[hg-active-bookmark]}*"
Can anyone propose a patch to fix this issue and make
gen-hg-bookmark-string more useful? I would be happy to send a PR if the
repo is hosted on Github or something more user friendly :-(
--
Yuchen Ying
https://about.me/yegle
next reply other threads:[~2017-09-22 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 18:33 yegle [this message]
2017-09-24 11:34 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFL5w3VJSx-7_2h1zQZF0owTjKXSr2n95zsukdERSFrwttFSTA@mail.gmail.com \
--to=cnyegle@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).