help / color / mirror / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-users@zsh.org
Subject: Re: edit-command-line breaks out of vared
Date: Mon, 20 Aug 2018 12:58:32 +0000
Message-ID: <1534769912.102537.1479915000.00485AFF@webmail.messagingengine.com> (raw)
In-Reply-To: <CAH+w=7aL3yswgM36XU_ehwa5ppH0zXw4qxCgCLiOwKRBH3XbnA@mail.gmail.com>

Bart Schaefer wrote on Sun, 19 Aug 2018 12:03 -0700:
> > On Sun, Aug 19, 2018 at 2:22 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >>
> >> I expected quitting the editor to let me resume the vared session
> My first inclination here is to ask why you expected that ...
> >> instead it left me with the variable's value as a command line.
> ... because the name of the function is edit-command-line, after all.

I assumed edit-command-line would work inside vared, despite the
name, and that when $EDITOR finished it would return me to the
previous context.

> On Sun, Aug 19, 2018 at 6:18 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
> > This works in my version of edit-command-line,
> >
> > +  [[ -z $PREBUFFER ]] && {
> Hrm, is PREBUFFER really guaranteed to be empty whenever vared is
> running?  I suppose so.

Is there a reason not to commit that?  Before we might've thought it was only
an optimisation but now it seems to enable behaviour that isn't possible with
the code in HEAD.  I don't see anything in my archives about reasons not to
commit that.



  reply	other threads:[~2018-08-20 13:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-19 12:22 Daniel Shahaf
2018-08-19 13:18 ` Mikael Magnusson
2018-08-19 19:03   ` Bart Schaefer
2018-08-20 12:58     ` Daniel Shahaf [this message]
2020-08-05 11:12       ` Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1534769912.102537.1479915000.00485AFF@webmail.messagingengine.com \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-users@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link


This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/zsh-users

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 zsh-users zsh-users/ http://inbox.vuxu.org/zsh-users \
	public-inbox-index zsh-users

Example config snippet for mirrors.
Newsgroup available over NNTP:

code repositories for the project(s) associated with this inbox:


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git