Re: Catch URLs (was: "Literal" command execution)

[Peter Stephenson <Peter.Stephenson@csr.com>]

On Mon, 13 Feb 2012 12:38:55 +0000
<mark+lists@internecto.net> wrote:
> url-quote-magic:68: array parameter reply created globally in function
> url-quote-magic:72: array parameter reply created globally in function

I don't think reply can be need outside url-quote-magic, can it?
In fact, the function itself doesn't use it either --- ideally zstyle
should have a mechanism for making it local within itself.

Index: Functions/Zle/url-quote-magic
===================================================================
RCS file: /cvsroot/zsh/zsh/Functions/Zle/url-quote-magic,v
retrieving revision 1.3
diff -p -u -r1.3 url-quote-magic
--- Functions/Zle/url-quote-magic	11 Jul 2008 19:12:24 -0000	1.3
+++ Functions/Zle/url-quote-magic	13 Feb 2012 12:56:17 -0000
@@ -60,6 +60,7 @@
 #       Use compsys for nested quoting analysis and command parsing.
 
 # Establish default values for styles, but only if not already set
+local -a reply
 
 zstyle -m ':url-quote-magic:\*' url-metas '*' ||
     zstyle ':url-quote-magic:*' url-metas '*?[]^(|)~#{}='

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog