From: Mark <lists+zsh@internecto.net>
To: zsh-users@zsh.org
Subject: Re: Catch URLs (was: "Literal" command execution)
Date: Sat, 31 Mar 2012 18:00:50 +0200 [thread overview]
Message-ID: <20120331180050.29e0f78a@internecto.net> (raw)
In-Reply-To: <20120213125759.416c7016@pwslap01u.europe.root.pri>
Hi,
On Mon, 13 Feb 2012 12:57:59 +0000
Peter Stephenson <Peter.Stephenson@csr.com> wrote:
> On Mon, 13 Feb 2012 12:38:55 +0000
> <mark+lists@internecto.net> wrote:
> > url-quote-magic:68: array parameter reply created globally in
> > function url-quote-magic:72: array parameter reply created globally
> > in function
>
> I don't think reply can be need outside url-quote-magic, can it?
> In fact, the function itself doesn't use it either --- ideally zstyle
> should have a mechanism for making it local within itself.
>
> Index: Functions/Zle/url-quote-magic
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Functions/Zle/url-quote-magic,v
> retrieving revision 1.3
> diff -p -u -r1.3 url-quote-magic
> --- Functions/Zle/url-quote-magic 11 Jul 2008 19:12:24
> -0000 1.3 +++ Functions/Zle/url-quote-magic 13 Feb 2012
> 12:56:17 -0000 @@ -60,6 +60,7 @@
> # Use compsys for nested quoting analysis and command parsing.
>
> # Establish default values for styles, but only if not already set
> +local -a reply
>
> zstyle -m ':url-quote-magic:\*' url-metas '*' ||
> zstyle ':url-quote-magic:*' url-metas '*?[]^(|)~#{}='
>
Hmm, I have recently upgraded zsh and although I saw your patch
included, the error came back. Apparently I had fixed it manually.
Please see below. I wonder whether this method is ideal for you.
Thanks,
Mark
diff -pU1 old/url-quote-magic new/url-quote-magic
--- old/url-quote-magic 2012-03-31 17:58:23.646634259 +0200
+++ new/url-quote-magic 2012-03-31 17:57:13.587013805 +0200
@@ -68,3 +68,3 @@ zstyle -m ':url-quote-magic:\*' url-meta
zstyle -m ':url-quote-magic:\*' url-seps '*' ||
- zstyle -e ':url-quote-magic:*' url-seps 'reply=(";&<>${histchars[1]}")'
+ zstyle -e ':url-quote-magic:*' url-seps 'local -a reply; reply=(";&<>${histchars[1]}")'
@@ -72,3 +72,3 @@ zstyle -m :url-quote-magic url-globbers
zstyle -e :url-quote-magic url-globbers \
- 'zmodload -i zsh/parameter;
+ 'local -a reply; zmodload -i zsh/parameter;
reply=( noglob
next prev parent reply other threads:[~2012-03-31 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 19:51 "Literal" command execution Yuri D'Elia
2012-01-23 22:13 ` Damien Thébault
2012-02-13 12:38 ` Catch URLs (was: "Literal" command execution) mark+lists
2012-02-13 12:57 ` Peter Stephenson
2012-02-14 15:27 ` Mark van Dijk
2012-03-31 16:00 ` Mark [this message]
2012-04-01 17:18 ` Peter Stephenson
2012-04-02 16:13 ` Mark van Dijk
2012-01-23 22:32 ` "Literal" command execution Bart Schaefer
2012-01-24 11:52 ` Yuri D'Elia
2012-01-24 21:12 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120331180050.29e0f78a@internecto.net \
--to=lists+zsh@internecto.net \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).