From: Tomasz Pala <gotar@polanet.pl>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-users@zsh.org
Subject: Re: cd /u/N/v/ tab expansion
Date: Sun, 10 Apr 2022 20:05:09 +0200 [thread overview]
Message-ID: <20220410180509.GA26578@polanet.pl> (raw)
In-Reply-To: <20220410174551.GB22715@polanet.pl>
On Sun, Apr 10, 2022 at 19:45:51 +0200, Tomasz Pala wrote:
> ...and THIS doesn't work with SUFFIX="*/d/e/g*" - therefore I did:
>
>
> - compadd "$tmp4[@]" $listopts - "$i"
> + compadd "$tmp4[@]" -U $listopts - "$i"
This with list-dirs-first has one issue:
$ ls u/s*/ax -- cursor over 'a', tab menu cycling
[directories]
usr/share/aclocal/ x
usr/share/atever/ x
[files]
usr/sbin/a1
usr/share/a1
usr/share/a2
Note missing ' x' after completing files. Is that -U dropping the SUFFIX?
>
> - [[ -n "$compstate[pattern_match]" ]] && SUFFIX="${SUFFIX:s./.*/}*"
> + [[ -n "$compstate[pattern_match]" ]] && SUFFIX="${SUFFIX:gs./.*/}*"
>
>
> The second solution doesn't play well with add-space style:
>
> $ ls a/b/d/e/g[tab]
> b1/d/e1/g/ b1/d/e2/g/ b2/d/e1/g/ b2/d/e2/g/
>
> [ctrl-g]
> $ ls a/b/d/e/g[tab]
> $ ls a/b1/d/e1/ /g
> ^ cursor position
> b1/d/e1/ b1/d/e2/ b2/d/e1/ b2/d/e2/
>
> [ctrl-g]
> $ ls a/b/d/e/g[tab]
> b1/d/e1/g/ b1/d/e2/g/ b2/d/e1/g/ b2/d/e2/g/
>
> and so on, over and over again.
This cycling (ctrl-g toggling of behaviour) means something is not being
reset/unset properly and should be fixed.
However the latter case:
> $ zstyle -d :completion:\* add-space
> $ ls a/b/d/e/g[tab]
> $ ls a/b1/d/e1//g
> b1/d/e1/ b1/d/e2/ b2/d/e1/ b2/d/e2/
with cursor over first of "//" also differs from the first run (the
correct one).
This is caused by MBEGIN and MEND variables being set in both cases
(add-space and not). If they are about to be kept between the completion
invocations (even after the ctrl-c), they should not be used in
completion functions. Otherwise they should be cleared not to leak some
bogus state into consecutive invocations.
What is the purpose of MBEGIN and MEND?
> Both of the solutions also seem to fix the list-dirs-first true issue!
--
Tomasz Pala <gotar@pld-linux.org>
next prev parent reply other threads:[~2022-04-10 18:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 12:40 zzapper
2022-04-07 20:11 ` Bart Schaefer
2022-04-07 20:20 ` zzapper
2022-04-07 23:11 ` Bart Schaefer
2022-04-08 9:53 ` zzapper
2022-04-08 17:57 ` Bart Schaefer
2022-04-08 10:22 ` david rayner
2022-04-08 18:09 ` Bart Schaefer
2022-04-10 1:04 ` Tomasz Pala
2022-04-10 14:32 ` Tomasz Pala
2022-04-10 16:27 ` Tomasz Pala
2022-04-10 16:32 ` Tomasz Pala
2022-04-10 17:45 ` Tomasz Pala
2022-04-10 18:05 ` Tomasz Pala [this message]
2022-04-16 14:17 ` Tomasz Pala
2022-04-17 3:00 ` Bart Schaefer
2022-04-17 16:17 ` Tomasz Pala
2022-04-17 18:15 ` Bart Schaefer
2022-04-17 18:44 ` Bart Schaefer
2022-04-17 18:32 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220410180509.GA26578@polanet.pl \
--to=gotar@polanet.pl \
--cc=schaefer@brasslantern.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).