help / color / mirror / code / Atom feed
From: Oliver Kiddle <opk@zsh.org>
To: "Jörg Sommer" <joerg@jo-so.de>
Cc: zsh-users@zsh.org
Subject: Re: How to get all tagets for rake completion?
Date: Wed, 31 Mar 2021 02:10:14 +0200	[thread overview]
Message-ID: <43486-1617149414.412147@zBmo.ESTa.9XAh> (raw)
In-Reply-To: <20201215214027.a3htwtas6su3fhz5@jo-so.de>

On 15 Dec, Jörg Sommer wrote:
> > > I would like to get all targets for the completion of rake arguments. How
> > > can I inject an argument to the targets query call or how to replace it? I
> > > have to pass `-A` to *rake* to get the arguments for the completion.

Sorry that this patch didn't receive any attention earlier.

To try to understand this, what is the disadvantage of calling rake with
-A? Does that make it much slower or is it that most users wouldn't want
"uncommented" targets? If they're fully applicable, it may be better to
add the -A without a style. It looks like the descriptions are included
in the rake output so you could separate them out and add matches with
both the commented-targets and uncommented-targets tags.

Incidentally, _rake doesn't seem to complete the -A option so that must
be newish.

> What do you think about the attached commit? Is it fine or should I change
> anything?

When looking up the style, you should include the tag in the context
when one is applicable, so ":completion:${curcontext}:targets" in this

As a general principle, it is better to use a style name that has a
generic meaning. I can't find any existing style along the lines of an
extra-matches, more-matches, allow-slow-generation etc so unless I've
missed one you'd need to invent a suitable one. "all-targets" is too
specific to targets.


  reply	other threads:[~2021-03-31  0:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 12:57 Jörg Sommer
2020-12-15 17:12 ` Peter Stephenson
2020-12-15 21:40   ` Jörg Sommer
2021-03-31  0:10     ` Oliver Kiddle [this message]
2021-03-31  7:45       ` Jörg Sommer
2021-03-31  9:50         ` Oliver Kiddle
2021-04-04  8:28           ` Jörg Sommer
2021-04-08 21:51             ` Oliver Kiddle
2021-04-12  8:07               ` Jörg Sommer
2021-04-25 16:34                 ` Lawrence Velázquez
2021-05-02 16:52                   ` Lawrence Velázquez
2021-05-09 17:32                     ` Lawrence Velázquez
2021-05-10 12:14                       ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43486-1617149414.412147@zBmo.ESTa.9XAh \
    --to=opk@zsh.org \
    --cc=joerg@jo-so.de \
    --cc=zsh-users@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).