zsh-users
 help / color / mirror / code / Atom feed
From: "Jörg Sommer" <joerg@jo-so.de>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-users@zsh.org
Subject: Re: How to get all tagets for rake completion?
Date: Tue, 15 Dec 2020 22:40:27 +0100	[thread overview]
Message-ID: <20201215214027.a3htwtas6su3fhz5@jo-so.de> (raw)
In-Reply-To: <1047872238.2253883.1608052325319@mail2.virginmedia.com>


[-- Attachment #1.1: Type: text/plain, Size: 1188 bytes --]

Peter Stephenson schrieb am Di 15. Dez, 17:12 (+0000):
> > On 15 December 2020 at 12:57 Jörg Sommer <joerg@jo-so.de> wrote:
> > I would like to get all targets for the completion of rake arguments. How
> > can I inject an argument to the targets query call or how to replace it? I
> > have to pass `-A` to *rake* to get the arguments for the completion.
> 
> Frankly, your best bet is probably just to copy the distributed _rake
> function and adapt it, copying it to somewhere early in your $fpath.
> You'll see towards the end an extremely complicated line with "-sT" in
> the middle --- just change that to "-sTA".
> 
> I have a feeling it might be possible to set a style so that the
> _call_program helper does something different for you, but I'm not
> sure there's any benefit in being too clever here.  The _rake completer
> doesn't change very often, I don't think.
> 
> (This could be made a style for the _rake completer easily enough,
> in fact.)

What do you think about the attached commit? Is it fine or should I change
anything?


Jörg

-- 
Was ist das bloß für eine Welt, in der es mehr Mut braucht ehrlich zu
weinen als Stärke vorzutäuschen?

[-- Attachment #1.2: 0001-Completion-_rake-add-zsytle-for-targets-without-desc.patch --]
[-- Type: text/x-diff, Size: 1533 bytes --]

From 640e40dc81833624281f5c146b514417f251b4c3 Mon Sep 17 00:00:00 2001
Message-Id: <640e40dc81833624281f5c146b514417f251b4c3.1608068274.git.joerg@jo-so.de>
From: =?UTF-8?q?J=C3=B6rg=20Sommer?= <joerg@jo-so.de>
Date: Tue, 15 Dec 2020 22:32:46 +0100
Subject: [PATCH] Completion/_rake: add zsytle for targets without description

`rake -T` shows only these targets having a description. But it might be
useful to see all. Allow this with the zsytle setting:

zstyle :completion::complete:rake:argument-rest all-targets true
---
 Completion/Unix/Command/_rake | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Completion/Unix/Command/_rake b/Completion/Unix/Command/_rake
index 8814edaa5..88c25d7cf 100644
--- a/Completion/Unix/Command/_rake
+++ b/Completion/Unix/Command/_rake
@@ -37,7 +37,9 @@ case "$state" in
   ;;
   target)
     local -a targets
-    targets=( ${${(f)"$(_call_program targets $words[1] -sT $opt_args[(I)(-N|--nosearch)] ${(kv)opt_args[(I)(-f|--rakefile)]} 2>/dev/null)"}/(#b)rake ([^ ]##) ##\# (*)/${${match[1]}//:/\\:}:${match[2]:l}} )
+    local all
+    zstyle -t ":completion:${curcontext}" all-targets && all=-A
+    targets=( ${${(f)"$(_call_program targets $words[1] $all -sT $opt_args[(I)(-N|--nosearch)] ${(kv)opt_args[(I)(-f|--rakefile)]} 2>/dev/null)"}/(#b)rake ([^ ]##) ##\# (*)/${${match[1]}//:/\\:}:${match[2]:l}} )
     if (( ! ${targets[(I)rake aborted!]} )) then
       _describe -t targets 'rake target' targets && ret=0
     else
-- 
2.29.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 269 bytes --]

  reply	other threads:[~2020-12-15 21:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 12:57 Jörg Sommer
2020-12-15 17:12 ` Peter Stephenson
2020-12-15 21:40   ` Jörg Sommer [this message]
2021-03-31  0:10     ` Oliver Kiddle
2021-03-31  7:45       ` Jörg Sommer
2021-03-31  9:50         ` Oliver Kiddle
2021-04-04  8:28           ` Jörg Sommer
2021-04-08 21:51             ` Oliver Kiddle
2021-04-12  8:07               ` Jörg Sommer
2021-04-25 16:34                 ` Lawrence Velázquez
2021-05-02 16:52                   ` Lawrence Velázquez
2021-05-09 17:32                     ` Lawrence Velázquez
2021-05-10 12:14                       ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201215214027.a3htwtas6su3fhz5@jo-so.de \
    --to=joerg@jo-so.de \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).