zsh-users
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Cc: Zsh Users <zsh-users@zsh.org>
Subject: Re: Why the widget bound to menuselect isn't called?
Date: Sun, 14 Jul 2019 12:38:21 +0200	[thread overview]
Message-ID: <53445-1563100701.603642@DtMP.e8mM.jHzi> (raw)
In-Reply-To: <CAKc7PVDktOywqbY28eMgrha2pQ30QxO4eA7QdA1C5a54=8B99w@mail.gmail.com>

Sebastian Gniazdowski wrote:
> It seems to me that the main problem / idea is to replace the above
> check(s) which are keymap-specific to a more general solution, which
> would:
> ??? allow automatic mapping of an invocation of a widget to a
> $KEYMAP-variant of the widget
> ??? provide a set of base widgets that are $KEYMAP-specific, so that
> users can use them as the building blocks of custom widgets.

Yes. However, there would be further problems like ensuring that non-
menu selection widgets abort menu selection and preserve backwards
compatibility as far as possible. Providing basic widgets
would be the easy (but tedious) part. The automatic mapping is harder
because an approach needs to be worked out and designed.

> Then:
> ??? the above check(s) are an entry point to a set of such
> keymap-specific widgets and seem to implement the keymap-specific
> automatic selection of the widgets, however they're a high level
> widgets, not a fine-grained building blocks,
> ??? because of this lack of fine-grained widgets the designers of the
> code decided to not allow overloading of them.
>
> Is this correct? Because if yes, then it would seem that the existing
> mechanism can be still used, if the fine-grained widgets will be
> provided and the overloading of the widgets will be enabled.

I'm not sure I follow what you're saying. It may have been better if
there had been fine-grained widgets to begin with but that alone is not
sufficient (either now or at the time of the module's inception).

> It seems that it is about forwarding the keymap-specific mechanism to
> the Zshell code in an consistent way with the C code. The question is
> is this necessary?

Consistency with Functions/Zle/keymap+widget isn't necessary.
Not breaking backwards compatibility that allows menu selection key
bindings to reflect users' normal key bindings is necessary. I was
trying to outline some vague ideas on how this might be approached.

Oliver

  parent reply	other threads:[~2019-07-14 10:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 20:55 Sebastian Gniazdowski
2019-07-12 18:44 ` Sebastian Gniazdowski
2019-07-12 19:36   ` Bart Schaefer
2019-07-13  1:23     ` Sebastian Gniazdowski
2019-07-13  2:29       ` Ben Klein
2019-07-13  8:59 ` Oliver Kiddle
2019-07-13 12:19   ` Sebastian Gniazdowski
2019-07-13 12:23     ` Sebastian Gniazdowski
2019-07-13 16:39     ` Bart Schaefer
2019-07-13 16:42       ` Bart Schaefer
2019-07-14 10:38     ` Oliver Kiddle [this message]
2019-07-14 21:56       ` Sebastian Gniazdowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53445-1563100701.603642@DtMP.e8mM.jHzi \
    --to=okiddle@yahoo.co.uk \
    --cc=sgniazdowski@gmail.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).