error?

error?

[Ray Andrews]

I just finished creating a back of my whole install, then did a 
configure and make in the backup and got this:


    zle_thingy.c:667:1: warning: ‘zle_usable’ was used with no prototype
    before its definition [-Wmissing-prototypes]
      zle_usable()
      ^
    zle_thingy.c: In function ‘bin_zle_flags’:
    zle_thingy.c:663:1: warning: control reaches end of non-void
    function [-Wreturn-type]
      }
      ^

... which was partially highlighted in green, so it seemed significant.  
However on doing a 'git pull' and 'make' again, the message was absent 
so that might have been some transitory glitch. There doesn't seem to be 
anything wrong.

Re: error?

[Peter Stephenson]

On Mon, 26 Oct 2015 08:28:42 -0700
Ray Andrews <rayandrews@eastlink.ca> wrote:
> I just finished creating a back of my whole install, then did a 
> configure and make in the backup and got this:
> 
> 
>     zle_thingy.c:667:1: warning: ‘zle_usable’ was used with no prototype

That is, in fact, to use the technical description, wrong.

pws

diff --git a/Src/Zle/zle_thingy.c b/Src/Zle/zle_thingy.c
index c6ef8e6..271fd8e 100644
--- a/Src/Zle/zle_thingy.c
+++ b/Src/Zle/zle_thingy.c
@@ -626,7 +626,7 @@ bin_zle_complete(char *name, char **args, UNUSED(Options ops), UNUSED(char func)
 
 /**/
 static int
-zle_usable()
+zle_usable(void)
 {
     return zleactive && !incompctlfunc && !incompfunc
 #if 0

Re: error?

[Bart Schaefer]

On Oct 26,  5:54pm, Peter Stephenson wrote:
} Subject: Re: error?
}
} On Mon, 26 Oct 2015 08:28:42 -0700
} Ray Andrews <rayandrews@eastlink.ca> wrote:
} > I just finished creating a back of my whole install, then did a 
} > configure and make in the backup and got this:
} > 
} > 
} >     zle_thingy.c:667:1: warning: `zle_usable' was used with no prototype
} 
} That is, in fact, to use the technical description, wrong.

Still, the other error was definitely spurious, and:

Src/Modules/zftp.c:412:zfpipe()
Src/Modules/zftp.c:453:zfunpipe()
Src/Modules/zftp.c:1301:zfendtrans()
Src/Modules/zftp.c:2837:savesession()
Src/Zle/complist.c:502:getcols()
Src/Zle/complist.c:605:initiscol()
Src/Zle/complist.c:1912:singledraw()
Src/Zle/computil.c:188:cd_calc()
Src/Zle/computil.c:239:cd_prep()
Src/Zle/zle_thingy.c:629:zle_usable()
Src/parse.c:533:clear_hdocs()

So unless we're going to stick (void) in everywhere, I think the whole
event was spurious.

(Also this really belongs on -workers.)

Re: error?

[Ray Andrews]

On 10/26/2015 11:11 AM, Bart Schaefer wrote:
> So unless we're going to stick (void) in everywhere, I think the whole
> event was spurious.

Strange that I've never seen it before. Anyway, if it didn't flash green 
text at me I'd
have let it slide.  Ya get used to some things showing errors that are 
dealt with
latter--fallbacks and such.
>
> (Also this really belongs on -workers.)
>
Not my black ass ;-)