From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: phy1729@gmail.com, zsh-users@zsh.org
Subject: Re: zsh 5.0.8-test-2
Date: Sat, 22 Aug 2015 20:48:47 +0900 [thread overview]
Message-ID: <9306B4F4-68C3-4EC5-93FD-A40346692465@kba.biglobe.ne.jp> (raw)
In-Reply-To: <CAGnh9tBv_-2ddZWCCqfO+9myfMXFMm3k+To=1M43P8W_00+sAQ@mail.gmail.com>
2015/08/22 09:10, Matthew Martin <phy1729@gmail.com> wrote:
> Running on an OpenBSD snapshot, test X02zlevi just hangs without any
> output
I've tested on my minimal install of OpenBSD 5.6. It seems the test
hangs at line 24 of comptest (in function comptestinit()):
zpty -r zsh log1 "*<PROMPT>*" || {
Matthews, could you try with the patch at the end of this post?
OpenBSD does not have /dev/ptmx (it has /dev/ptm instead), but has
posix_openpt() function (OpenBSD 5.3 or later).
In zsh-5.0.8, USE_DEV_PTMX is not defined on OpenBSD (because it does
not have /dev/ptmx), and zpty.c uses the old BSD-style code (line 246
and below in zpty.c).
In zsh-5.0.8-test-2 (or 5.1.0rc), configure.ac has changed and
USE_DEV_PTMX is defined because posix_openpt() exists, so zpty.c uses
posix_opennt() (HAVE_POSIX_OPENPT is also defined).
It is OK if posix_openpt() really works, but the fact that X02zlevi hangs
suggests that it is not working as we expect due to some unknown
reasons. Simply undefining USE_DEV_PTMX seems to work on my OpenBSD.
Jun
diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c
index 12e42b5..8fc6b21 100644
--- a/Src/Modules/zpty.c
+++ b/Src/Modules/zpty.c
@@ -154,7 +154,7 @@ getptycmd(char *name)
return NULL;
}
-#ifdef USE_DEV_PTMX
+#if defined(USE_DEV_PTMX) && !defined(__OpenBSD__)
#ifdef HAVE_SYS_STROPTS_H
#include <sys/stropts.h>
next prev parent reply other threads:[~2015-08-22 11:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 20:50 Peter Stephenson
2015-08-22 0:10 ` Matthew Martin
2015-08-22 0:30 ` Michael Beasley
2015-08-22 0:45 ` Matthew Martin
2015-08-22 11:48 ` Jun T. [this message]
2015-08-22 17:04 ` Matthew Martin
2015-08-23 8:31 ` Daniel Shahaf
2015-08-23 12:45 ` Jun T.
2015-08-28 2:05 ` string to array space problem in filenames Ray Andrews
2015-08-28 3:15 ` Mikael Magnusson
2015-08-28 18:54 ` Ray Andrews
2015-08-28 19:43 ` Bart Schaefer
2015-08-28 20:42 ` Ray Andrews
2015-08-28 20:56 ` Peter Stephenson
2015-09-03 3:37 ` Ray Andrews
2015-09-03 4:48 ` Kurtis Rader
2015-09-03 5:25 ` Bart Schaefer
2015-09-03 5:53 ` Mikael Magnusson
2015-09-03 15:23 ` Ray Andrews
2015-09-03 15:30 ` Mikael Magnusson
2015-09-03 15:58 ` Ray Andrews
2015-09-03 16:08 ` Peter Stephenson
2015-09-03 16:11 ` Ray Andrews
2015-09-03 17:11 ` Ray Andrews
[not found] ` <55E86E0C.1000806__15798.3473306105$1441295967$gmane$org@eastlink.ca>
2015-09-03 16:21 ` Stephane Chazelas
2015-08-28 9:40 ` Peter Stephenson
2015-08-28 19:02 ` Ray Andrews
2015-08-28 19:45 ` Bart Schaefer
2015-08-28 20:35 ` Ray Andrews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9306B4F4-68C3-4EC5-93FD-A40346692465@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=phy1729@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).