From: Felipe Contreras <felipe.contreras@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh Users <zsh-users@zsh.org>
Subject: Re: git-completion 1.2 released
Date: Mon, 23 Nov 2020 01:49:16 -0600 [thread overview]
Message-ID: <CAMP44s3hgjja=jFcmPOXiXCNMQtE2FNuzfzxOAhBGWi13wXfRg@mail.gmail.com> (raw)
In-Reply-To: <20201123043359.GC31253@tarpaulin.shahaf.local2>
On Sun, Nov 22, 2020 at 10:34 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Felipe Contreras wrote on Sat, Nov 21, 2020 at 18:53:56 -0600:
> > But the main use of "git send-email" is not to receive random files,
> > it's to receive comittishes, and potentially some .patch files.
>
> So, just this? Will anyone want to complete files that _don't_ have
> a .patch extension?
Usually "git send-email" receives the patches generated by "git
format-patch", so yeah, *.patch should be enough. But it probably
wouldn't hurt to add *.diff files too, just in case.
> > If I do "git send-email master..<tab>" nothing completes with Zsh's
> > official completion. It does with mine.
>
> Thanks for the bug report.
You're welcome.
But that's just an example. Another example is that "git -C ~/dev/git
show <tab>" doesn't work, and the _git function has a TODO about -c
since 2011. And there's a lot of others.
I did some hacks to run Zsh's official Git completion against Git's
testing framework, and at least half of them fail. I could tell you
how to do that if you are interested.
So in my view it's clear the priorities of the two completions are
very different.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2020-11-23 7:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 16:05 Felipe Contreras
2020-11-21 16:03 ` Daniel Shahaf
2020-11-21 20:14 ` Bart Schaefer
2020-11-22 0:59 ` Felipe Contreras
2020-11-22 0:53 ` Felipe Contreras
2020-11-23 4:33 ` Daniel Shahaf
2020-11-23 7:49 ` Felipe Contreras [this message]
2020-11-23 15:44 ` Daniel Shahaf
2020-11-23 18:31 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s3hgjja=jFcmPOXiXCNMQtE2FNuzfzxOAhBGWi13wXfRg@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).