Makefile completion with wildcard targets

Makefile completion with wildcard targets

[Andri Möll]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Hey,

I’ve got a few GNU Makefiles that contain targets in the form of “test/*_test.js”. Autocomplete however doesn’t considers them to be filenames and completes them to a literal "test/\*_test.js”. A little annoying. Does anyone have a off the head idea how to fix that in /usr/share/zsh/functions/_make? I’m on Zsh v5.0.8 here.

Thanks in advance!

Andri

Re: Makefile completion with wildcard targets

[Bart Schaefer]

You could try changing (near the end of _make):

        _requested targets expl 'make targets' \
          compadd -- ${(k)TARGETS} && ret=0

to

        _requested targets expl 'make targets' \
          compadd -Q -- ${(k)TARGETS} && ret=0

Thereafter the _expand completer should be able to resolve them into
file names.

Any zsh-workers have an opinion on whether this would be correct for all
targets?  Should we just make this change in the distribution?

Re: Makefile completion with wildcard targets

[Jun T.]

On 2015/07/28, at 3:13, Bart Schaefer <schaefer@brasslantern.com> wrote:

> Should we just make this change in the distribution?

Probably, because if the target has meta-characters like # or ^
then we can use
% make '<TAB>

But while I was testing I found another (independent) problem:
the function _make-expandVars() is not working at all.

I'll continue this subject on the zsh-workers list.

Re: Makefile completion with wildcard targets

[Andri Möll]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Finally got around to giving it a spin and it seems to work. Thank you!

A.


Bart Schaefer wrote:
> You could try changing (near the end of _make):
>
>          _requested targets expl 'make targets' \
>            compadd -- ${(k)TARGETS}&&  ret=0
>
> to
>
>          _requested targets expl 'make targets' \
>            compadd -Q -- ${(k)TARGETS}&&  ret=0
>
> Thereafter the _expand completer should be able to resolve them into
> file names.
>
> Any zsh-workers have an opinion on whether this would be correct for all
> targets?  Should we just make this change in the distribution?