zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: Re: Geoff's prompt escape sequences patch (workers/23924)
Date: Fri, 16 Nov 2007 08:45:37 -0800	[thread overview]
Message-ID: <071116084537.ZM20036@torch.brasslantern.com> (raw)
In-Reply-To: <237967ef0711160657x550e449ch44c78a8798238372@mail.gmail.com>

On Nov 16,  3:57pm, Mikael Magnusson wrote:
} Subject: Re: Geoff's prompt escape sequences patch (workers/23924)
}
} I've found another problem that seems to be caused by this patch
} (located by git-bisect). When a bg'd job finishes, the cursor is drawn
} in the wrong place in the new prompt (#bar characters to the left).

It would appear that the starting position for the right prompt is not
being recomputed correctly.  It's not just that the cursor is moved
left; RPS1 still begins at the same column even though it is shorter,
so it doesn't reach all the way to the margin.

The cursor positioning error is probably only apparent when the number
of bytes in the terminfo "move left N" string is less than the number
in "move to position X,Y".

} The simplest test case i could find was
} zsh -f
} PS1="frobnizz %#"      #not really needed but since the default
} depends on hostname...
} RPS1="foo%(1j.bar.)"
} true &

The effect is more obvious if you change to RPS1="%(1j.bar.)foo"


  reply	other threads:[~2007-11-16 16:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-18 13:59 Bart Schaefer
2007-10-19  1:36 ` Geoff Wing
2007-11-16 14:57 ` Mikael Magnusson
2007-11-16 16:45   ` Bart Schaefer [this message]
2007-11-17  9:26     ` Geoff Wing
2007-11-17 10:13       ` Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=071116084537.ZM20036@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).