From: "Mikael Magnusson" <mikachu@gmail.com>
To: zsh-workers@sunsite.dk
Subject: Re: Geoff's prompt escape sequences patch (workers/23924)
Date: Fri, 16 Nov 2007 15:57:31 +0100 [thread overview]
Message-ID: <237967ef0711160657x550e449ch44c78a8798238372@mail.gmail.com> (raw)
In-Reply-To: <071018065911.ZM11918@torch.brasslantern.com>
On 18/10/2007, Bart Schaefer <schaefer@brasslantern.com> wrote:
> I just noticed this never got committed to CVS. I've tried it and it is
> giving 99% of the correct behavior now (well, what I think is the correct
> behavior; I never tried ending a prompt by turning ON standout, before).
>
> The only glitch I can find by randomly fooling around is that completion
> sometimes erases a standout space to the left of the word, inserts a plain
> space, and then draws the completed word in standout, so you end up with
> a command line with a "hole" in it. Any further redraw of the line after
> this point (such as completing again on a later word) repaints correctly
> and fills the hole.
>
> Fixing that probably means diving into the completion refresh code, so I
> think committing what Geoff has so far would be fine.
I've found another problem that seems to be caused by this patch
(located by git-bisect). When a bg'd job finishes, the cursor is drawn
in the wrong place in the new prompt (#bar characters to the left).
Pressing a key bound to reset-prompt fixes it.
The simplest test case i could find was
zsh -f
PS1="frobnizz %#" #not really needed but since the default
depends on hostname...
RPS1="foo%(1j.bar.)"
true &
--
Mikael Magnusson
next prev parent reply other threads:[~2007-11-16 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 13:59 Bart Schaefer
2007-10-19 1:36 ` Geoff Wing
2007-11-16 14:57 ` Mikael Magnusson [this message]
2007-11-16 16:45 ` Bart Schaefer
2007-11-17 9:26 ` Geoff Wing
2007-11-17 10:13 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237967ef0711160657x550e449ch44c78a8798238372@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).