zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: Re: functions/Completion/Linux/_modutils
Date: Wed, 14 May 2008 08:55:11 -0700	[thread overview]
Message-ID: <080514085511.ZM11897@torch.brasslantern.com> (raw)
In-Reply-To: <482AF445.3080909@sergio.spb.ru>

On May 14,  6:16pm, sergio wrote:
}
} sudo modprobe <TAB> should list all available modules (may be all not
} loaded modules) but it doesn't.

Aha.  So the problem is with the completion for sudo, not the completion
for modprobe.  Calling "_normal" is not adequate when the environment in
which the command will run is not the same as the environment in which
the completer is running.

I can't advocate breaking _modutils (and everything else, one at a time)
for all ordinary cases, just to fix this for "sudo".  So how about this?

% zstyle :complete:sudo: environ \
    PATH="/sbin:/usr/sbin:$PATH" HOME="/root"
% sudo modprobe <TAB>

The environ style is an array of VAR=value which are exported into the
local environment before the completion for the target command is
invoked.  If this looks OK and nobody beats me to it, I'll add some
documentation, too.

Of course it would be preferable if "sudo -H /tmp/foo" would export
HOME=/tmp/foo, and if the style could be specialized to the target
user for "sudo -u" and so on, but I'm not prepared to go that far
overboard just now.

Index: Completion/Unix/Command/_sudo
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-4.0/Completion/Unix/Command/_sudo,v
retrieving revision 1.1.1.1
diff -c -r1.1.1.1 _sudo
--- zsh-4.3/Completion/Unix/Command/_sudo	9 Apr 2001 20:14:09 -0000	1.1.1.1
+++ _sudo	14 May 2008 15:22:23 -0000
@@ -1,5 +1,12 @@
 #compdef sudo
 
+local curcontext="$curcontext" environ e
+zstyle -a "$curcontext" environ environ
+
+for e in "${environ[@]}"
+do local -x "$e"
+done
+
 _arguments \
        '-V[show version]' \
        '-l[list allowed commands]' \


  parent reply	other threads:[~2008-05-14 15:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 16:19 functions/Completion/Linux/_modutils sergio
2008-05-14  3:17 ` functions/Completion/Linux/_modutils Bart Schaefer
2008-05-14 14:16   ` functions/Completion/Linux/_modutils sergio
2008-05-14 15:18     ` functions/Completion/Linux/_modutils Peter Stephenson
2008-05-14 15:56       ` functions/Completion/Linux/_modutils sergio
2008-05-14 15:55     ` Bart Schaefer [this message]
2008-05-14 16:19       ` functions/Completion/Linux/_modutils sergio
2008-05-14 16:40         ` functions/Completion/Linux/_modutils Bart Schaefer
2008-05-15 12:16           ` functions/Completion/Linux/_modutils Clint Adams
2008-05-15 16:58             ` functions/Completion/Linux/_modutils Bart Schaefer
2008-05-15 17:00               ` functions/Completion/Linux/_modutils Peter Stephenson
2008-05-16  9:26                 ` functions/Completion/Linux/_modutils Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=080514085511.ZM11897@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).