From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: functions/Completion/Linux/_modutils
Date: Wed, 14 May 2008 16:18:34 +0100 [thread overview]
Message-ID: <20080514161834.0b96c7ac@news01> (raw)
In-Reply-To: <482AF445.3080909@sergio.spb.ru>
On Wed, 14 May 2008 18:16:37 +0400
sergio <zsh@sergio.spb.ru> wrote:
> Bart Schaefer wrote:
> > On May 13, 8:19pm, sergio wrote:
> > }
> > } When i'm not root modprobe is not in my path, so
> > } in case "all_modules)" "modules" will be empty:
> >
> > When completing for what? An example command line would be helpful.
>
> sudo modprobe <TAB> should list all available modules (may be all not
> loaded modules) but it doesn't.
Shouldn't the fix be something like this?
By the way, isn't that "_files" completion three lines below screwy?
Shouldn't it be looking for .ko files (or possibly .o files depending on
the version)?
Index: Completion/Linux/Command/_modutils
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Linux/Command/_modutils,v
retrieving revision 1.6
diff -u -r1.6 _modutils
--- Completion/Linux/Command/_modutils 12 Aug 2007 09:04:52 -0000 1.6
+++ Completion/Linux/Command/_modutils 14 May 2008 15:11:48 -0000
@@ -73,7 +73,7 @@
;;
all_modules)
- modules=( ${${${${(f)"$(_call_program modules ${(M)words[1]##*/}modprobe -l 2>/dev/null)"}:#}##*/}%%.*} )
+ modules=( ${${${${(f)"$(path=($path /sbin); _call_program modules ${(M)words[1]##*/}modprobe -l 2>/dev/null)"}:#}##*/}%%.*} )
_tags files modules
while _tags; do
_requested files expl "module file" _files && ret=0
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-05-14 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 16:19 functions/Completion/Linux/_modutils sergio
2008-05-14 3:17 ` functions/Completion/Linux/_modutils Bart Schaefer
2008-05-14 14:16 ` functions/Completion/Linux/_modutils sergio
2008-05-14 15:18 ` Peter Stephenson [this message]
2008-05-14 15:56 ` functions/Completion/Linux/_modutils sergio
2008-05-14 15:55 ` functions/Completion/Linux/_modutils Bart Schaefer
2008-05-14 16:19 ` functions/Completion/Linux/_modutils sergio
2008-05-14 16:40 ` functions/Completion/Linux/_modutils Bart Schaefer
2008-05-15 12:16 ` functions/Completion/Linux/_modutils Clint Adams
2008-05-15 16:58 ` functions/Completion/Linux/_modutils Bart Schaefer
2008-05-15 17:00 ` functions/Completion/Linux/_modutils Peter Stephenson
2008-05-16 9:26 ` functions/Completion/Linux/_modutils Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514161834.0b96c7ac@news01 \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).