Re: PATCH: _zstyle additions

Re: PATCH: _zstyle additions

[Sven Wischnowsky]

Peter Stephenson wrote:

> old-list and old-menu never got added to _zstyle.  I found I had to set
> old-menu to true for it to take effect.  It should be on by default, I
> think?  If so the zstyle command needs to have -T instead of -t.

I'd say that it's your completer, so you decide...

Maybe make it default to true if $compstate[insert]==menu? Dunno.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: PATCH: _zstyle additions

[Peter Stephenson]

Sven wrote
> > old-list and old-menu never got added to _zstyle.  I found I had to set
> > old-menu to true for it to take effect.  It should be on by default, I
> > think?  If so the zstyle command needs to have -T instead of -t.
> 
> I'd say that it's your completer, so you decide...

The manual says it's on by default, it must have got turned off during some
rewrite.


Bart wrote:
> > The most common usage for telnet in my experience is
> > not to specify the host on the command line, even if you give the port.
> 
> Eh?  In my experience, telnet won't let you specify a port without a host.

I meant `user', not `host'.

Index: Completion/Core/_oldlist
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Core/_oldlist,v
retrieving revision 1.5
diff -u -r1.5 _oldlist
--- Completion/Core/_oldlist	2000/04/12 09:28:57	1.5
+++ Completion/Core/_oldlist	2000/05/18 08:51:08
@@ -40,7 +40,7 @@
   compstate[old_list]=keep
   return 0
 elif [[ $WIDGET = *complete(|-prefix|-word) ]] &&
-     zstyle -t ":completion:${curcontext}:" old-menu; then
+     zstyle -T ":completion:${curcontext}:" old-menu; then
   if [[ -n $compstate[old_insert] ]]; then
     compstate[old_list]=keep
     if [[ $WIDGET = *reverse* ]]; then

-- 
Peter Stephenson <pws@cambridgesiliconradio.com>
Cambridge Silicon Radio, Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070

Re: PATCH: _zstyle additions

[Sven Wischnowsky]

Peter Stephenson wrote:

> Sven wrote
> > > old-list and old-menu never got added to _zstyle.  I found I had to set
> > > old-menu to true for it to take effect.  It should be on by default, I
> > > think?  If so the zstyle command needs to have -T instead of -t.
> > 
> > I'd say that it's your completer, so you decide...
> 
> The manual says it's on by default, it must have got turned off during some
> rewrite.

Uh. Then it's probably my fault. Sorry.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

PATCH: _zstyle additions

[Peter Stephenson]

old-list and old-menu never got added to _zstyle.  I found I had to set
old-menu to true for it to take effect.  It should be on by default, I
think?  If so the zstyle command needs to have -T instead of -t.

Index: Completion/Builtins/_zstyle
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Builtins/_zstyle,v
retrieving revision 1.12
diff -u -r1.12 _zstyle
--- Completion/Builtins/_zstyle	2000/05/09 11:04:45	1.12
+++ Completion/Builtins/_zstyle	2000/05/17 15:25:23
@@ -53,6 +53,8 @@
   max-errors		 c:
   menu			 c:boolauto
   numbers		 c:bool
+  old-list		 c:bool 
+  old-menu		 c:bool 
   original		 c:bool
   packageset		 c:packageset
   path			 'c:_wanted directories expl directory _path_files -/'

-- 
Peter Stephenson <pws@cambridgesiliconradio.com>
Cambridge Silicon Radio, Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070