zsh-workers
 help / color / mirror / code / Atom feed
From: Marko Myllynen <myllynen@redhat.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: Zsh OpenStack completions
Date: Mon, 19 Sep 2016 09:24:38 +0300	[thread overview]
Message-ID: <0bbb2428-19f0-4741-10c5-b0c79f9df905@redhat.com> (raw)
In-Reply-To: <f61fec95-b345-b2d8-6a28-9232853c1a59@redhat.com>

Hi,

On 2016-09-09 09:38, Marko Myllynen wrote:
> On 2016-09-07 12:31, Marko Myllynen wrote:
>>
>> I updated the patch quickly to address some of your comments but based
>> on Eric's reply it sounds like we also need to discuss should we
>> include these completions in zsh upstream in the first place.
> 
> Here's an updated patch based on initial review comments from Daniel,
> most notably more comments added.
> 
> ---
>  Completion/Unix/Command/_openstack | 189 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 189 insertions(+)
>  create mode 100644 Completion/Unix/Command/_openstack

There were not further comments on this, how should we proceed? I think
the lower level technical aspects should be pretty much ok now but does
this look like something that would be appropriate for zsh upstream?

Thanks,

-- 
Marko Myllynen


  reply	other threads:[~2016-09-19  6:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 12:39 Marko Myllynen
2016-09-06 23:23 ` Eric Cook
2016-09-07  7:12   ` Marko Myllynen
2016-09-06 23:37 ` Daniel Shahaf
2016-09-07  9:31   ` Marko Myllynen
2016-09-09  6:38     ` Marko Myllynen
2016-09-19  6:24       ` Marko Myllynen [this message]
2016-09-27  5:43         ` Marko Myllynen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bbb2428-19f0-4741-10c5-b0c79f9df905@redhat.com \
    --to=myllynen@redhat.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).