"read -q" and TAB

"read -q" and TAB

[Bart Schaefer]

Does anyone remember why utils.c:getquery() interprets TAB as 'y'?  This
has been this way forever (or at least as far back as my own CVS records
go) and my only guess is that it has something to do with spckword().

This surely is broken for purposes of "read -q", and actively dangerous
for checkrmall()?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

PATCH (proposed): Re: "read -q" and TAB

[Bart Schaefer]

On Oct 25,  4:09pm, Bart Schaefer wrote:
}
} Does anyone remember why utils.c:getquery() interprets TAB as 'y'?  This
} has been this way forever (or at least as far back as my own CVS records
} go) and my only guess is that it has something to do with spckword().

In particular, I suggest the following patch:

Index: Src/utils.c
===================================================================
--- Src/utils.c	2001/10/22 14:36:45	1.9
+++ Src/utils.c	2001/10/25 16:15:05
@@ -1477,7 +1477,7 @@
     }
 
     while ((c = read1char()) >= 0) {
-	if (c == 'Y' || c == '\t')
+	if (c == 'Y')
 	    c = 'y';
 	else if (c == 'N')
 	    c = 'n';
@@ -1641,11 +1641,11 @@
 		free(pptbuf);
 		fflush(shout);
 		zbeep();
-		x = getquery("nyae ", 0);
+		x = getquery("nyae \t", 0);
 	    }
 	} else
 	    x = 'y';
-	if (x == 'y' || x == ' ') {
+	if (x == 'y' || x == ' ' || x == '\t') {
 	    *s = dupstring(best);
 	    if (hist)
 		hwrep(best);


-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net