zsh-workers
 help / color / mirror / code / Atom feed
* Missing ERR define
@ 2004-02-19 10:35 Wayne Davison
  2004-02-19 10:41 ` Peter Stephenson
  0 siblings, 1 reply; 2+ messages in thread
From: Wayne Davison @ 2004-02-19 10:35 UTC (permalink / raw)
  To: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

I'm compiling zsh on a debian sarge system without using the curses
libraries (i.e. I'm not specifying --with-curses-terminfo).  This setup
skips the check for curses.h.  Unfortunately, that means that ERR does
not get defined (since it is only found in curses.h and ncurses.h on my
system), and thus the compiling of Src/Modules/terminfo.c fails.

The attached patch defines ERR to -1 if it is not already defined.  Is
this the right way to deal with this?

..wayne..

[-- Attachment #2: zsh-err.patch --]
[-- Type: text/plain, Size: 297 bytes --]

--- Src/Modules/terminfo.c	14 Sep 2003 05:10:09 -0000	1.22
+++ Src/Modules/terminfo.c	19 Feb 2004 10:16:06 -0000
@@ -50,6 +50,9 @@ static char terminfo_nam[] = "terminfo";
 # ifdef HAVE_TERM_H
 #  include <term.h>
 # endif
+# ifndef ERR
+#  define ERR (-1)
+# endif
 
 static Param terminfo_pm;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Missing ERR define
  2004-02-19 10:35 Missing ERR define Wayne Davison
@ 2004-02-19 10:41 ` Peter Stephenson
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Stephenson @ 2004-02-19 10:41 UTC (permalink / raw)
  To: Zsh hackers list

Wayne Davison wrote:
> The attached patch defines ERR to -1 if it is not already defined.  Is
> this the right way to deal with this?

No.  This is part of the terminfo configuration rewrite that got held
up because we needed to rewrite everything else first...

The right fix is to make sure curses.h is always included, which means
changing the configure tests.

pws


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-02-19 10:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-19 10:35 Missing ERR define Wayne Davison
2004-02-19 10:41 ` Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).