Compile warnings with latest CVS

Compile warnings with latest CVS

[Bart Schaefer]

("zsh-4.0" happens to be the name of my CVS sandbox, but I'm compiling the
latest 4.2.3-dev-1 [should that be renamed zsh-4.2.4-dev-1 now?].)

../../zsh-4.0/Src/init.c:1179: warning: `autoload_zlesetkeymap' defined but not used
../../zsh-4.0/Src/utils.c:3450: warning: no previous prototype for `ucs4toutf8'
../../zsh-4.0/Src/utils.c: In function `ucs4toutf8':
../../zsh-4.0/Src/utils.c:3472: warning: suggest parentheses around arithmetic in operand of |
../../zsh-4.0/Src/utils.c: In function `getkeystring':
../../zsh-4.0/Src/utils.c:3656: warning: passing arg 2 of `iconv' from incompatible pointer type
In file included from ../../../zsh-4.0/Src/Modules/terminfo.c:53:
/usr/include/curses.h:195: warning: `ERR' redefined
/usr/include/sys/ucontext.h:74: warning: this is the location of the previous definition

Re: Compile warnings with latest CVS

[Peter Stephenson]

Bart Schaefer wrote:
> ("zsh-4.0" happens to be the name of my CVS sandbox, but I'm compiling the
> latest 4.2.3-dev-1 [should that be renamed zsh-4.2.4-dev-1 now?].)

I've renamed it 4.3.0-dev-1, since the main branch is probably heading
towards 4.3.1.

> ../../zsh-4.0/Src/init.c:1179: warning: `autoload_zlesetkeymap' defined but n
> ot used

I suppose the patch below fixes this.  I haven't thoroughly checked
whether the functions linked in and the presence or absence of "static"
are sane, however.

> ../../zsh-4.0/Src/utils.c:3450: warning: no previous prototype for `ucs4toutf
> 8'
> ../../zsh-4.0/Src/utils.c: In function `ucs4toutf8':

That doesn't seem to be prototyped anywhere that I can see.

> ../../zsh-4.0/Src/utils.c:3656: warning: passing arg 2 of `iconv' from incomp
> atible pointer type

"char **" must be close to the target area; possibly there is a const or
so missing.  Using const with doubly indirected pointers can get pretty
horrific; I'm not sure we can necessarily do much here, if that is the
problem.

> In file included from ../../../zsh-4.0/Src/Modules/terminfo.c:53:
> /usr/include/curses.h:195: warning: `ERR' redefined
> /usr/include/sys/ucontext.h:74: warning: this is the location of the previous
>  definition

This may be out of our control, too.

Index: Config/version.mk
===================================================================
RCS file: /cvsroot/zsh/zsh/Config/version.mk,v
retrieving revision 1.51
diff -u -r1.51 version.mk
--- Config/version.mk	22 Jan 2005 03:46:43 -0000	1.51
+++ Config/version.mk	7 Feb 2005 11:51:38 -0000
@@ -27,5 +27,5 @@
 # This must also serve as a shell script, so do not add spaces around the
 # `=' signs.
 
-VERSION=4.2.3-dev-1
-VERSION_DATE='January 14, 2005'
+VERSION=4.3.0-dev-1
+VERSION_DATE='February 7, 2005'
Index: Src/init.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/init.c,v
retrieving revision 1.46
diff -u -r1.46 init.c
--- Src/init.c	14 Jan 2005 13:05:21 -0000	1.46
+++ Src/init.c	7 Feb 2005 11:51:39 -0000
@@ -1173,6 +1173,8 @@
     return (unsigned char *)shingetline();
 }
 
+#ifdef UNLINKED_XMOD_zshQszle
+
 /**/
 static void
 autoload_zlesetkeymap(int mode)
@@ -1182,6 +1184,7 @@
     (*zlesetkeymapptr)(mode);
 }
 
+#endif
 
 /* compctl entry point pointers.  Similar to the ZLE ones. */
 

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

**********************************************************************

Re: Compile warnings with latest CVS

[Bart Schaefer]

On Feb 7, 11:58am, Peter Stephenson wrote:
} Subject: Re: Compile warnings with latest CVS
}
} Bart Schaefer wrote:
} > ../../zsh-4.0/Src/init.c:1179: warning: `autoload_zlesetkeymap' defined but not used
} 
} I suppose the patch below fixes this.

It changes it, at least:

init.pro:3: warning: `autoload_zlesetkeymap' declared `static' but never defined

Re: Compile warnings with latest CVS

[Peter Stephenson]

Bart Schaefer wrote:
> On Feb 7, 11:58am, Peter Stephenson wrote:
> } Subject: Re: Compile warnings with latest CVS
> }
> } Bart Schaefer wrote:
> } > ../../zsh-4.0/Src/init.c:1179: warning: `autoload_zlesetkeymap' defined b
> ut not used
> } 
> } I suppose the patch below fixes this.
> 
> It changes it, at least:
> 
> init.pro:3: warning: `autoload_zlesetkeymap' declared `static' but never defi
> ned

Hmm, I can see myself losing interest in this one rather quickly...  how
about...

Index: Src/init.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/init.c,v
retrieving revision 1.47
diff -u -r1.47 init.c
--- Src/init.c	7 Feb 2005 12:34:00 -0000	1.47
+++ Src/init.c	7 Feb 2005 12:37:52 -0000
@@ -1173,6 +1173,7 @@
     return (unsigned char *)shingetline();
 }
 
+/**/
 #ifdef UNLINKED_XMOD_zshQszle
 
 /**/
@@ -1184,6 +1185,7 @@
     (*zlesetkeymapptr)(mode);
 }
 
+/**/
 #endif
 
 /* compctl entry point pointers.  Similar to the ZLE ones. */

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

**********************************************************************

Re: Compile warnings with latest CVS

[Bart Schaefer]

On Feb 7, 12:39pm, Peter Stephenson wrote:
}
} > init.pro:3: warning: `autoload_zlesetkeymap' declared `static' but never defined
} 
} Hmm, I can see myself losing interest in this one rather quickly...

Well, yes ...

} how about...

That seems to have done it.