From: Dominic Hopf <dmaphy@googlemail.com>
To: zsh-workers@zsh.org
Subject: runhelpdir Issues with building Zsh 5.0.5 for Fedora
Date: Thu, 03 Jul 2014 20:42:48 +0200 [thread overview]
Message-ID: <1404412968.4217.12.camel@hellraiser.hellfire.rockserve.de> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 2406 bytes --]
Greetings,
attached patch is at least necessary to successfully build the latest
Zsh release on Fedora, please have a look at it as it might be useful in
other cases as well or possibly also could be applied upstream.
Furthermore, I have to set the runhelpdir path to the buildroot of the
package as it happened before for several other paths as well. The
install-section of the RPM spec file looks like this then:
%makeinstall install.info \
fndir=$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/functions \
sitefndir=$RPM_BUILD_ROOT%{_datadir}/%{name}/site-functions \
scriptdir=$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/scripts \
sitescriptdir=$RPM_BUILD_ROOT%{_datadir}/%{name}/scripts \
runhelpdir=$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/help
This unfortunately causes the whole path, including the buildroot itself
to be written into the files
/usr/share/zsh/5.0.5/functions/{run-help,_run-help}
which of course will not work and is claimed by rpmbuild:
+ /usr/lib/rpm/check-buildroot
/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/functions/_run-help:local HELPDIR=${HELPDIR:-/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/help}
/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/functions/run-help:local HELPDIR="${HELPDIR:-/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64/usr/share/zsh/5.0.5/help}"
Found '/home/dmaphy/rpmbuild/BUILDROOT/zsh-5.0.5-4.fc20.x86_64' in
installed files; aborting
error: Bad exit status from /home/dmaphy/.tmp/rpm-tmp.kg39RI (%install)
Currently I'm fixing this in the package using sed to remove the
buildroot again where it is not needed:
sed -i "s!$RPM_BUILD_ROOT%{_datadir}/%{name}/%{version}/help!
%{_datadir}/%{name}/%{version}/help!" \
$RPM_BUILD_ROOT
%{_datadir}/zsh/%{version}/functions/{run-help,_run-help}
As far as I can see there is happening something weird with the
runhelpdir within the build process I didn't understand into detail but
luckily was able to fix so far.
I'd appreciate if someone could have a deeper look into this and tell me
if I ran into a bug or if I'm basically doing something wrong.
Thanks very much in advance & Best Regards,
Dominic
--
Dominic Hopf
http://dominichopf.de/
Key Fingerprint: A7DF C4FC 07AE 4DDC 5CA0 BD93 AAB0 6019 CA7D 868D
[-- Attachment #1.2: 0000-zsh-fix-runhelpdir-issue.patch --]
[-- Type: text/x-patch, Size: 669 bytes --]
--- zsh-5.0.5/Config/defs.mk.in.original 2014-06-30 20:48:41.095977646 +0200
+++ zsh-5.0.5/Config/defs.mk.in 2014-06-30 20:49:06.132076698 +0200
@@ -95,7 +95,7 @@
MAKEDEFS = \
prefix='$(prefix)' exec_prefix='$(exec_prefix)' bindir='$(bindir)' \
libdir='$(libdir)' MODDIR='$(MODDIR)' infodir='$(infodir)' mandir='$(mandir)' \
-datadir='$(datadir)' fndir='$(fndir)' htmldir='$(htmldir)' \
+datadir='$(datadir)' fndir='$(fndir)' htmldir='$(htmldir)' runhelpdir='$(runhelpdir)' \
CC='$(CC)' CPPFLAGS='$(CPPFLAGS)' DEFS='$(DEFS)' CFLAGS='$(CFLAGS)' \
LDFLAGS='$(LDFLAGS)' EXTRA_LDFLAGS='$(EXTRA_LDFLAGS)' \
DLCFLAGS='$(DLCFLAGS)' DLLDFLAGS='$(DLLDFLAGS)' \
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next reply other threads:[~2014-07-03 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 18:42 Dominic Hopf [this message]
2014-07-08 8:44 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404412968.4217.12.camel@hellraiser.hellfire.rockserve.de \
--to=dmaphy@googlemail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).