zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Re: aliases+=(foo 'echo bar') crash
Date: Thu, 24 Jul 2014 08:29:00 -0700	[thread overview]
Message-ID: <140724082900.ZM18813@torch.brasslantern.com> (raw)
In-Reply-To: <20140724104727.5b9e9e14@pwslap01u.europe.root.pri>

On Jul 24, 10:47am, Peter Stephenson wrote:
} Subject: Re: [PATCH] Re: aliases+=(foo 'echo bar') crash
}
} On Wed, 23 Jul 2014 22:45:35 -0700
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > -	pm->node.flags |= PM_UNSET;
} > +	pm->node.flags |= (PM_UNSET|PM_SPECIAL);
} 
} It's a bit surprising this hasn't caused mayhem before now, but I
} suppose the damage is limited or non-existent until you try to set
} the parameters

Simple assignment via either aliases=(a b) or aliases[a]=b doesn't go
through the same code path, so there was no issue until the += syntax
was added ... and it's pretty unusual to append something to a hash
table that way, so I'm not that surprised that no one encountered it.


      reply	other threads:[~2014-07-24 15:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 16:09 Stephane Chazelas
2014-07-23 16:52 ` Peter Stephenson
2014-07-24  1:37   ` Bart Schaefer
2014-07-24  3:04     ` Bart Schaefer
2014-07-24  5:45       ` [PATCH] " Bart Schaefer
2014-07-24  9:47         ` Peter Stephenson
2014-07-24 15:29           ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=140724082900.ZM18813@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).