From: Sebastian Gniazdowski <psprint@fastmail.com>
To: zsh-workers@zsh.org
Subject: Re: Compiler warning after workers/39825
Date: Mon, 07 Nov 2016 23:08:53 -0800 [thread overview]
Message-ID: <1478588933.1740734.780806977.709688D0@webmail.messagingengine.com> (raw)
In-Reply-To: <161107155001.ZM25685@torch.brasslantern.com>
On Mon, Nov 7, 2016, at 03:50 PM, Bart Schaefer wrote:
> ../../zsh-5.0/Src/utils.c: In function `mb_metastrlenend':
> ../../zsh-5.0/Src/utils.c:5344: warning: comparison is always true due to
> limited range of data type
>
> commit 9c68ef08
Probably an enlightenment is scheduled on this, but first
rejecting-facts reaction is that you might have modified the line maybe?
Why would char be always in 0 .. 0x7f is a mystery. Clang doesn't yield
the warning.
BTW. this can be optimized more: `!num_in_char` instead of `complete`,
and no `num_in_char = 0` assignment.
--
Sebastian Gniazdowski
psprint@fastmail.com
next prev parent reply other threads:[~2016-11-08 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 23:50 Bart Schaefer
2016-11-08 7:08 ` Sebastian Gniazdowski [this message]
2016-11-08 7:24 ` Sebastian Gniazdowski
2016-11-08 10:01 ` Peter Stephenson
2016-11-08 10:07 ` Peter Stephenson
2016-11-08 15:38 ` Daniel Shahaf
2016-11-08 15:44 ` Peter Stephenson
2016-11-08 8:36 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478588933.1740734.780806977.709688D0@webmail.messagingengine.com \
--to=psprint@fastmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).