From: Sebastian Gniazdowski <psprint3@fastmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>, zsh-workers@zsh.org
Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures
Date: Mon, 27 Feb 2017 10:48:12 -0800 [thread overview]
Message-ID: <1488221292.1892086.894517872.57C9430B@webmail.messagingengine.com> (raw)
In-Reply-To: <170227084220.ZM2518@torch.brasslantern.com>
On Mon, Feb 27, 2017, at 08:42 AM, Bart Schaefer wrote:
> On Feb 27, 1:41am, Sebastian Gniazdowski wrote:
> } On 26 February 2017 at 20:42, Bart Schaefer <schaefer@brasslantern.com>
> } wrote:
> } > I suspect this is what comes of some attempt to optimize assignments.
> }
> } It's impossible, hashes weren't optimized.
>
> Sorry, didn't mean to imply it was the *recent* attempts.
Ah realized that slightly after a while when thought about special
hashes and how internal "ht" is.
> } BTW options+=( ), etc. still segfaults.
>
> I am not able to reproduce that. The functions+= test in V06paramter
> passes for me. Also BEFORE my patch valgrind would report errors:
> torch% options+=()
> torch% options+=()
> ==2255== Invalid read of size 4
I cannot reproduce too, I might undergo some chaos debugging, sorry.
Tried Daniel's patch, HEAD, both with and without my zrealloc hanging
around and nothing. However I can crash zsh-5.2-dev-2 that I'm normally
using. Have 3 cores in /cores from morning, their bts:
* frame #0: 0x000000010bc02aeb zsh`createparam + 75
frame #1: 0x000000010bc069ca zsh`arrhashsetfn + 394
frame #2: 0x000000010bc071e7 zsh`assignaparam + 1031
frame #3: 0x000000010bbcd14c zsh`addvars + 924
frame #4: 0x000000010bbcf8f5 zsh`execcmd_exec + 5109
* frame #0: 0x000000010a987d9b zsh`getarg + 2235
frame #1: 0x000000010a98720e zsh`getindex + 286
frame #2: 0x000000010a98954b zsh`fetchvalue + 715
frame #3: 0x000000010a9ae897 zsh`paramsubst + 5735
frame #4: 0x000000010a9aba81 zsh`stringsubst + 1777
frame #5: 0x000000010a9aafa4 zsh`prefork + 180
* frame #0: 0x00007fc86cae5530
frame #1: 0x000000010a63020e zsh`getindex + 286
frame #2: 0x000000010a63254b zsh`fetchvalue + 715
frame #3: 0x000000010a657897 zsh`paramsubst + 5735
frame #4: 0x000000010a654a81 zsh`stringsubst + 1777
frame #5: 0x000000010a653fa4 zsh`prefork + 180
I could think it's zsh-5.2-dev-2 after all, not 5.3.1, because 5.2-dev-2
yielded now:
* frame #0: 0x00007fdf704459f0
frame #1: 0x000000010ed1dfde zsh-5.2-dev-2`getindex + 286
frame #2: 0x000000010ed2031b zsh-5.2-dev-2`fetchvalue + 715
frame #3: 0x000000010ed45ce2
zsh-5.2-dev-2`___lldb_unnamed_function208$$zsh-5.2-dev-2 + 5442
frame #4: 0x000000010ed43011
zsh-5.2-dev-2`___lldb_unnamed_function204$$zsh-5.2-dev-2 + 1777
frame #5: 0x000000010ed42534 zsh-5.2-dev-2`prefork + 180
frame #6: 0x000000010ed432b2 zsh-5.2-dev-2`singsub + 66
However lldb "image list" from the 3 first cores shows:
[ 53] CD26917F-349B-359F-A44C-E9021703D9B5 0x000000010bf4b000
/usr/local/lib/zsh/5.3.1-dev-0/zsh/sched.so
...
[ 53] CD26917F-349B-359F-A44C-E9021703D9B5 0x000000010accf000
/usr/local/lib/zsh/5.3.1-dev-0/zsh/sched.so
...
[ 53] CD26917F-349B-359F-A44C-E9021703D9B5 0x000000010a978000
/usr/local/lib/zsh/5.3.1-dev-0/zsh/sched.so
But if valgrind doesn't report, I've must have some pre-Daniel patch
checkout, sorry again.
PS. Ah, I probably didn't do make install. Ran Src/zsh, but modules were
from /usr/local.
--
Sebastian Gniazdowski
psprint3@fastmail.com
next prev parent reply other threads:[~2017-02-27 18:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 9:41 Sebastian Gniazdowski
2017-02-27 16:42 ` Bart Schaefer
2017-02-27 18:48 ` Sebastian Gniazdowski [this message]
2017-02-27 20:08 ` Daniel Shahaf
2017-02-27 20:38 ` Frank Terbeck
-- strict thread matches above, loose matches on Subject: below --
2017-02-26 0:04 Bart Schaefer
2017-02-26 6:16 ` Daniel Shahaf
2017-02-26 19:42 ` Bart Schaefer
2017-02-27 9:31 ` Sebastian Gniazdowski
2017-02-28 7:45 ` Daniel Shahaf
2017-02-28 16:38 ` Bart Schaefer
2017-02-28 17:03 ` Daniel Shahaf
2017-02-28 19:04 ` Bart Schaefer
2017-02-28 21:51 ` Daniel Shahaf
2017-03-01 15:55 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488221292.1892086.894517872.57C9430B@webmail.messagingengine.com \
--to=psprint3@fastmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).