From: Sebastian Gniazdowski <psprint@yahoo.com>
To: Bart Schaefer <schaefer@brasslantern.com>,
"zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures
Date: Mon, 27 Feb 2017 09:31:45 +0000 (UTC) [thread overview]
Message-ID: <944990751.1678139.1488187905809@mail.yahoo.com> (raw)
In-Reply-To: <170226114216.ZM4201@torch.brasslantern.com>
On Sunday, February 26, 2017 8:42 PM, Bart Schaefer <schaefer@brasslantern.com> wrote:
> I suspect this is what comes of some attempt to optimize assignments.
It's impossible, hashes weren't optimized. BTW options+=( ), etc. still segfault. Added:
fprintf( stderr, "Pointer of old: %p, pointer of new: %p\n", pm->u.hash, ht );
fflush( stderr );
to setpmoptions(). Shows nicely what you've described in comment in code, don't know how to obtain the same pointer of which you mention, but you can revert to 5.1.1, apply above fprintf, and see it will be still the same. Any problem is impossible because hashes weren't optimized, and optimizations are guarded by: v->pm->gsu.a->setfn == arrsetfn.
--
Sebastian Gniazdowski
psprint@yahoo.com
next prev parent reply other threads:[~2017-02-27 12:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 0:04 Bart Schaefer
2017-02-26 6:16 ` Daniel Shahaf
2017-02-26 19:42 ` Bart Schaefer
2017-02-27 9:31 ` Sebastian Gniazdowski [this message]
2017-02-28 7:45 ` Daniel Shahaf
2017-02-28 16:38 ` Bart Schaefer
2017-02-28 17:03 ` Daniel Shahaf
2017-02-28 19:04 ` Bart Schaefer
2017-02-28 21:51 ` Daniel Shahaf
2017-03-01 15:55 ` Bart Schaefer
2017-02-27 9:41 Sebastian Gniazdowski
2017-02-27 16:42 ` Bart Schaefer
2017-02-27 18:48 ` Sebastian Gniazdowski
2017-02-27 20:08 ` Daniel Shahaf
2017-02-27 20:38 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=944990751.1678139.1488187905809@mail.yahoo.com \
--to=psprint@yahoo.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).