Src/exec.c:3961: BUG: q = 13 != queue_in = 14

Src/exec.c:3961: BUG: q = 13 != queue_in = 14

[Daniel Shahaf]

The error is reproducible, but my current recipe requires z-sy-h.
Haven't tried yet to minimize that, sorry.

Recipe:
[[[
$ git clone https://github.com/zsh-users/zsh-syntax-highlighting /tmp/zsh-syntax-highlighting
$ Src/zsh -f 
% source /tmp/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh 
% echo <TAB>
2: …/Src/exec.c:3961: BUG: q = 13 != queue_in = 14
               
]]]

Bisected to:
[[[
commit e51c9c17af51e4055efb5a2cc36739d1d7ae457f
Author: Barton E. Schaefer <schaefer@zsh.org>
Date:   Sun Jan 29 08:30:14 2017 -0800

    40453: signal handler safety for callers of patcompile(PAT_STATIC), which is not re-entrant.
]]]

Using these versions:
% echo $ZSH_PATCHLEVEL
zsh-5.3.1-229-gd78761c
% (cd /tmp/zsh-syntax-highlighting && git rev-parse HEAD)
ad522a091429ba180c930f84b2a023b40de4dbcc
% 

A similar issue was reported in 40463 (sic).

Cheers,

Daniel

Re: Src/exec.c:3961: BUG: q = 13 != queue_in = 14

[Peter Stephenson]

On Tue, 27 Jun 2017 08:38:42 +0000
Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> The error is reproducible, but my current recipe requires z-sy-h.
> Haven't tried yet to minimize that, sorry.
> 
> Recipe:
> [[[
> $ git clone https://github.com/zsh-users/zsh-syntax-highlighting /tmp/zsh-syntax-highlighting
> $ Src/zsh -f 
> % source /tmp/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh 
> % echo <TAB>
> 2: …/Src/exec.c:3961: BUG: q = 13 != queue_in = 14

I can see a couple in compctl.c... assuming zsh-syntax-highlighting
doesn't itself load compsys, they might be possibilities.

pws

diff --git a/Src/Zle/compctl.c b/Src/Zle/compctl.c
index 9e6ccb4..5414b8f 100644
--- a/Src/Zle/compctl.c
+++ b/Src/Zle/compctl.c
@@ -1867,6 +1867,7 @@ ccmakehookfn(UNUSED(Hookdef dummy), struct ccmakedat *dat)
 	    redup(osi, 0);
 
 	    dat->lst = 0;
+	    unqueue_signals();
 	    return 0;
 	}
 	if (lastmatches) {
@@ -1890,6 +1891,7 @@ ccmakehookfn(UNUSED(Hookdef dummy), struct ccmakedat *dat)
 	    redup(osi, 0);
 
 	    dat->lst = 0;
+	    unqueue_signals();
 	    return 0;
 	}
 	if (!m || !(m = m->next))

Re: Src/exec.c:3961: BUG: q = 13 != queue_in = 14

[Daniel Shahaf]

Peter Stephenson wrote on Tue, 27 Jun 2017 10:07 +0100:
> On Tue, 27 Jun 2017 08:38:42 +0000
> Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > % echo <TAB>
> > 2: …/Src/exec.c:3961: BUG: q = 13 != queue_in = 14
> 
> I can see a couple in compctl.c... assuming zsh-syntax-highlighting
> doesn't itself load compsys, they might be possibilities.

Thanks Peter, that fixed it.