From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: PATCH: Remove _message call from _mkdir
Date: Sun, 12 Apr 2015 12:46:28 -0700 [thread overview]
Message-ID: <150412124628.ZM22724@torch.brasslantern.com> (raw)
In-Reply-To: <150412101826.ZM21679@torch.brasslantern.com>
On Apr 12, 10:18am, Bart Schaefer wrote:
}
} > It works perfectly with all
} > commands but mkdir, which simply refuses to offer hidden files, ever.
}
} Which turns out to be that _mkdir calls _message which breaks out of the
} loop over _completers in _main_complete, so the _ignored completer in your
} style is never reached.
}
} _message really ought to be called only when there is no possibility of
} other completions being generated, not merely to suggest what ought to
} be typed at that point.
Unless someone has a better suggestion?
diff --git a/Completion/Unix/Command/_mkdir b/Completion/Unix/Command/_mkdir
index b5f7519..58d6c74 100644
--- a/Completion/Unix/Command/_mkdir
+++ b/Completion/Unix/Command/_mkdir
@@ -61,7 +61,7 @@ case "$state" in
[[ $variant == zsh && ${#${${words[2,-1]}:#-*}} -gt 0 ]]; then
_wanted directories expl \
'parent directory (alternatively specify name of directory)' \
- _path_files -/ && ret=0 || _message 'name of directory'
+ _path_files -/ && ret=0
fi
;;
esac
next parent reply other threads:[~2015-04-12 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5528B4C2.3010001@gmail.com>
[not found] ` <150411134410.ZM27516@torch.brasslantern.com>
[not found] ` <5529A5C2.3090603@gmail.com>
[not found] ` <150412101826.ZM21679@torch.brasslantern.com>
2015-04-12 19:46 ` Bart Schaefer [this message]
2015-04-12 19:54 ` Peter Stephenson
2015-04-12 21:05 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150412124628.ZM22724@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).